[AI4DSOC] Alert flyout code cleanup#219810
Merged
PhilippeOberti merged 1 commit intoelastic:mainfrom May 1, 2025
Merged
Conversation
stephmilovic
reviewed
May 1, 2025
...ugins/security_solution/public/flyout/ai_for_soc/components/attack_discovery_widget.test.tsx
Show resolved
Hide resolved
christineweng
approved these changes
May 1, 2025
Contributor
christineweng
left a comment
There was a problem hiding this comment.
Code changes LGTM!
1665e5d to
87c5a7d
Compare
Collaborator
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
Contributor
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
|
kapral18
added a commit
to kapral18/kibana
that referenced
this pull request
May 4, 2025
…ends-crash * main: (111 commits) [ResponseOps][Rules] Cases action title length too long (elastic#219226) [main] Sync bundled packages with Package Storage (elastic#219839) Fix ignored dynamic templates (elastic#219875) Enforce dependency review by kibana-security workflow (elastic#219262) [Security Solution] [Detections] Removes tech preview text from eql seq suppression ui (elastic#219870) [Security Solution] Fix alerts table potentially not applying alert assignees (elastic#219460) fix(slo): alert deletion (elastic#219876) [AI4DSOC] fix styling to address cutoff when screen is narrow (elastic#219306) [Security Solution][Endpoint] Response action create and history log API updates in of space awareness (elastic#218674) Update publish_oas_docs.sh to deploy Kibana Serverless API docs (elastic#219867) feat(slo): lock resource installation (elastic#219747) [AI4DSOC] Alert flyout code cleanup (elastic#219810) [fleet] fixing `isAgentlessDefault` config usage and readability improvements to `isAgentlessSetupDefault` (elastic#219423) feat(slo): Bulk delete UI (elastic#219634) m1 demo prep (elastic#219588) [Security Solution] Replace sourcerer in EQL tab with dataview picker (elastic#218897) [AI4DSOC] Attack discovery widget follow up follow up (elastic#219849) [AI Assistant] Fix some OpenAI models not accepting temperature for Inference service (elastic#218887) Update dependency msw to ~2.7.5 (main) (elastic#219289) Use new client URLs in doc link service (elastic#219600) ...
akowalska622
pushed a commit
to akowalska622/kibana
that referenced
this pull request
May 29, 2025
## Summary This PR makes some code changes to the AI4DSOC alert flyout code: - add code documentation (interfaces and components/hooks) - adding missing unit tests - cleaning up `data-test-subj` - renaming some files and moving them to follow the rest of the flyout structure **_No UI or logic has been introduced or changed._** https://github.com/user-attachments/assets/93f05cc3-5a15-4399-bac7-c018f9c1d998 The PR also add the @elastic/security-threat-hunting-investigations and @elastic/security-generative-ai teams as codeowners for the `ai-for-soc` flyout folder. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
PhilippeOberti
added a commit
to PhilippeOberti/kibana
that referenced
this pull request
May 30, 2025
## Summary This PR makes some code changes to the AI4DSOC alert flyout code: - add code documentation (interfaces and components/hooks) - adding missing unit tests - cleaning up `data-test-subj` - renaming some files and moving them to follow the rest of the flyout structure **_No UI or logic has been introduced or changed._** https://github.com/user-attachments/assets/93f05cc3-5a15-4399-bac7-c018f9c1d998 The PR also add the @elastic/security-threat-hunting-investigations and @elastic/security-generative-ai teams as codeowners for the `ai-for-soc` flyout folder. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 8d71786)
qn895
pushed a commit
to qn895/kibana
that referenced
this pull request
Jun 3, 2025
## Summary This PR makes some code changes to the AI4DSOC alert flyout code: - add code documentation (interfaces and components/hooks) - adding missing unit tests - cleaning up `data-test-subj` - renaming some files and moving them to follow the rest of the flyout structure **_No UI or logic has been introduced or changed._** https://github.com/user-attachments/assets/93f05cc3-5a15-4399-bac7-c018f9c1d998 The PR also add the @elastic/security-threat-hunting-investigations and @elastic/security-generative-ai teams as codeowners for the `ai-for-soc` flyout folder. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
stephmilovic
pushed a commit
to PhilippeOberti/kibana
that referenced
this pull request
Jun 5, 2025
This PR makes some code changes to the AI4DSOC alert flyout code: - add code documentation (interfaces and components/hooks) - adding missing unit tests - cleaning up `data-test-subj` - renaming some files and moving them to follow the rest of the flyout structure **_No UI or logic has been introduced or changed._** https://github.com/user-attachments/assets/93f05cc3-5a15-4399-bac7-c018f9c1d998 The PR also add the @elastic/security-threat-hunting-investigations and @elastic/security-generative-ai teams as codeowners for the `ai-for-soc` flyout folder. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
This was referenced Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes some code changes to the AI4DSOC alert flyout code:
data-test-subjNo UI or logic has been introduced or changed.
Screen.Recording.2025-04-30.at.4.34.26.PM.mov
The PR also add the @elastic/security-threat-hunting-investigations and @elastic/security-generative-ai teams as codeowners for the
ai-for-socflyout folder.Checklist