[AI4DSOC] Disable CellActions and PreviewLinks on the Attack discovery page#219033
Merged
PhilippeOberti merged 2 commits intoelastic:mainfrom Apr 24, 2025
Merged
Conversation
Contributor
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
...on/public/attack_discovery/pages/results/attack_discovery_panel/actionable_summary/index.tsx
Outdated
Show resolved
Hide resolved
...ic/attack_discovery/pages/results/attack_discovery_panel/tabs/attack_discovery_tab/index.tsx
Outdated
Show resolved
Hide resolved
andrew-goldstein
approved these changes
Apr 24, 2025
Contributor
andrew-goldstein
left a comment
There was a problem hiding this comment.
Thank you @PhilippeOberti!
✅ Desk tested locally with the suggested changes
LGTM 🚀
4cdc9f0 to
f736ba0
Compare
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
akowalska622
pushed a commit
to akowalska622/kibana
that referenced
this pull request
May 29, 2025
…y page (elastic#219033) ## Summary This PR disabled the cell actions and the preview links on the Attack discovery page for the AI4DSOC (searchLakeAI tier) effort. For the first phase of AI4DSOC (at least for now) we do not have the host, user, network... flyouts available, as the interactions between those flyouts and the normal alert detail flyout are many. Also, having the cell actions to filter in/out for example don't really make sense at this time, as the other pages do not listen to these. It would be confusing to the user to try to click on elements without any actual actions being performed. Before fix https://github.com/user-attachments/assets/46be2f69-ad10-43a8-8c6b-7b56e231cf0b After fix https://github.com/user-attachments/assets/aeda65c1-f762-4696-b2fb-5837c6f06c54 ## TODO If the approach looks good to the @elastic/security-generative-ai team, the following items needs to be done before merging: - [ ] write unit tests - [ ] create a ticket for the techdebt and link it in the code ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
PhilippeOberti
added a commit
to PhilippeOberti/kibana
that referenced
this pull request
May 30, 2025
…y page (elastic#219033) ## Summary This PR disabled the cell actions and the preview links on the Attack discovery page for the AI4DSOC (searchLakeAI tier) effort. For the first phase of AI4DSOC (at least for now) we do not have the host, user, network... flyouts available, as the interactions between those flyouts and the normal alert detail flyout are many. Also, having the cell actions to filter in/out for example don't really make sense at this time, as the other pages do not listen to these. It would be confusing to the user to try to click on elements without any actual actions being performed. Before fix https://github.com/user-attachments/assets/46be2f69-ad10-43a8-8c6b-7b56e231cf0b After fix https://github.com/user-attachments/assets/aeda65c1-f762-4696-b2fb-5837c6f06c54 ## TODO If the approach looks good to the @elastic/security-generative-ai team, the following items needs to be done before merging: - [ ] write unit tests - [ ] create a ticket for the techdebt and link it in the code ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit a1b749a)
PhilippeOberti
added a commit
to PhilippeOberti/kibana
that referenced
this pull request
May 30, 2025
…y page (elastic#219033) ## Summary This PR disabled the cell actions and the preview links on the Attack discovery page for the AI4DSOC (searchLakeAI tier) effort. For the first phase of AI4DSOC (at least for now) we do not have the host, user, network... flyouts available, as the interactions between those flyouts and the normal alert detail flyout are many. Also, having the cell actions to filter in/out for example don't really make sense at this time, as the other pages do not listen to these. It would be confusing to the user to try to click on elements without any actual actions being performed. Before fix https://github.com/user-attachments/assets/46be2f69-ad10-43a8-8c6b-7b56e231cf0b After fix https://github.com/user-attachments/assets/aeda65c1-f762-4696-b2fb-5837c6f06c54 ## TODO If the approach looks good to the @elastic/security-generative-ai team, the following items needs to be done before merging: - [ ] write unit tests - [ ] create a ticket for the techdebt and link it in the code ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit a1b749a)
PhilippeOberti
added a commit
to PhilippeOberti/kibana
that referenced
this pull request
Jun 4, 2025
…y page (elastic#219033) ## Summary This PR disabled the cell actions and the preview links on the Attack discovery page for the AI4DSOC (searchLakeAI tier) effort. For the first phase of AI4DSOC (at least for now) we do not have the host, user, network... flyouts available, as the interactions between those flyouts and the normal alert detail flyout are many. Also, having the cell actions to filter in/out for example don't really make sense at this time, as the other pages do not listen to these. It would be confusing to the user to try to click on elements without any actual actions being performed. Before fix https://github.com/user-attachments/assets/46be2f69-ad10-43a8-8c6b-7b56e231cf0b After fix https://github.com/user-attachments/assets/aeda65c1-f762-4696-b2fb-5837c6f06c54 ## TODO If the approach looks good to the @elastic/security-generative-ai team, the following items needs to be done before merging: - [ ] write unit tests - [ ] create a ticket for the techdebt and link it in the code ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit a1b749a)
PhilippeOberti
added a commit
that referenced
this pull request
Jun 4, 2025
…) (#222074) # Backport This will backport the following commits from `main` to `8.19`: - [[AI4DSOC] Alert summary page routing and initialization (#214889)](#214889) - [[AI4DSOC] Alert summary landing page (#215246)](#215246) - [[AI4DSOC] Alert summary dataview (#215265)](#215265) - [[AI4DSOC] Alert summary KQL bar [#215586]](#215586) - [[AI4DSOC] Alert summary KPI charts [#215585]](#215585) - [[AI4DSOR] Alert summary integrations section [#215266]](#215266) - [[AI4DSOC] Fix issue with filtering by integrations [#216574]](#216574) - [[AI4DSOC] Alert summary table setup [#216744]](#216744) - [Alerty summary table flyout setup [#217421]](#217421) - [[AI4DSOC] Alert summary alert actions in table and flyout [#217696]](#217696) - [[AI4DSOC] Alert summary table custom cell renderers [#217124]](#217124) - [[AI4DSOC] Alert summary table and flyout ai assistant [#217744]](#217744) - [[AI4DSOC] Alert summary page performance improvements [#218632]](#218632) - [[AI4DSOC] Change the Attack Discovery page to use the AI for SOC alerts table [#218736]](#218736) - [[AI4DSOC] Change the Cases page to use the AI for SOC alerts table [#218742]](#218742) - [[AI4DSOC] Fix spacing issue on alert summary landing page integration card [#218868]](#218868) - [[AI4DSOC][ResponseOps] Fix alerts table not handling undefined maintenanceWindow capability [#218999]](#218999) - [[AI4DSOC] Fix link to the new integrations page [#219030]](#219030) - [[AI4DSOC] Disable CellActions and PreviewLinks on the Attack discovery page [#219033]](#219033) - [[AI4DSOC] Add cell renderer for datetime fields to the alert summary table [#219126]](#219126) - [[AI4DSOC] Remove Assistant icon from row action in alert summary table [#219141]](#219141) - [[AI4DSOC] Add checkboxes to the alert summary table [#219169]](#219169) - [[Security Solution][AI4DSOC] Fix table not applying alert tags for Attack discovery and Cases pages in AI4DSOC [#219410]](#219410) - [[AI4DSOC] Fix logic that renders the group title when grouping by integrations [#219430]](#219430) - [[AI4DSOC] Alert summary table truncates long values and display the field/value pair in tooltip [#219438]](#219438) - [[Security Solution] Fix alerts table potentially not applying alert assignees [#219460]](#219460) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR disabled the cell actions and the preview links on the Attack discovery page for the AI4DSOC (searchLakeAI tier) effort.
For the first phase of AI4DSOC (at least for now) we do not have the host, user, network... flyouts available, as the interactions between those flyouts and the normal alert detail flyout are many.
Also, having the cell actions to filter in/out for example don't really make sense at this time, as the other pages do not listen to these. It would be confusing to the user to try to click on elements without any actual actions being performed.
Before fix
Screen.Recording.2025-04-23.at.10.15.30.PM.mov
After fix
Screen.Recording.2025-04-23.at.10.13.10.PM.mov
TODO
If the approach looks good to the @elastic/security-generative-ai team, the following items needs to be done before merging:
Checklist