[chore] Add rule to avoid duplicate fp-ts imports#218593
Merged
dej611 merged 5 commits intoelastic:mainfrom Apr 23, 2025
Merged
[chore] Add rule to avoid duplicate fp-ts imports#218593dej611 merged 5 commits intoelastic:mainfrom
dej611 merged 5 commits intoelastic:mainfrom
Conversation
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
jbudz
approved these changes
Apr 17, 2025
Contributor
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
miltonhultgren
approved these changes
Apr 18, 2025
paul-tavares
approved these changes
Apr 18, 2025
Contributor
paul-tavares
left a comment
There was a problem hiding this comment.
LGTM - elastic/security-defend-workflows team
PhilippeOberti
approved these changes
Apr 18, 2025
Contributor
PhilippeOberti
left a comment
There was a problem hiding this comment.
LGTM for the Threat Hunting Investigations team
dominiqueclarke
approved these changes
Apr 21, 2025
Contributor
dominiqueclarke
left a comment
There was a problem hiding this comment.
Obs ux management changes LGTM
dplumlee
approved these changes
Apr 21, 2025
rylnd
approved these changes
Apr 21, 2025
Contributor
rylnd
left a comment
There was a problem hiding this comment.
Detection Engine changes are limited to use of Either (mainly in our Exceptions code) and LGTM.
rmyz
approved these changes
Apr 22, 2025
Contributor
rmyz
left a comment
There was a problem hiding this comment.
infra&services changes LGTM
cnasikas
approved these changes
Apr 23, 2025
gsoldevila
reviewed
Apr 23, 2025
.eslintrc.js
Outdated
| name: '@testing-library/react-hooks', | ||
| message: 'Please use @testing-library/react instead', | ||
| }, | ||
| ...['Option', 'pipeable', 'TaskEither', 'Either', 'function', 'Task', 'Set', 'Ord', 'Array'].map( |
Member
There was a problem hiding this comment.
NIT
- I searched through the codebase and found one more:
NonEmptyArray. - Folks could also import directly from the
lib/index.ts, e.g.import { either } from 'fp-ts/lib'; - Going to the lib folder, I compiled the complete list:
['Alt', 'Alternative', 'Applicative', 'Apply', 'Array', 'Bifunctor', 'boolean', 'BooleanAlgebra', 'Bounded', 'BoundedDistributiveLattice', 'BoundedJoinSemilattice', 'BoundedLattice', 'BoundedMeetSemilattice', 'Category', 'Chain', 'ChainRec', 'Choice', 'Comonad', 'Compactable', 'Console', 'Const', 'Contravariant', 'Date', 'DistributiveLattice', 'Either', 'EitherT', 'Eq', 'Extend', 'Field', 'Filterable', 'FilterableWithIndex', 'Foldable', 'FoldableWithIndex', 'function', 'Functor', 'FunctorWithIndex', 'Group', 'HeytingAlgebra', 'Identity', 'Invariant', 'IO', 'IOEither', 'IORef', 'JoinSemilattice', 'Lattice', 'Magma', 'Map', 'MeetSemilattice', 'Monad', 'MonadIO', 'MonadTask', 'MonadThrow', 'Monoid', 'NonEmptyArray', 'Option', 'OptionT', 'Ord', 'Ordering', 'pipeable', 'Profunctor', 'Random', 'Reader', 'ReaderEither', 'ReaderT', 'ReaderTask', 'ReaderTaskEither', 'ReadonlyArray', 'ReadonlyMap', 'ReadonlyNonEmptyArray', 'ReadonlyRecord', 'ReadonlySet', 'ReadonlyTuple', 'Record', 'Ring', 'Semigroup', 'Semigroupoid', 'Semiring', 'Set', 'Show', 'State', 'StateReaderTaskEither', 'StateT', 'Store', 'Strong', 'Task', 'TaskEither', 'TaskThese', 'These', 'TheseT', 'Traced', 'Traversable', 'TraversableWithIndex', 'Tree', 'Tuple', 'Unfoldable', 'ValidationT', 'Witherable', 'Writer', 'WriterT']
gsoldevila
approved these changes
Apr 23, 2025
Member
gsoldevila
left a comment
There was a problem hiding this comment.
One minor remark, don't want to block the PR on that
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
|
akowalska622
pushed a commit
to akowalska622/kibana
that referenced
this pull request
May 29, 2025
## Summary This PR is the counter part of elastic#217034 to avoid making the same mistake again in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is the counter part of #217034 to avoid making the same mistake again in the future.