[Security Solution] clean unused types, export components and add many unit tests#217100
Merged
PhilippeOberti merged 3 commits intoelastic:mainfrom Apr 4, 2025
Merged
Conversation
Contributor
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
…ns, and add many unit tests
8e1d8aa to
e0777a1
Compare
cnasikas
approved these changes
Apr 4, 2025
lgestc
approved these changes
Apr 4, 2025
Contributor
lgestc
left a comment
There was a problem hiding this comment.
thank you for the cleanup 💪
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
Contributor
|
Starting backport for target branches: 8.x |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
PhilippeOberti
added a commit
to PhilippeOberti/kibana
that referenced
this pull request
Apr 4, 2025
…y unit tests (elastic#217100) ## Summary This code change was originally part of [a bigger PR](elastic#216744) related to the AI for SOC effort. I decided to split the work for 2 reasons: - less files to review, less teams impacted - this current PR will easily be backported to `8.x` while the AI for SOC is only targeting `9.1` This PR makes only a few small changes: - remove unused types - export a few components/functions outside of the `alerts_table` folder to make them reusable within the new AI for SOC alert summary page (see PR linked above) - add a lot of unit tests to everything, especially the now exported components/functions #### UI remains unchanged:     ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios Will unblock elastic/security-team#11973 (cherry picked from commit 837059b) # Conflicts: # src/platform/packages/shared/kbn-grouping/src/containers/query/index.test.ts # src/platform/packages/shared/kbn-grouping/src/mocks.ts
PhilippeOberti
added a commit
that referenced
this pull request
Apr 4, 2025
…dd many unit tests (#217100) (#217253) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] clean unused types, export components and add many unit tests (#217100)](#217100) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Philippe Oberti","email":"philippe.oberti@elastic.co"},"sourceCommit":{"committedDate":"2025-04-04T19:11:23Z","message":"[Security Solution] clean unused types, export components and add many unit tests (#217100)\n\n## Summary\n\nThis code change was originally part of [a bigger\nPR](#216744) related to the AI for\nSOC effort. I decided to split the work for 2 reasons:\n- less files to review, less teams impacted\n- this current PR will easily be backported to `8.x` while the AI for\nSOC is only targeting `9.1`\n\nThis PR makes only a few small changes:\n- remove unused types\n- export a few components/functions outside of the `alerts_table` folder\nto make them reusable within the new AI for SOC alert summary page (see\nPR linked above)\n- add a lot of unit tests to everything, especially the now exported\ncomponents/functions\n\n#### UI remains unchanged:\n\n\n\n\n\n\n### Checklist\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n\nWill unblock https://github.com/elastic/security-team/issues/11973","sha":"837059bcfa83db2ee997c8febace8111e345a12f","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Threat Hunting:Investigations","backport:version","v9.1.0","v8.19.0"],"title":"[Security Solution] clean unused types, export components and add many unit tests","number":217100,"url":"https://github.com/elastic/kibana/pull/217100","mergeCommit":{"message":"[Security Solution] clean unused types, export components and add many unit tests (#217100)\n\n## Summary\n\nThis code change was originally part of [a bigger\nPR](#216744) related to the AI for\nSOC effort. I decided to split the work for 2 reasons:\n- less files to review, less teams impacted\n- this current PR will easily be backported to `8.x` while the AI for\nSOC is only targeting `9.1`\n\nThis PR makes only a few small changes:\n- remove unused types\n- export a few components/functions outside of the `alerts_table` folder\nto make them reusable within the new AI for SOC alert summary page (see\nPR linked above)\n- add a lot of unit tests to everything, especially the now exported\ncomponents/functions\n\n#### UI remains unchanged:\n\n\n\n\n\n\n### Checklist\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n\nWill unblock https://github.com/elastic/security-team/issues/11973","sha":"837059bcfa83db2ee997c8febace8111e345a12f"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/217100","number":217100,"mergeCommit":{"message":"[Security Solution] clean unused types, export components and add many unit tests (#217100)\n\n## Summary\n\nThis code change was originally part of [a bigger\nPR](#216744) related to the AI for\nSOC effort. I decided to split the work for 2 reasons:\n- less files to review, less teams impacted\n- this current PR will easily be backported to `8.x` while the AI for\nSOC is only targeting `9.1`\n\nThis PR makes only a few small changes:\n- remove unused types\n- export a few components/functions outside of the `alerts_table` folder\nto make them reusable within the new AI for SOC alert summary page (see\nPR linked above)\n- add a lot of unit tests to everything, especially the now exported\ncomponents/functions\n\n#### UI remains unchanged:\n\n\n\n\n\n\n### Checklist\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n\nWill unblock https://github.com/elastic/security-team/issues/11973","sha":"837059bcfa83db2ee997c8febace8111e345a12f"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This code change was originally part of a bigger PR related to the AI for SOC effort. I decided to split the work for 2 reasons:
8.xwhile the AI for SOC is only targeting9.1This PR makes only a few small changes:
alerts_tablefolder to make them reusable within the new AI for SOC alert summary page (see PR linked above)UI remains unchanged:
Checklist
Will unblock https://github.com/elastic/security-team/issues/11973