Skip to content

[Docs] Remove mention of visualization:colorMapping setting#215962

Merged
wajihaparvez merged 4 commits intoelastic:mainfrom
wajihaparvez:remove-vis-colorMapping-adv-setting
Mar 27, 2025
Merged

[Docs] Remove mention of visualization:colorMapping setting#215962
wajihaparvez merged 4 commits intoelastic:mainfrom
wajihaparvez:remove-vis-colorMapping-adv-setting

Conversation

@wajihaparvez
Copy link
Copy Markdown
Contributor

@wajihaparvez wajihaparvez commented Mar 25, 2025 •
edited by kibanamachine
Loading

Summary

This PR removes the visualization:colorMapping setting from the Advanced settings page.

Rel: #197802, #616

@wajihaparvez wajihaparvez added Team:Docs release_note:skip Skip the PR/issue when compiling release notes v9.0.0 backport:version Backport to applied version labels labels Mar 25, 2025
@wajihaparvez wajihaparvez self-assigned this Mar 25, 2025
nickofthyme
nickofthyme approved these changes Mar 26, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@nickofthyme nickofthyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I also added a commit to remove the unused constants related to this setting.

@wajihaparvez wajihaparvez marked this pull request as ready for review March 26, 2025 19:08
@wajihaparvez wajihaparvez requested review from a team as code owners March 26, 2025 19:08
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Mar 26, 2025

Pinging @elastic/kibana-docs (Team:Docs)

sabarasaba
sabarasaba approved these changes Mar 27, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@sabarasaba sabarasaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kibana management change lgtm

florent-leborgne
florent-leborgne approved these changes Mar 27, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@florent-leborgne florent-leborgne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌻 nice

@wajihaparvez wajihaparvez enabled auto-merge (squash) March 27, 2025 14:00
@wajihaparvez wajihaparvez merged commit 37528a6 into elastic:main Mar 27, 2025
9 checks passed
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 27, 2025

Starting backport for target branches: 9.0

https://github.com/elastic/kibana/actions/runs/14112209768

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Mar 27, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/management-settings-ids 137 136 -1
charts 255 254 -1
total -2

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
charts 42.6KB 42.6KB -59.0B
Unknown metric groups

API count

id before after diff
@kbn/management-settings-ids 138 137 -1
charts 271 270 -1
total -2

cc @wajihaparvez

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 27, 2025
@wajihaparvez @nickofthyme
[Docs] Remove mention of visualization:colorMapping setting (elastic#…
1ff0303 
…215962)

## Summary

This PR removes the `visualization:colorMapping` setting from the
Advanced settings page.

Rel: elastic#197802,
[elastic#616](elastic/platform-docs-team#616)

---------

Co-authored-by: Nick Partridge <nicholas.partridge@elastic.co>
(cherry picked from commit 37528a6)
@kibanamachine kibanamachine mentioned this pull request Mar 27, 2025
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 27, 2025

💚 All backports created successfully

Status Branch Result
✅ 9.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Mar 27, 2025
@kibanamachine @wajihaparvez
[9.0] [Docs] Remove mention of visualization:colorMapping setting (#2…
8752409 
…15962) (#216213)

# Backport

This will backport the following commits from `main` to `9.0`:
- [[Docs] Remove mention of visualization:colorMapping setting
(#215962)](#215962)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT
[{"author":{"name":"wajihaparvez","email":"wajiha.parvez@elastic.co"},"sourceCommit":{"committedDate":"2025-03-27T16:50:27Z","message":"[Docs]
Remove mention of visualization:colorMapping setting (#215962)\n\n##
Summary\n\nThis PR removes the `visualization:colorMapping` setting from
the\nAdvanced settings page.\n\nRel:
https://github.com/elastic/kibana/pull/197802,\n[#616](https://github.com/elastic/platform-docs-team/issues/616)\n\n---------\n\nCo-authored-by:
Nick Partridge
<nicholas.partridge@elastic.co>","sha":"37528a6cb4b9613a302ee787c28d0bb5981bcc79","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Docs","release_note:skip","v9.0.0","docs","backport:version","v9.1.0"],"title":"[Docs]
Remove mention of visualization:colorMapping
setting","number":215962,"url":"https://github.com/elastic/kibana/pull/215962","mergeCommit":{"message":"[Docs]
Remove mention of visualization:colorMapping setting (#215962)\n\n##
Summary\n\nThis PR removes the `visualization:colorMapping` setting from
the\nAdvanced settings page.\n\nRel:
https://github.com/elastic/kibana/pull/197802,\n[#616](https://github.com/elastic/platform-docs-team/issues/616)\n\n---------\n\nCo-authored-by:
Nick Partridge
<nicholas.partridge@elastic.co>","sha":"37528a6cb4b9613a302ee787c28d0bb5981bcc79"}},"sourceBranch":"main","suggestedTargetBranches":["9.0"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/215962","number":215962,"mergeCommit":{"message":"[Docs]
Remove mention of visualization:colorMapping setting (#215962)\n\n##
Summary\n\nThis PR removes the `visualization:colorMapping` setting from
the\nAdvanced settings page.\n\nRel:
https://github.com/elastic/kibana/pull/197802,\n[#616](https://github.com/elastic/platform-docs-team/issues/616)\n\n---------\n\nCo-authored-by:
Nick Partridge
<nicholas.partridge@elastic.co>","sha":"37528a6cb4b9613a302ee787c28d0bb5981bcc79"}}]}]
BACKPORT-->

Co-authored-by: wajihaparvez <wajiha.parvez@elastic.co>
cqliu1 pushed a commit to cqliu1/kibana that referenced this pull request Mar 31, 2025
@wajihaparvez @nickofthyme @cqliu1
[Docs] Remove mention of visualization:colorMapping setting (elastic#…
26761bf 
…215962)

## Summary

This PR removes the `visualization:colorMapping` setting from the
Advanced settings page.

Rel: elastic#197802,
[elastic#616](elastic/platform-docs-team#616)

---------

Co-authored-by: Nick Partridge <nicholas.partridge@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sabarasaba sabarasaba sabarasaba approved these changes

@markov00 markov00 markov00 approved these changes

@florent-leborgne florent-leborgne florent-leborgne approved these changes

@nickofthyme nickofthyme nickofthyme approved these changes

@lcawl lcawl Awaiting requested review from lcawl

Assignees

@wajihaparvez wajihaparvez

Labels

backport:version Backport to applied version labels docs release_note:skip Skip the PR/issue when compiling release notes Team:Docs v9.0.0 v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@wajihaparvez @elasticmachine @kibanamachine @sabarasaba @markov00 @florent-leborgne @nickofthyme