Skip to content

[A11y][APM] Use nameTooltip api for dependencies tables#215940

Merged
rmyz merged 2 commits intoelastic:mainfrom
rmyz:195041-a11y-apm-use-nametooltip-for-dependencies
Mar 26, 2025
Merged

[A11y][APM] Use nameTooltip api for dependencies tables#215940
rmyz merged 2 commits intoelastic:mainfrom
rmyz:195041-a11y-apm-use-nametooltip-for-dependencies

Conversation

@rmyz
Copy link
Copy Markdown
Contributor

@rmyz rmyz commented Mar 25, 2025 •
edited by kibanamachine
Loading

Summary

Closes #195041

This PR addresses the issue where the table name's tooltip cannot be focused with keyboard.

Video

Kapture.2025-03-26.at.09.27.10.mp4

@rmyz rmyz self-assigned this Mar 25, 2025
@rmyz rmyz requested a review from a team March 25, 2025 18:14
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Mar 25, 2025

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

cauemarcondes
cauemarcondes approved these changes Mar 25, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you add a video showing it working?

@rmyz
Copy link
Copy Markdown
Contributor Author

rmyz commented Mar 26, 2025

LGTM. Could you add a video showing it working?

@cauemarcondes video added in the description

MiriamAparicio
MiriamAparicio approved these changes Mar 26, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@MiriamAparicio MiriamAparicio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌟

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Mar 26, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #114 / Spaces app space solution tour solution tour does not show the solution tour after deleting spaces and leave only the default

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 2.5MB 2.5MB -257.0B

History

cc @rmyz

@rmyz rmyz merged commit 35f8739 into elastic:main Mar 26, 2025
9 checks passed
@rmyz rmyz deleted the 195041-a11y-apm-use-nametooltip-for-dependencies branch March 26, 2025 12:58
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 26, 2025

Starting backport for target branches: 8.16, 8.17, 8.18, 8.x

https://github.com/elastic/kibana/actions/runs/14083880770

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 26, 2025
@rmyz
[A11y][APM] Use nameTooltip api for dependencies tables (elastic#21…
5522b5d 
…5940)

## Summary

Closes elastic#195041

This PR addresses the issue where the table name's tooltip cannot be
focused with keyboard.

## Video

https://github.com/user-attachments/assets/bec887fd-5a3b-4fa9-b84b-17a1a4187fbc
(cherry picked from commit 35f8739)
@kibanamachine kibanamachine mentioned this pull request Mar 26, 2025
Closed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 26, 2025
@rmyz
[A11y][APM] Use nameTooltip api for dependencies tables (elastic#21…
7faa287 
…5940)

## Summary

Closes elastic#195041

This PR addresses the issue where the table name's tooltip cannot be
focused with keyboard.

## Video

https://github.com/user-attachments/assets/bec887fd-5a3b-4fa9-b84b-17a1a4187fbc
(cherry picked from commit 35f8739)
@kibanamachine kibanamachine mentioned this pull request Mar 26, 2025
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 26, 2025

💔 Some backports could not be created

Status Branch Result
❌ 8.16 Backport failed because of merge conflicts
❌ 8.17 Backport failed because of merge conflicts
✅ 8.18
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 215940

Questions ?

Please refer to the Backport tool documentation

@rmyz rmyz mentioned this pull request Mar 26, 2025
Closed
rmyz added a commit to rmyz/kibana that referenced this pull request Mar 26, 2025
@rmyz
[A11y][APM] Use nameTooltip api for dependencies tables (elastic#21…
ec25cdb 
…5940)

## Summary

Closes elastic#195041

This PR addresses the issue where the table name's tooltip cannot be
focused with keyboard.

## Video

https://github.com/user-attachments/assets/bec887fd-5a3b-4fa9-b84b-17a1a4187fbc
(cherry picked from commit 35f8739)

# Conflicts:
#	x-pack/plugins/observability_solution/apm/public/components/app/dependency_detail_operations/dependency_detail_operations_list/index.tsx
#	x-pack/plugins/observability_solution/apm/public/components/shared/dependencies_table/get_span_metric_columns.tsx
#	x-pack/plugins/observability_solution/apm/public/components/shared/dependencies_table/index.tsx
@rmyz rmyz mentioned this pull request Mar 26, 2025
Closed
@rmyz
Copy link
Copy Markdown
Contributor Author

rmyz commented Mar 26, 2025

💚 All backports created successfully

Status Branch Result
✅ 8.17
✅ 8.16

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@rmyz rmyz added the v9.0.0 label Mar 26, 2025
rmyz added a commit to rmyz/kibana that referenced this pull request Mar 26, 2025
@rmyz
[A11y][APM] Use nameTooltip api for dependencies tables (elastic#21…
49b3b42 
…5940)

## Summary

Closes elastic#195041

This PR addresses the issue where the table name's tooltip cannot be
focused with keyboard.

## Video

https://github.com/user-attachments/assets/bec887fd-5a3b-4fa9-b84b-17a1a4187fbc
(cherry picked from commit 35f8739)

# Conflicts:
#	x-pack/plugins/observability_solution/apm/public/components/app/dependency_detail_operations/dependency_detail_operations_list/index.tsx
#	x-pack/plugins/observability_solution/apm/public/components/shared/dependencies_table/get_span_metric_columns.tsx
#	x-pack/plugins/observability_solution/apm/public/components/shared/dependencies_table/index.tsx
@rmyz rmyz added backport:version Backport to applied version labels and removed backport:prev-major labels Mar 26, 2025
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 26, 2025

Starting backport for target branches: 9.0

https://github.com/elastic/kibana/actions/runs/14084470466

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 26, 2025
@rmyz
[A11y][APM] Use nameTooltip api for dependencies tables (elastic#21…
60bc6f2 
…5940)

## Summary

Closes elastic#195041

This PR addresses the issue where the table name's tooltip cannot be
focused with keyboard.

## Video

https://github.com/user-attachments/assets/bec887fd-5a3b-4fa9-b84b-17a1a4187fbc
(cherry picked from commit 35f8739)
@kibanamachine kibanamachine mentioned this pull request Mar 26, 2025
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 26, 2025

💚 All backports created successfully

Status Branch Result
✅ 9.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Mar 26, 2025
@kibanamachine @rmyz
[8.x] [A11y][APM] Use nameTooltip api for dependencies tables (#215940
ea890b2 
) (#216035)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[A11y][APM] Use `nameTooltip` api for dependencies tables
(#215940)](#215940)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Sergi
Romeu","email":"sergi.romeu@elastic.co"},"sourceCommit":{"committedDate":"2025-03-26T12:58:34Z","message":"[A11y][APM]
Use `nameTooltip` api for dependencies tables (#215940)\n\n##
Summary\n\nCloses
https://github.com/elastic/kibana/issues/195041\n\nThis PR addresses the
issue where the table name's tooltip cannot be\nfocused with
keyboard.\n\n##
Video\n\n\nhttps://github.com/user-attachments/assets/bec887fd-5a3b-4fa9-b84b-17a1a4187fbc","sha":"35f8739b9a1a8f9bc231161afa39118f7ff4fbaa","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","apm","backport:prev-major","Team:obs-ux-infra_services","a11y","v9.1.0"],"title":"[A11y][APM]
Use `nameTooltip` api for dependencies
tables","number":215940,"url":"https://github.com/elastic/kibana/pull/215940","mergeCommit":{"message":"[A11y][APM]
Use `nameTooltip` api for dependencies tables (#215940)\n\n##
Summary\n\nCloses
https://github.com/elastic/kibana/issues/195041\n\nThis PR addresses the
issue where the table name's tooltip cannot be\nfocused with
keyboard.\n\n##
Video\n\n\nhttps://github.com/user-attachments/assets/bec887fd-5a3b-4fa9-b84b-17a1a4187fbc","sha":"35f8739b9a1a8f9bc231161afa39118f7ff4fbaa"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/215940","number":215940,"mergeCommit":{"message":"[A11y][APM]
Use `nameTooltip` api for dependencies tables (#215940)\n\n##
Summary\n\nCloses
https://github.com/elastic/kibana/issues/195041\n\nThis PR addresses the
issue where the table name's tooltip cannot be\nfocused with
keyboard.\n\n##
Video\n\n\nhttps://github.com/user-attachments/assets/bec887fd-5a3b-4fa9-b84b-17a1a4187fbc","sha":"35f8739b9a1a8f9bc231161afa39118f7ff4fbaa"}}]}]
BACKPORT-->

Co-authored-by: Sergi Romeu <sergi.romeu@elastic.co>
kibanamachine added a commit that referenced this pull request Mar 26, 2025
@kibanamachine @rmyz
[9.0] [A11y][APM] Use nameTooltip api for dependencies tables (#215940
a28b2c9 
) (#216042)

# Backport

This will backport the following commits from `main` to `9.0`:
- [[A11y][APM] Use `nameTooltip` api for dependencies tables
(#215940)](#215940)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Sergi
Romeu","email":"sergi.romeu@elastic.co"},"sourceCommit":{"committedDate":"2025-03-26T12:58:34Z","message":"[A11y][APM]
Use `nameTooltip` api for dependencies tables (#215940)\n\n##
Summary\n\nCloses
https://github.com/elastic/kibana/issues/195041\n\nThis PR addresses the
issue where the table name's tooltip cannot be\nfocused with
keyboard.\n\n##
Video\n\n\nhttps://github.com/user-attachments/assets/bec887fd-5a3b-4fa9-b84b-17a1a4187fbc","sha":"35f8739b9a1a8f9bc231161afa39118f7ff4fbaa","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","apm","Team:obs-ux-infra_services","backport:version","a11y","v9.1.0"],"title":"[A11y][APM]
Use `nameTooltip` api for dependencies
tables","number":215940,"url":"https://github.com/elastic/kibana/pull/215940","mergeCommit":{"message":"[A11y][APM]
Use `nameTooltip` api for dependencies tables (#215940)\n\n##
Summary\n\nCloses
https://github.com/elastic/kibana/issues/195041\n\nThis PR addresses the
issue where the table name's tooltip cannot be\nfocused with
keyboard.\n\n##
Video\n\n\nhttps://github.com/user-attachments/assets/bec887fd-5a3b-4fa9-b84b-17a1a4187fbc","sha":"35f8739b9a1a8f9bc231161afa39118f7ff4fbaa"}},"sourceBranch":"main","suggestedTargetBranches":["9.0"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/215940","number":215940,"mergeCommit":{"message":"[A11y][APM]
Use `nameTooltip` api for dependencies tables (#215940)\n\n##
Summary\n\nCloses
https://github.com/elastic/kibana/issues/195041\n\nThis PR addresses the
issue where the table name's tooltip cannot be\nfocused with
keyboard.\n\n##
Video\n\n\nhttps://github.com/user-attachments/assets/bec887fd-5a3b-4fa9-b84b-17a1a4187fbc","sha":"35f8739b9a1a8f9bc231161afa39118f7ff4fbaa"}},{"url":"https://github.com/elastic/kibana/pull/216034","number":216034,"branch":"8.18","state":"OPEN"},{"url":"https://github.com/elastic/kibana/pull/216035","number":216035,"branch":"8.x","state":"OPEN"},{"url":"https://github.com/elastic/kibana/pull/216036","number":216036,"branch":"8.17","state":"OPEN"},{"url":"https://github.com/elastic/kibana/pull/216038","number":216038,"branch":"8.16","state":"OPEN"}]}]
BACKPORT-->

Co-authored-by: Sergi Romeu <sergi.romeu@elastic.co>
cqliu1 pushed a commit to cqliu1/kibana that referenced this pull request Mar 31, 2025
@rmyz @cqliu1
[A11y][APM] Use nameTooltip api for dependencies tables (elastic#21…
5d77c9d 
…5940)

## Summary

Closes elastic#195041

This PR addresses the issue where the table name's tooltip cannot be
focused with keyboard.

## Video


https://github.com/user-attachments/assets/bec887fd-5a3b-4fa9-b84b-17a1a4187fbc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jennypavlova jennypavlova jennypavlova approved these changes

@MiriamAparicio MiriamAparicio MiriamAparicio approved these changes

@cauemarcondes cauemarcondes cauemarcondes approved these changes

Assignees

@rmyz rmyz

Labels

a11y Accessibility issue apm backport:version Backport to applied version labels release_note:fix Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation. v8.19.0 v9.0.0 v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Obs Applications > Dependency Detail][SCREEN READER]: Tooltips must be able to take keyboard focus: 0005

6 participants

@rmyz @elasticmachine @kibanamachine @jennypavlova @MiriamAparicio @cauemarcondes