[Ai4dSoc][Serverless] Hide notes/timelines for search_ai_lake tier#215334
[Ai4dSoc][Serverless] Hide notes/timelines for search_ai_lake tier#215334ashokaditya merged 14 commits intoelastic:mainfrom
search_ai_lake tier#215334Conversation
82aa04c to
8fbb177
Compare
Timeline and notes are not available on searchAiLake tier. The features are hidden on alerts and on custom role creation flyout
8fbb177 to
f505f4a
Compare
fef1b67 to
507bde4
Compare
|
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
x-pack/test/security_solution_cypress/cypress/e2e/ai4dsoc/privileges/security_privileges.cy.ts
Outdated
Show resolved
Hide resolved
x-pack/test/security_solution_cypress/cypress/e2e/ai4dsoc/privileges/security_privileges.cy.ts
Outdated
Show resolved
Hide resolved
x-pack/test/security_solution_cypress/cypress/e2e/ai4dsoc/privileges/security_privileges.cy.ts
Outdated
Show resolved
Hide resolved
x-pack/test/security_solution_cypress/cypress/e2e/ai4dsoc/privileges/security_privileges.cy.ts
Outdated
Show resolved
Hide resolved
x-pack/test/security_solution_cypress/cypress/e2e/ai4dsoc/privileges/security_privileges.cy.ts
Outdated
Show resolved
Hide resolved
MadameSheema
left a comment
There was a problem hiding this comment.
@ashokaditya please add a codeowner for the new test folder :)
jbudz
left a comment
There was a problem hiding this comment.
src/cli/serve/compile_config_stack.js LGTM
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]Page load bundle
History
cc @ashokaditya |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
search_ai_lake tiersearch_ai_lake tier
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
3 similar comments
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Starting backport for target branches: 8.19 |
|
Starting backport for target branches: 8.19 |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
1 similar comment
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
) > [!CAUTION] > Do not merge yet! > This PR is mergeable based on the assumption that we do not allow downgrading to `search_ai_lake` tier from `essentials`/`complete` or `trial` `complete/essentals`. On serverless with following sets of product types/lines timelines and notes are not available to the user. ```json5 [ { product_line: 'ai_soc', product_tier: 'search_ai_lake' } ] ``` or ```json5 [ { product_line: 'security', product_tier: 'search_ai_lake' } ] ``` or with ```json5 [ { product_line: 'ai_soc', product_tier: 'search_ai_lake' }, { product_line: 'security', product_tier: 'search_ai_lake' } ] ``` This applies to custom role creation flyout where timelines/notes privileges are not available for RBAC.  Also on alerts page notes and timelines is not available action items. Trying to access these via URL does not show them either.   1. While on the Kibana root directory, run ES/Kibana on serverless mode with: ```bash yarn es serverless --kill --projectType security --kibanaUrl=http://0.0.0.0:5601 ``` and on a new window ```bash yarn serverless-security --no-base-path ``` Enable the AI for SOC tier, by adding the following to your `serverless.security.dev.yaml` file: ```json5 xpack.securitySolutionServerless.productTypes: [ { product_line: 'ai_soc', product_tier: 'search_ai_lake' }, ] ``` 2. Once Kibana is up and running login in with the `admin` role using the role dropdown. 3. Navigate to `app/management/roles/edit` 4. Click on `Assign to space` button and assign a space to that role on the `Assign role to spaces` flyout. 5. Expand the `Security` privileges and verify that only 4 sub-privileges are seen and that Timelines and Notes are not among them. Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... (cherry picked from commit cf1cd55)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
) (#222752) # Backport This will backport the following commits from `main` to `8.19`: - [[Ai4dSoc] Hide notes/timelines for `search_ai_lake` tier (#215334)](#215334) > [!Note] #221998 already backported changes in `config/serverless.security.search_ai_lake.yml` which is why it does not appear in this backport PR. <!--- Backport version: 10.0.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Ash","email":"1849116+ashokaditya@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-04-02T13:05:12Z","message":"[Ai4dSoc] Hide notes/timelines for `search_ai_lake` tier (#215334)\n\n> [!CAUTION]\n> Do not merge yet!\n> This PR is mergeable based on the assumption that we do not allow\ndowngrading to `search_ai_lake` tier from `essentials`/`complete` or\n`trial` `complete/essentals`.\n\n## Summary\n\nOn serverless with following sets of product types/lines timelines and\nnotes are not available to the user.\n\n```json5\n[\n { product_line: 'ai_soc', product_tier: 'search_ai_lake' }\n]\n```\nor \n```json5\n[\n { product_line: 'security', product_tier: 'search_ai_lake' }\n]\n```\nor with \n```json5\n[\n { product_line: 'ai_soc', product_tier: 'search_ai_lake' },\n { product_line: 'security', product_tier: 'search_ai_lake' }\n]\n```\n\nThis applies to custom role creation flyout where timelines/notes\nprivileges are not available for RBAC.\n\n### Screenshots (where timeline and notes are not available)\n\n#### Custom role creation \n\n\nAlso on alerts page notes and timelines is not available action items.\nTrying to access these via URL does not show them either.\n\n#### Current alerts page (with timelines and notes not available)\n\n\n#### Alert details via URL (without notes on the expanded flyout)\n\n\n\n## How to Test\n\n1. While on the Kibana root directory, run ES/Kibana on serverless mode\nwith:\n\n```bash\nyarn es serverless --kill --projectType security --kibanaUrl=http://0.0.0.0:5601\n```\nand on a new window\n```bash\nyarn serverless-security --no-base-path\n```\n\nEnable the AI for SOC tier, by adding the following to your\n`serverless.security.dev.yaml` file:\n\n```json5\nxpack.securitySolutionServerless.productTypes:\n [\n { product_line: 'ai_soc', product_tier: 'search_ai_lake' },\n ]\n```\n\n2. Once Kibana is up and running login in with the `admin` role using\nthe role dropdown.\n3. Navigate to `app/management/roles/edit`\n4. Click on `Assign to space` button and assign a space to that role on\nthe `Assign role to spaces` flyout.\n5. Expand the `Security` privileges and verify that only 4\nsub-privileges are seen and that Timelines and Notes are not among them.\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [ ] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n### Identify risks\n\nDoes this PR introduce any risks? For example, consider risks like hard\nto test bugs, performance regression, potential of data loss.\n\nDescribe the risk, its severity, and mitigation for each identified\nrisk. Invite stakeholders and evaluate how to proceed before merging.\n\n- [ ] [See some risk\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)\n- [ ] ...","sha":"cf1cd55a490c27c556957d34ac292802f2d83875","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Defend Workflows","Team:Security Generative AI","backport:version","v9.1.0","v8.19.0"],"title":"[Ai4dSoc][Serverless] Hide notes/timelines for `search_ai_lake` tier","number":215334,"url":"https://github.com/elastic/kibana/pull/215334","mergeCommit":{"message":"[Ai4dSoc] Hide notes/timelines for `search_ai_lake` tier (#215334)\n\n> [!CAUTION]\n> Do not merge yet!\n> This PR is mergeable based on the assumption that we do not allow\ndowngrading to `search_ai_lake` tier from `essentials`/`complete` or\n`trial` `complete/essentals`.\n\n## Summary\n\nOn serverless with following sets of product types/lines timelines and\nnotes are not available to the user.\n\n```json5\n[\n { product_line: 'ai_soc', product_tier: 'search_ai_lake' }\n]\n```\nor \n```json5\n[\n { product_line: 'security', product_tier: 'search_ai_lake' }\n]\n```\nor with \n```json5\n[\n { product_line: 'ai_soc', product_tier: 'search_ai_lake' },\n { product_line: 'security', product_tier: 'search_ai_lake' }\n]\n```\n\nThis applies to custom role creation flyout where timelines/notes\nprivileges are not available for RBAC.\n\n### Screenshots (where timeline and notes are not available)\n\n#### Custom role creation \n\n\nAlso on alerts page notes and timelines is not available action items.\nTrying to access these via URL does not show them either.\n\n#### Current alerts page (with timelines and notes not available)\n\n\n#### Alert details via URL (without notes on the expanded flyout)\n\n\n\n## How to Test\n\n1. While on the Kibana root directory, run ES/Kibana on serverless mode\nwith:\n\n```bash\nyarn es serverless --kill --projectType security --kibanaUrl=http://0.0.0.0:5601\n```\nand on a new window\n```bash\nyarn serverless-security --no-base-path\n```\n\nEnable the AI for SOC tier, by adding the following to your\n`serverless.security.dev.yaml` file:\n\n```json5\nxpack.securitySolutionServerless.productTypes:\n [\n { product_line: 'ai_soc', product_tier: 'search_ai_lake' },\n ]\n```\n\n2. Once Kibana is up and running login in with the `admin` role using\nthe role dropdown.\n3. Navigate to `app/management/roles/edit`\n4. Click on `Assign to space` button and assign a space to that role on\nthe `Assign role to spaces` flyout.\n5. Expand the `Security` privileges and verify that only 4\nsub-privileges are seen and that Timelines and Notes are not among them.\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [ ] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n### Identify risks\n\nDoes this PR introduce any risks? For example, consider risks like hard\nto test bugs, performance regression, potential of data loss.\n\nDescribe the risk, its severity, and mitigation for each identified\nrisk. Invite stakeholders and evaluate how to proceed before merging.\n\n- [ ] [See some risk\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)\n- [ ] ...","sha":"cf1cd55a490c27c556957d34ac292802f2d83875"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/215334","number":215334,"mergeCommit":{"message":"[Ai4dSoc] Hide notes/timelines for `search_ai_lake` tier (#215334)\n\n> [!CAUTION]\n> Do not merge yet!\n> This PR is mergeable based on the assumption that we do not allow\ndowngrading to `search_ai_lake` tier from `essentials`/`complete` or\n`trial` `complete/essentals`.\n\n## Summary\n\nOn serverless with following sets of product types/lines timelines and\nnotes are not available to the user.\n\n```json5\n[\n { product_line: 'ai_soc', product_tier: 'search_ai_lake' }\n]\n```\nor \n```json5\n[\n { product_line: 'security', product_tier: 'search_ai_lake' }\n]\n```\nor with \n```json5\n[\n { product_line: 'ai_soc', product_tier: 'search_ai_lake' },\n { product_line: 'security', product_tier: 'search_ai_lake' }\n]\n```\n\nThis applies to custom role creation flyout where timelines/notes\nprivileges are not available for RBAC.\n\n### Screenshots (where timeline and notes are not available)\n\n#### Custom role creation \n\n\nAlso on alerts page notes and timelines is not available action items.\nTrying to access these via URL does not show them either.\n\n#### Current alerts page (with timelines and notes not available)\n\n\n#### Alert details via URL (without notes on the expanded flyout)\n\n\n\n## How to Test\n\n1. While on the Kibana root directory, run ES/Kibana on serverless mode\nwith:\n\n```bash\nyarn es serverless --kill --projectType security --kibanaUrl=http://0.0.0.0:5601\n```\nand on a new window\n```bash\nyarn serverless-security --no-base-path\n```\n\nEnable the AI for SOC tier, by adding the following to your\n`serverless.security.dev.yaml` file:\n\n```json5\nxpack.securitySolutionServerless.productTypes:\n [\n { product_line: 'ai_soc', product_tier: 'search_ai_lake' },\n ]\n```\n\n2. Once Kibana is up and running login in with the `admin` role using\nthe role dropdown.\n3. Navigate to `app/management/roles/edit`\n4. Click on `Assign to space` button and assign a space to that role on\nthe `Assign role to spaces` flyout.\n5. Expand the `Security` privileges and verify that only 4\nsub-privileges are seen and that Timelines and Notes are not among them.\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [ ] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n### Identify risks\n\nDoes this PR introduce any risks? For example, consider risks like hard\nto test bugs, performance regression, potential of data loss.\n\nDescribe the risk, its severity, and mitigation for each identified\nrisk. Invite stakeholders and evaluate how to proceed before merging.\n\n- [ ] [See some risk\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)\n- [ ] ...","sha":"cf1cd55a490c27c556957d34ac292802f2d83875"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Caution
Do not merge yet!
This PR is mergeable based on the assumption that we do not allow downgrading to
search_ai_laketier fromessentials/completeortrialcomplete/essentals.Summary
On serverless with following sets of product types/lines timelines and notes are not available to the user.
or
or with
This applies to custom role creation flyout where timelines/notes privileges are not available for RBAC.
Screenshots (where timeline and notes are not available)
Custom role creation
Also on alerts page notes and timelines is not available action items. Trying to access these via URL does not show them either.
Current alerts page (with timelines and notes not available)
Alert details via URL (without notes on the expanded flyout)
How to Test
and on a new window
Enable the AI for SOC tier, by adding the following to your
serverless.security.dev.yamlfile:adminrole using the role dropdown.app/management/roles/editAssign to spacebutton and assign a space to that role on theAssign role to spacesflyout.Securityprivileges and verify that only 4 sub-privileges are seen and that Timelines and Notes are not among them.Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesIdentify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.