[Security Solution] Update prebuilt rule customization test plans to reflect licensing changes#215008
Merged
nikitaindik merged 6 commits intoelastic:mainfrom Mar 24, 2025
Conversation
Contributor
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
Contributor
|
Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management) |
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
maximpn
requested changes
Mar 20, 2025
Contributor
maximpn
left a comment
There was a problem hiding this comment.
@nikitaindik Thanks for updating the test plan accordingly 🙏
I left a number of comments. Feel free to reach out to me if a detailed explanation is required.
...ion/docs/testing/test_plans/detection_response/prebuilt_rules/prebuilt_rule_customization.md
Outdated
Show resolved
Hide resolved
...ion/docs/testing/test_plans/detection_response/prebuilt_rules/prebuilt_rule_customization.md
Outdated
Show resolved
Hide resolved
...ion/docs/testing/test_plans/detection_response/prebuilt_rules/prebuilt_rule_customization.md
Outdated
Show resolved
Hide resolved
Comment on lines
+218
to
+219
| Then the Actions view of the rule edit page should be displayed | ||
| And user should be able to edit rule actions |
Contributor
There was a problem hiding this comment.
Rule actions aren't related to this test scenario and slightly related to prebuilt rule customization. The only test should exist to verify rule actions doesn't contribute to the rule's customization state.
Contributor
Author
There was a problem hiding this comment.
Shouldn't we still check that actions are editable in UI? Do you think it should be done in a separate test?
Contributor
There was a problem hiding this comment.
Rule actions don't contribute to a rule's customization state while test scenarios in this file should be concerned by the rule customization workflow. There is a chance rule actions behavior changes in the future so we'll have to address any modifications. It's quite straightforward to reduce maintenance burden and keep test scenarios focused by eliminating irrelevant parts.
| Then the Actions view of the rule edit page should be displayed | ||
| And user should be able to edit rule actions | ||
| When user attempts to edit fields from the About, Definition or Schedule views | ||
| Then it should not be possible |
Contributor
There was a problem hiding this comment.
What's expected? We may clearly state the tabs should be disabled.
Contributor
Author
There was a problem hiding this comment.
Updated the wording, please take a look
...ion/docs/testing/test_plans/detection_response/prebuilt_rules/prebuilt_rule_customization.md
Outdated
Show resolved
Hide resolved
...ion/docs/testing/test_plans/detection_response/prebuilt_rules/prebuilt_rule_customization.md
Outdated
Show resolved
Hide resolved
...ion/docs/testing/test_plans/detection_response/prebuilt_rules/prebuilt_rule_customization.md
Outdated
Show resolved
Hide resolved
...ion/docs/testing/test_plans/detection_response/prebuilt_rules/prebuilt_rule_customization.md
Outdated
Show resolved
Hide resolved
|
|
||
| ### Editing prebuilt rules under a restricted license | ||
|
|
||
| #### Bulk actions that are forbidden under a restricted license |
Contributor
There was a problem hiding this comment.
Decorating it as a header may be perceived as a scenario while this is a common context. Could you transform the header to plain text?
Contributor
Author
There was a problem hiding this comment.
Moved it into Terminology section. wdyt?
Contributor
Author
|
Thanks for reviewing, @maximpn! 🙏 I've updated the PR according to your suggestions and answered a couple of your comments. Please take a look! |
maximpn
reviewed
Mar 21, 2025
| #### **Scenario: User can bulk edit prebuilt rules from rules management page** | ||
|
|
||
| **Automation**: 7 cypress tests. | ||
| **Automation**: 1 Cypress test for each bulk action type. |
Contributor
There was a problem hiding this comment.
Suggested change
| **Automation**: 1 Cypress test for each bulk action type. | |
| **Automation**: a Cypress test for each bulk action type. |
…test-plan-licensing-changes
maximpn
reviewed
Mar 24, 2025
Contributor
maximpn
left a comment
There was a problem hiding this comment.
@nikitaindik Thanks for addressing my comments 🙏
Looking at #213434 I think it's better to explicitly split scenarios w/ and w/o sufficient license. Let's create a new section named Licensing and move insufficient license related tests there.
maximpn
approved these changes
Mar 24, 2025
Contributor
maximpn
left a comment
There was a problem hiding this comment.
Insufficient license related scenarios look much better now 👍
Contributor
|
Starting backport for target branches: 8.18, 8.x, 9.0 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 24, 2025
…reflect licensing changes (elastic#215008) **Partially addresses: elastic#202068 **Related PR with licensing checks implementation: elastic#206079 ## Summary This PR updates the Prebuilt Rule Customization test plan to reflect [recent changes](elastic#206079) related to licensing. Changes to rule upgrade scenarios will be handled in a separate PR. (cherry picked from commit 2929f28)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 24, 2025
…reflect licensing changes (elastic#215008) **Partially addresses: elastic#202068 **Related PR with licensing checks implementation: elastic#206079 ## Summary This PR updates the Prebuilt Rule Customization test plan to reflect [recent changes](elastic#206079) related to licensing. Changes to rule upgrade scenarios will be handled in a separate PR. (cherry picked from commit 2929f28)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 24, 2025
…reflect licensing changes (elastic#215008) **Partially addresses: elastic#202068 **Related PR with licensing checks implementation: elastic#206079 ## Summary This PR updates the Prebuilt Rule Customization test plan to reflect [recent changes](elastic#206079) related to licensing. Changes to rule upgrade scenarios will be handled in a separate PR. (cherry picked from commit 2929f28)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Mar 24, 2025
…ns to reflect licensing changes (#215008) (#215730) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] Update prebuilt rule customization test plans to reflect licensing changes (#215008)](#215008) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Nikita Indik","email":"nikita.indik@elastic.co"},"sourceCommit":{"committedDate":"2025-03-24T14:50:34Z","message":"[Security Solution] Update prebuilt rule customization test plans to reflect licensing changes (#215008)\n\n**Partially addresses: https://github.com/elastic/kibana/issues/202068**\n**Related PR with licensing checks implementation:\nhttps://github.com//pull/206079**\n\n## Summary\nThis PR updates the Prebuilt Rule Customization test plan to reflect\n[recent changes](#206079) related\nto licensing.\n\nChanges to rule upgrade scenarios will be handled in a separate PR.","sha":"2929f2857d585a6c1c60e09fc3616083527af410","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","test-plan","v9.0.0","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Security Solution] Update prebuilt rule customization test plans to reflect licensing changes","number":215008,"url":"https://github.com/elastic/kibana/pull/215008","mergeCommit":{"message":"[Security Solution] Update prebuilt rule customization test plans to reflect licensing changes (#215008)\n\n**Partially addresses: https://github.com/elastic/kibana/issues/202068**\n**Related PR with licensing checks implementation:\nhttps://github.com//pull/206079**\n\n## Summary\nThis PR updates the Prebuilt Rule Customization test plan to reflect\n[recent changes](#206079) related\nto licensing.\n\nChanges to rule upgrade scenarios will be handled in a separate PR.","sha":"2929f2857d585a6c1c60e09fc3616083527af410"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/215008","number":215008,"mergeCommit":{"message":"[Security Solution] Update prebuilt rule customization test plans to reflect licensing changes (#215008)\n\n**Partially addresses: https://github.com/elastic/kibana/issues/202068**\n**Related PR with licensing checks implementation:\nhttps://github.com//pull/206079**\n\n## Summary\nThis PR updates the Prebuilt Rule Customization test plan to reflect\n[recent changes](#206079) related\nto licensing.\n\nChanges to rule upgrade scenarios will be handled in a separate PR.","sha":"2929f2857d585a6c1c60e09fc3616083527af410"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Nikita Indik <nikita.indik@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Mar 24, 2025
…ans to reflect licensing changes (#215008) (#215727) # Backport This will backport the following commits from `main` to `8.18`: - [[Security Solution] Update prebuilt rule customization test plans to reflect licensing changes (#215008)](#215008) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Nikita Indik","email":"nikita.indik@elastic.co"},"sourceCommit":{"committedDate":"2025-03-24T14:50:34Z","message":"[Security Solution] Update prebuilt rule customization test plans to reflect licensing changes (#215008)\n\n**Partially addresses: https://github.com/elastic/kibana/issues/202068**\n**Related PR with licensing checks implementation:\nhttps://github.com//pull/206079**\n\n## Summary\nThis PR updates the Prebuilt Rule Customization test plan to reflect\n[recent changes](#206079) related\nto licensing.\n\nChanges to rule upgrade scenarios will be handled in a separate PR.","sha":"2929f2857d585a6c1c60e09fc3616083527af410","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","test-plan","v9.0.0","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Security Solution] Update prebuilt rule customization test plans to reflect licensing changes","number":215008,"url":"https://github.com/elastic/kibana/pull/215008","mergeCommit":{"message":"[Security Solution] Update prebuilt rule customization test plans to reflect licensing changes (#215008)\n\n**Partially addresses: https://github.com/elastic/kibana/issues/202068**\n**Related PR with licensing checks implementation:\nhttps://github.com//pull/206079**\n\n## Summary\nThis PR updates the Prebuilt Rule Customization test plan to reflect\n[recent changes](#206079) related\nto licensing.\n\nChanges to rule upgrade scenarios will be handled in a separate PR.","sha":"2929f2857d585a6c1c60e09fc3616083527af410"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/215008","number":215008,"mergeCommit":{"message":"[Security Solution] Update prebuilt rule customization test plans to reflect licensing changes (#215008)\n\n**Partially addresses: https://github.com/elastic/kibana/issues/202068**\n**Related PR with licensing checks implementation:\nhttps://github.com//pull/206079**\n\n## Summary\nThis PR updates the Prebuilt Rule Customization test plan to reflect\n[recent changes](#206079) related\nto licensing.\n\nChanges to rule upgrade scenarios will be handled in a separate PR.","sha":"2929f2857d585a6c1c60e09fc3616083527af410"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Nikita Indik <nikita.indik@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Mar 24, 2025
…ns to reflect licensing changes (#215008) (#215731) # Backport This will backport the following commits from `main` to `9.0`: - [[Security Solution] Update prebuilt rule customization test plans to reflect licensing changes (#215008)](#215008) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Nikita Indik","email":"nikita.indik@elastic.co"},"sourceCommit":{"committedDate":"2025-03-24T14:50:34Z","message":"[Security Solution] Update prebuilt rule customization test plans to reflect licensing changes (#215008)\n\n**Partially addresses: https://github.com/elastic/kibana/issues/202068**\n**Related PR with licensing checks implementation:\nhttps://github.com//pull/206079**\n\n## Summary\nThis PR updates the Prebuilt Rule Customization test plan to reflect\n[recent changes](#206079) related\nto licensing.\n\nChanges to rule upgrade scenarios will be handled in a separate PR.","sha":"2929f2857d585a6c1c60e09fc3616083527af410","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","test-plan","v9.0.0","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Security Solution] Update prebuilt rule customization test plans to reflect licensing changes","number":215008,"url":"https://github.com/elastic/kibana/pull/215008","mergeCommit":{"message":"[Security Solution] Update prebuilt rule customization test plans to reflect licensing changes (#215008)\n\n**Partially addresses: https://github.com/elastic/kibana/issues/202068**\n**Related PR with licensing checks implementation:\nhttps://github.com//pull/206079**\n\n## Summary\nThis PR updates the Prebuilt Rule Customization test plan to reflect\n[recent changes](#206079) related\nto licensing.\n\nChanges to rule upgrade scenarios will be handled in a separate PR.","sha":"2929f2857d585a6c1c60e09fc3616083527af410"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/215008","number":215008,"mergeCommit":{"message":"[Security Solution] Update prebuilt rule customization test plans to reflect licensing changes (#215008)\n\n**Partially addresses: https://github.com/elastic/kibana/issues/202068**\n**Related PR with licensing checks implementation:\nhttps://github.com//pull/206079**\n\n## Summary\nThis PR updates the Prebuilt Rule Customization test plan to reflect\n[recent changes](#206079) related\nto licensing.\n\nChanges to rule upgrade scenarios will be handled in a separate PR.","sha":"2929f2857d585a6c1c60e09fc3616083527af410"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Nikita Indik <nikita.indik@elastic.co>
JoseLuisGJ
pushed a commit
to JoseLuisGJ/kibana
that referenced
this pull request
Mar 24, 2025
…reflect licensing changes (elastic#215008) **Partially addresses: elastic#202068 **Related PR with licensing checks implementation: elastic#206079 ## Summary This PR updates the Prebuilt Rule Customization test plan to reflect [recent changes](elastic#206079) related to licensing. Changes to rule upgrade scenarios will be handled in a separate PR.
21 tasks
cqliu1
pushed a commit
to cqliu1/kibana
that referenced
this pull request
Mar 31, 2025
…reflect licensing changes (elastic#215008) **Partially addresses: elastic#202068 **Related PR with licensing checks implementation: elastic#206079 ## Summary This PR updates the Prebuilt Rule Customization test plan to reflect [recent changes](elastic#206079) related to licensing. Changes to rule upgrade scenarios will be handled in a separate PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses: #202068
Related PR with licensing checks implementation: #206079
Summary
This PR updates the Prebuilt Rule Customization test plan to reflect recent changes related to licensing.
Changes to rule upgrade scenarios will be handled in a separate PR.