[Cloud Security] Fix installing agent-based CSP integrations not displaying Add Agent flyout#212702
Merged
seanrathier merged 2 commits intoelastic:mainfrom Feb 28, 2025
Conversation
Contributor
|
Pinging @elastic/fleet (Team:Fleet) |
Contributor
|
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
History
cc @seanrathier |
Contributor
|
Starting backport for target branches: 9.0 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 28, 2025
…laying Add Agent flyout (elastic#212702) (cherry picked from commit 42e0941)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
seanrathier
added a commit
to seanrathier/kibana
that referenced
this pull request
Feb 28, 2025
…laying Add Agent flyout (elastic#212702) (cherry picked from commit 42e0941)
seanrathier
added a commit
to seanrathier/kibana
that referenced
this pull request
Feb 28, 2025
…laying Add Agent flyout (elastic#212702) (cherry picked from commit 42e0941)
kibanamachine
added a commit
that referenced
this pull request
Mar 1, 2025
…t displaying Add Agent flyout (#212702) (#212812) # Backport This will backport the following commits from `main` to `9.0`: - [[Cloud Security] Fix installing agent-based CSP integrations not displaying Add Agent flyout (#212702)](#212702) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"seanrathier","email":"sean.rathier@gmail.com"},"sourceCommit":{"committedDate":"2025-02-28T20:55:09Z","message":"[Cloud Security] Fix installing agent-based CSP integrations not displaying Add Agent flyout (#212702)","sha":"42e094189cc70df68f03c6f3fb4dea887c6a2dfd","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","Team:Cloud Security","backport:prev-minor","v9.1.0"],"title":"[Cloud Security] Fix installing agent-based CSP integrations not displaying Add Agent flyout","number":212702,"url":"https://github.com/elastic/kibana/pull/212702","mergeCommit":{"message":"[Cloud Security] Fix installing agent-based CSP integrations not displaying Add Agent flyout (#212702)","sha":"42e094189cc70df68f03c6f3fb4dea887c6a2dfd"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/212702","number":212702,"mergeCommit":{"message":"[Cloud Security] Fix installing agent-based CSP integrations not displaying Add Agent flyout (#212702)","sha":"42e094189cc70df68f03c6f3fb4dea887c6a2dfd"}}]}] BACKPORT--> Co-authored-by: seanrathier <sean.rathier@gmail.com>
seanrathier
added a commit
that referenced
this pull request
Mar 3, 2025
…t displaying Add Agent flyout (#212702) (#212819) # Backport This will backport the following commits from `main` to `8.x`: - [[Cloud Security] Fix installing agent-based CSP integrations not displaying Add Agent flyout (#212702)](#212702) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"seanrathier","email":"sean.rathier@gmail.com"},"sourceCommit":{"committedDate":"2025-02-28T20:55:09Z","message":"[Cloud Security] Fix installing agent-based CSP integrations not displaying Add Agent flyout (#212702)","sha":"42e094189cc70df68f03c6f3fb4dea887c6a2dfd","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","Team:Cloud Security","backport:prev-minor","v9.1.0"],"title":"[Cloud Security] Fix installing agent-based CSP integrations not displaying Add Agent flyout","number":212702,"url":"https://github.com/elastic/kibana/pull/212702","mergeCommit":{"message":"[Cloud Security] Fix installing agent-based CSP integrations not displaying Add Agent flyout (#212702)","sha":"42e094189cc70df68f03c6f3fb4dea887c6a2dfd"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/212702","number":212702,"mergeCommit":{"message":"[Cloud Security] Fix installing agent-based CSP integrations not displaying Add Agent flyout (#212702)","sha":"42e094189cc70df68f03c6f3fb4dea887c6a2dfd"}},{"url":"https://github.com/elastic/kibana/pull/212812","number":212812,"branch":"9.0","state":"OPEN"}]}] BACKPORT-->
seanrathier
added a commit
that referenced
this pull request
Mar 3, 2025
…ot displaying Add Agent flyout (#212702) (#212820) # Backport This will backport the following commits from `main` to `8.18`: - [[Cloud Security] Fix installing agent-based CSP integrations not displaying Add Agent flyout (#212702)](#212702) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"seanrathier","email":"sean.rathier@gmail.com"},"sourceCommit":{"committedDate":"2025-02-28T20:55:09Z","message":"[Cloud Security] Fix installing agent-based CSP integrations not displaying Add Agent flyout (#212702)","sha":"42e094189cc70df68f03c6f3fb4dea887c6a2dfd","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","Team:Cloud Security","backport:prev-minor","v9.1.0"],"title":"[Cloud Security] Fix installing agent-based CSP integrations not displaying Add Agent flyout","number":212702,"url":"https://github.com/elastic/kibana/pull/212702","mergeCommit":{"message":"[Cloud Security] Fix installing agent-based CSP integrations not displaying Add Agent flyout (#212702)","sha":"42e094189cc70df68f03c6f3fb4dea887c6a2dfd"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/212702","number":212702,"mergeCommit":{"message":"[Cloud Security] Fix installing agent-based CSP integrations not displaying Add Agent flyout (#212702)","sha":"42e094189cc70df68f03c6f3fb4dea887c6a2dfd"}},{"url":"https://github.com/elastic/kibana/pull/212812","number":212812,"branch":"9.0","state":"OPEN"}]}] BACKPORT-->
SoniaSanzV
pushed a commit
to SoniaSanzV/kibana
that referenced
this pull request
Mar 4, 2025
…t displaying Add Agent flyout (elastic#212702) (elastic#212819) # Backport This will backport the following commits from `main` to `8.x`: - [[Cloud Security] Fix installing agent-based CSP integrations not displaying Add Agent flyout (elastic#212702)](elastic#212702) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"seanrathier","email":"sean.rathier@gmail.com"},"sourceCommit":{"committedDate":"2025-02-28T20:55:09Z","message":"[Cloud Security] Fix installing agent-based CSP integrations not displaying Add Agent flyout (elastic#212702)","sha":"42e094189cc70df68f03c6f3fb4dea887c6a2dfd","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","Team:Cloud Security","backport:prev-minor","v9.1.0"],"title":"[Cloud Security] Fix installing agent-based CSP integrations not displaying Add Agent flyout","number":212702,"url":"https://github.com/elastic/kibana/pull/212702","mergeCommit":{"message":"[Cloud Security] Fix installing agent-based CSP integrations not displaying Add Agent flyout (elastic#212702)","sha":"42e094189cc70df68f03c6f3fb4dea887c6a2dfd"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/212702","number":212702,"mergeCommit":{"message":"[Cloud Security] Fix installing agent-based CSP integrations not displaying Add Agent flyout (elastic#212702)","sha":"42e094189cc70df68f03c6f3fb4dea887c6a2dfd"}},{"url":"https://github.com/elastic/kibana/pull/212812","number":212812,"branch":"9.0","state":"OPEN"}]}] BACKPORT-->
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Mar 22, 2025
…laying Add Agent flyout (elastic#212702)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the onSaveNavigate route when creating an agentless-enabled integration. Since an integration can support both agentless and agent-based deployments, we need to dynamically determine the navigation destination after saving the integration.
We need a way to force the onSaveNavigate function not to use routeState.onSaveNavigateTo if the integration is agentless. Therefore, not setting the routeState.onSaveNavigateTo state seems like the most likely solution.
Screen.Recording.2025-02-27.at.5.08.03.PM.mov
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.