Skip to content

[Obs AI Assistant] Enable syntax highlighting for ES|QL#212669

Merged
viduni94 merged 1 commit intoelastic:mainfrom
viduni94:syntax-highlighting-for-esql
Feb 28, 2025
Merged

[Obs AI Assistant] Enable syntax highlighting for ES|QL#212669
viduni94 merged 1 commit intoelastic:mainfrom
viduni94:syntax-highlighting-for-esql

Conversation

@viduni94
Copy link
Copy Markdown
Contributor

@viduni94 viduni94 commented Feb 27, 2025

Closes #212384

Summary

With elastic/eui#8317, EuiCodeBlock supports syntax highlighting for ES|QL.
This PR enables it for Obs AI Assistant

Screenshots

Before:
Screenshot 2025-02-27 at 11 00 39 AM

After:
image

Checklist

  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

@viduni94 viduni94 added release_note:enhancement Team:Obs AI Assistant Observability AI Assistant backport:version Backport to applied version labels v9.1.0 v8.19.0 labels Feb 27, 2025
@viduni94 viduni94 self-assigned this Feb 27, 2025
@viduni94 viduni94 requested a review from a team as a code owner February 27, 2025 16:04
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant)

@viduni94 viduni94 force-pushed the syntax-highlighting-for-esql branch from c0a128c to 550674a Compare February 27, 2025 16:35
@viduni94 viduni94 merged commit 6d862d7 into elastic:main Feb 28, 2025
9 checks passed
@kibanamachine
Copy link
Copy Markdown
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/13588602077

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 28, 2025
Closes elastic#212384

## Summary

With elastic/eui#8317, `EuiCodeBlock` supports
syntax highlighting for ES|QL.
This PR enables it for Obs AI Assistant

### Screenshots

Before:
![Screenshot 2025-02-27 at 11 00
39 AM](https://github.com/user-attachments/assets/ec9c6da9-c945-4a6b-b3aa-ece17533e877)

After:

![image](https://github.com/user-attachments/assets/7ed5232f-9b4c-45a3-a55f-22c2b6f56a98)

### Checklist

- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

(cherry picked from commit 6d862d7)
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 28, 2025
… (#212765)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Obs AI Assistant] Enable syntax highlighting for ES|QL
(#212669)](#212669)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Viduni
Wickramarachchi","email":"viduni.wickramarachchi@elastic.co"},"sourceCommit":{"committedDate":"2025-02-28T12:56:18Z","message":"[Obs
AI Assistant] Enable syntax highlighting for ES|QL (#212669)\n\nCloses
https://github.com/elastic/kibana/issues/212384\n\n## Summary\n\nWith
elastic/eui#8317, `EuiCodeBlock`
supports\nsyntax highlighting for ES|QL.\nThis PR enables it for Obs AI
Assistant\n\n### Screenshots\n\nBefore:\n![Screenshot 2025-02-27 at 11
00\n39 AM](https://github.com/user-attachments/assets/ec9c6da9-c945-4a6b-b3aa-ece17533e877)\n\nAfter:\n\n![image](https://github.com/user-attachments/assets/7ed5232f-9b4c-45a3-a55f-22c2b6f56a98)\n\n###
Checklist\n\n- [x] The PR description includes the appropriate Release
Notes section,\nand the correct `release_note:*` label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"6d862d72a2358438c5e1295ca004f59cc7115170","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","Team:Obs
AI Assistant","backport:version","v9.1.0","v8.19.0"],"title":"[Obs AI
Assistant] Enable syntax highlighting for
ES|QL","number":212669,"url":"https://github.com/elastic/kibana/pull/212669","mergeCommit":{"message":"[Obs
AI Assistant] Enable syntax highlighting for ES|QL (#212669)\n\nCloses
https://github.com/elastic/kibana/issues/212384\n\n## Summary\n\nWith
elastic/eui#8317, `EuiCodeBlock`
supports\nsyntax highlighting for ES|QL.\nThis PR enables it for Obs AI
Assistant\n\n### Screenshots\n\nBefore:\n![Screenshot 2025-02-27 at 11
00\n39 AM](https://github.com/user-attachments/assets/ec9c6da9-c945-4a6b-b3aa-ece17533e877)\n\nAfter:\n\n![image](https://github.com/user-attachments/assets/7ed5232f-9b4c-45a3-a55f-22c2b6f56a98)\n\n###
Checklist\n\n- [x] The PR description includes the appropriate Release
Notes section,\nand the correct `release_note:*` label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"6d862d72a2358438c5e1295ca004f59cc7115170"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/212669","number":212669,"mergeCommit":{"message":"[Obs
AI Assistant] Enable syntax highlighting for ES|QL (#212669)\n\nCloses
https://github.com/elastic/kibana/issues/212384\n\n## Summary\n\nWith
elastic/eui#8317, `EuiCodeBlock`
supports\nsyntax highlighting for ES|QL.\nThis PR enables it for Obs AI
Assistant\n\n### Screenshots\n\nBefore:\n![Screenshot 2025-02-27 at 11
00\n39 AM](https://github.com/user-attachments/assets/ec9c6da9-c945-4a6b-b3aa-ece17533e877)\n\nAfter:\n\n![image](https://github.com/user-attachments/assets/7ed5232f-9b4c-45a3-a55f-22c2b6f56a98)\n\n###
Checklist\n\n- [x] The PR description includes the appropriate Release
Notes section,\nand the correct `release_note:*` label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"6d862d72a2358438c5e1295ca004f59cc7115170"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Viduni Wickramarachchi <viduni.wickramarachchi@elastic.co>
SoniaSanzV pushed a commit to SoniaSanzV/kibana that referenced this pull request Mar 4, 2025
…c#212669) (elastic#212765)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Obs AI Assistant] Enable syntax highlighting for ES|QL
(elastic#212669)](elastic#212669)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Viduni
Wickramarachchi","email":"viduni.wickramarachchi@elastic.co"},"sourceCommit":{"committedDate":"2025-02-28T12:56:18Z","message":"[Obs
AI Assistant] Enable syntax highlighting for ES|QL (elastic#212669)\n\nCloses
https://github.com/elastic/kibana/issues/212384\n\n## Summary\n\nWith
elastic/eui#8317, `EuiCodeBlock`
supports\nsyntax highlighting for ES|QL.\nThis PR enables it for Obs AI
Assistant\n\n### Screenshots\n\nBefore:\n![Screenshot 2025-02-27 at 11
00\n39 AM](https://github.com/user-attachments/assets/ec9c6da9-c945-4a6b-b3aa-ece17533e877)\n\nAfter:\n\n![image](https://github.com/user-attachments/assets/7ed5232f-9b4c-45a3-a55f-22c2b6f56a98)\n\n###
Checklist\n\n- [x] The PR description includes the appropriate Release
Notes section,\nand the correct `release_note:*` label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"6d862d72a2358438c5e1295ca004f59cc7115170","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","Team:Obs
AI Assistant","backport:version","v9.1.0","v8.19.0"],"title":"[Obs AI
Assistant] Enable syntax highlighting for
ES|QL","number":212669,"url":"https://github.com/elastic/kibana/pull/212669","mergeCommit":{"message":"[Obs
AI Assistant] Enable syntax highlighting for ES|QL (elastic#212669)\n\nCloses
https://github.com/elastic/kibana/issues/212384\n\n## Summary\n\nWith
elastic/eui#8317, `EuiCodeBlock`
supports\nsyntax highlighting for ES|QL.\nThis PR enables it for Obs AI
Assistant\n\n### Screenshots\n\nBefore:\n![Screenshot 2025-02-27 at 11
00\n39 AM](https://github.com/user-attachments/assets/ec9c6da9-c945-4a6b-b3aa-ece17533e877)\n\nAfter:\n\n![image](https://github.com/user-attachments/assets/7ed5232f-9b4c-45a3-a55f-22c2b6f56a98)\n\n###
Checklist\n\n- [x] The PR description includes the appropriate Release
Notes section,\nand the correct `release_note:*` label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"6d862d72a2358438c5e1295ca004f59cc7115170"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/212669","number":212669,"mergeCommit":{"message":"[Obs
AI Assistant] Enable syntax highlighting for ES|QL (elastic#212669)\n\nCloses
https://github.com/elastic/kibana/issues/212384\n\n## Summary\n\nWith
elastic/eui#8317, `EuiCodeBlock`
supports\nsyntax highlighting for ES|QL.\nThis PR enables it for Obs AI
Assistant\n\n### Screenshots\n\nBefore:\n![Screenshot 2025-02-27 at 11
00\n39 AM](https://github.com/user-attachments/assets/ec9c6da9-c945-4a6b-b3aa-ece17533e877)\n\nAfter:\n\n![image](https://github.com/user-attachments/assets/7ed5232f-9b4c-45a3-a55f-22c2b6f56a98)\n\n###
Checklist\n\n- [x] The PR description includes the appropriate Release
Notes section,\nand the correct `release_note:*` label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"6d862d72a2358438c5e1295ca004f59cc7115170"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Viduni Wickramarachchi <viduni.wickramarachchi@elastic.co>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Mar 22, 2025
Closes elastic#212384

## Summary

With elastic/eui#8317, `EuiCodeBlock` supports
syntax highlighting for ES|QL.
This PR enables it for Obs AI Assistant

### Screenshots

Before:
![Screenshot 2025-02-27 at 11 00
39 AM](https://github.com/user-attachments/assets/ec9c6da9-c945-4a6b-b3aa-ece17533e877)

After:

![image](https://github.com/user-attachments/assets/7ed5232f-9b4c-45a3-a55f-22c2b6f56a98)

### Checklist

- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels release_note:enhancement Team:Obs AI Assistant Observability AI Assistant v8.19.0 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Obs AI Assistant] Enable highlighting for ES|QL language syntax

4 participants