[8.x] [kbn-grid-layout] Fix mobile styles (#212312)#212410
Merged
kibanamachine merged 1 commit intoelastic:8.xfrom Feb 25, 2025
Merged
[8.x] [kbn-grid-layout] Fix mobile styles (#212312)#212410kibanamachine merged 1 commit intoelastic:8.xfrom
kibanamachine merged 1 commit intoelastic:8.xfrom
Conversation
## Summary This PR fixes a broken style introduced in elastic#210285 where, when rewriting the single column styles from strings to objects, I accidentally set the property `gridTemplateAreas` instead of `gridTemplateColumns` - this resulted in the single column / mobile view being broken: | Before | After | |--------|--------| |  |  | ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit 464a471)
1 task
SoniaSanzV
pushed a commit
to SoniaSanzV/kibana
that referenced
this pull request
Mar 4, 2025
…12410) # Backport This will backport the following commits from `main` to `8.x`: - [[kbn-grid-layout] Fix mobile styles (elastic#212312)](elastic#212312) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Hannah Mudge","email":"Heenawter@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-02-25T16:26:26Z","message":"[kbn-grid-layout] Fix mobile styles (elastic#212312)\n\n## Summary\n\nThis PR fixes a broken style introduced in\nhttps://github.com/elastic/pull/210285 where, when rewriting the\nsingle column styles from strings to objects, I accidentally set the\nproperty `gridTemplateAreas` instead of `gridTemplateColumns` - this\nresulted in the single column / mobile view being broken:\n\n| Before | After |\n|--------|--------|\n|\n\n|\n\n|\n\n\n### Checklist\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"464a4714468fa70552e4b110af5fdb17a3e44161","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","Feature:Dashboard","Team:Presentation","loe:small","release_note:skip","impact:critical","backport:version","v9.1.0","v8.19.0"],"title":"[kbn-grid-layout] Fix mobile styles","number":212312,"url":"https://github.com/elastic/kibana/pull/212312","mergeCommit":{"message":"[kbn-grid-layout] Fix mobile styles (elastic#212312)\n\n## Summary\n\nThis PR fixes a broken style introduced in\nhttps://github.com/elastic/pull/210285 where, when rewriting the\nsingle column styles from strings to objects, I accidentally set the\nproperty `gridTemplateAreas` instead of `gridTemplateColumns` - this\nresulted in the single column / mobile view being broken:\n\n| Before | After |\n|--------|--------|\n|\n\n|\n\n|\n\n\n### Checklist\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"464a4714468fa70552e4b110af5fdb17a3e44161"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/212312","number":212312,"mergeCommit":{"message":"[kbn-grid-layout] Fix mobile styles (elastic#212312)\n\n## Summary\n\nThis PR fixes a broken style introduced in\nhttps://github.com/elastic/pull/210285 where, when rewriting the\nsingle column styles from strings to objects, I accidentally set the\nproperty `gridTemplateAreas` instead of `gridTemplateColumns` - this\nresulted in the single column / mobile view being broken:\n\n| Before | After |\n|--------|--------|\n|\n\n|\n\n|\n\n\n### Checklist\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"464a4714468fa70552e4b110af5fdb17a3e44161"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Hannah Mudge <Heenawter@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation