[8.x] [Lens][Embeddable] Make UI react faster to click actions like create or edit (#210810)#212052
Merged
dej611 merged 1 commit intoelastic:8.xfrom Mar 3, 2025
Merged
Conversation
Fixes elastic#198754 Restore previous removed tests when performing the refactor. The new tests take advantage of the new architecture to be more modular and close to the logic modules. The `data_loader` tests are not just covering the re-render logic but also some `expression_params` logic, who in the past have proven to be the source of some bugs: specifically the tests will check that the params are correctly passed to the params logic and then stored correctly in the observable. New mocks take advantage of the plain initializers to build some of the API, that will make it in sync with the actual implementation for future maintenance. Check the PR satisfies following conditions. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Marta Bondyra <4283304+mbondyra@users.noreply.github.com> (cherry picked from commit 41950c2)
1 task
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
|
markov00
approved these changes
Mar 3, 2025
SoniaSanzV
pushed a commit
to SoniaSanzV/kibana
that referenced
this pull request
Mar 4, 2025
…reate or edit (elastic#210810) (elastic#212052) # Backport This will backport the following commits from `main` to `8.x`: - [[Lens][Embeddable] Make UI react faster to click actions like create or edit (elastic#210810)](elastic#210810) <!--- Backport version: 9.6.4 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Marco Liberati","email":"dej611@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-02-20T17:19:46Z","message":"[Lens][Embeddable] Make UI react faster to click actions like create or edit (elastic#210810)\n\n## Summary\n\nThis PR is based on the idea in elastic#209361 and tries to improve perceived\nperformances for all the scenarios where the `editorFrame` is loaded.\n\nOn fast connections this is now perceived very fast:\n\n\n\nOn Fast 4g is still fast\n\n\n\nOn Slow 4g is acceptable\n\n\n\n\nEven on 3G connection the feedback is much better now\n\n\n\n\nAs a bonus extra tests have been added for the ES|QL creation flow.\n\ncc @thomasneirynck @nreese \n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n\n---------\n\nCo-authored-by: Nick Partridge <nick.ryan.partridge@gmail.com>","sha":"1e92ae8afbec96f437040a7d3147b20e52478833","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","Team:Visualizations","release_note:skip","Feature:Lens","backport:version","v9.1.0","v8.19.0"],"title":"[Lens][Embeddable] Make UI react faster to click actions like create or edit","number":210810,"url":"https://github.com/elastic/kibana/pull/210810","mergeCommit":{"message":"[Lens][Embeddable] Make UI react faster to click actions like create or edit (elastic#210810)\n\n## Summary\n\nThis PR is based on the idea in elastic#209361 and tries to improve perceived\nperformances for all the scenarios where the `editorFrame` is loaded.\n\nOn fast connections this is now perceived very fast:\n\n\n\nOn Fast 4g is still fast\n\n\n\nOn Slow 4g is acceptable\n\n\n\n\nEven on 3G connection the feedback is much better now\n\n\n\n\nAs a bonus extra tests have been added for the ES|QL creation flow.\n\ncc @thomasneirynck @nreese \n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n\n---------\n\nCo-authored-by: Nick Partridge <nick.ryan.partridge@gmail.com>","sha":"1e92ae8afbec96f437040a7d3147b20e52478833"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/210810","number":210810,"mergeCommit":{"message":"[Lens][Embeddable] Make UI react faster to click actions like create or edit (elastic#210810)\n\n## Summary\n\nThis PR is based on the idea in elastic#209361 and tries to improve perceived\nperformances for all the scenarios where the `editorFrame` is loaded.\n\nOn fast connections this is now perceived very fast:\n\n\n\nOn Fast 4g is still fast\n\n\n\nOn Slow 4g is acceptable\n\n\n\n\nEven on 3G connection the feedback is much better now\n\n\n\n\nAs a bonus extra tests have been added for the ES|QL creation flow.\n\ncc @thomasneirynck @nreese \n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n\n---------\n\nCo-authored-by: Nick Partridge <nick.ryan.partridge@gmail.com>","sha":"1e92ae8afbec96f437040a7d3147b20e52478833"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation