Skip to content

[SecuritySolution] Numbers of Network KPI metric are cropped#211460

Merged
agusruidiazgd merged 8 commits intoelastic:mainfrom
agusruidiazgd:fix/network-cropped-metrics-issue-210806
Feb 24, 2025
Merged

[SecuritySolution] Numbers of Network KPI metric are cropped#211460
agusruidiazgd merged 8 commits intoelastic:mainfrom
agusruidiazgd:fix/network-cropped-metrics-issue-210806

Conversation

@agusruidiazgd
Copy link
Copy Markdown
Contributor

@agusruidiazgd agusruidiazgd commented Feb 17, 2025

Summary

Fix issue #210806

Network Page

Before After
Network Before Network After

Host Page

Before After
Host Before Host After

Users Page

Before After
Users Before Users After

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

@agusruidiazgd agusruidiazgd self-assigned this Feb 17, 2025
@agusruidiazgd agusruidiazgd added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes v9.0.0 Team:Threat Hunting:Explore v8.18.0 v9.1.0 v8.19.0 labels Feb 17, 2025
@agusruidiazgd agusruidiazgd marked this pull request as ready for review February 17, 2025 15:07
@agusruidiazgd agusruidiazgd requested a review from a team as a code owner February 17, 2025 15:08
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/security-threat-hunting-explore (Team:Threat Hunting:Explore)

@agusruidiazgd
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

elasticmachine and others added 3 commits February 17, 2025 16:28
…o center

- Change `autoScaleMetricAlignment` from "left" to "center" in various network KPI files
- Simplify `MetricEmbeddableComponent` and remove unneeded styles
- Remove `MetricItem` styled component and associated CSS
@agusruidiazgd
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 8.9MB 8.9MB -148.0B

History

cc @agusruidiazgd

@agusruidiazgd agusruidiazgd merged commit fd18951 into elastic:main Feb 24, 2025
@kibanamachine
Copy link
Copy Markdown
Contributor

Starting backport for target branches: 8.18, 8.x, 9.0

https://github.com/elastic/kibana/actions/runs/13500153477

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 24, 2025
…#211460)

## Summary

Fix issue elastic#210806

### Network Page
| Before | After |
|--------|-------|
| ![Network
Before](https://github.com/user-attachments/assets/0b3277f7-dbe2-41a4-ac76-05a806bb42e8)
| ![Network
After](https://github.com/user-attachments/assets/12b16e81-d13b-495f-9d46-a4154aa8e0cf)
|

### Host Page
| Before | After |
|--------|-------|
| ![Host
Before](https://github.com/user-attachments/assets/1338b0e5-f4b1-4d1a-ad54-da392f0eff07)
| ![Host
After](https://github.com/user-attachments/assets/48af01d9-a4aa-450d-ac81-e2b4a724363f)
|

### Users Page
| Before | After |
|--------|-------|
| ![Users
Before](https://github.com/user-attachments/assets/d7acdf4d-9a4f-4b67-923c-a184e13b367f)
| ![Users
After](https://github.com/user-attachments/assets/43bf36bd-1e3b-47d7-b121-0d4142b18cbe)
|

### Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Karen Grigoryan <karen.grigoryan@elastic.co>
(cherry picked from commit fd18951)
@kibanamachine
Copy link
Copy Markdown
Contributor

💔 Some backports could not be created

Status Branch Result
8.18 Backport failed because of merge conflicts
8.x
9.0 Backport failed because of merge conflicts

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 211460

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 24, 2025
…211460) (#212249)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[SecuritySolution] Numbers of Network KPI metric are cropped
(#211460)](#211460)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Agustina Nahir
Ruidiaz","email":"61565784+agusruidiazgd@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-02-24T14:18:12Z","message":"[SecuritySolution]
Numbers of Network KPI metric are cropped (#211460)\n\n## Summary\n\nFix
issue https://github.com/elastic/kibana/issues/210806\n\n\n### Network
Page\n| Before | After |\n|--------|-------|\n|
![Network\nBefore](https://github.com/user-attachments/assets/0b3277f7-dbe2-41a4-ac76-05a806bb42e8)\n|
![Network\nAfter](https://github.com/user-attachments/assets/12b16e81-d13b-495f-9d46-a4154aa8e0cf)\n|\n\n###
Host Page\n| Before | After |\n|--------|-------|\n|
![Host\nBefore](https://github.com/user-attachments/assets/1338b0e5-f4b1-4d1a-ad54-da392f0eff07)\n|
![Host\nAfter](https://github.com/user-attachments/assets/48af01d9-a4aa-450d-ac81-e2b4a724363f)\n|\n\n###
Users Page\n| Before | After |\n|--------|-------|\n|
![Users\nBefore](https://github.com/user-attachments/assets/d7acdf4d-9a4f-4b67-923c-a184e13b367f)\n|
![Users\nAfter](https://github.com/user-attachments/assets/43bf36bd-1e3b-47d7-b121-0d4142b18cbe)\n|\n\n\n###
Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers
should verify this PR satisfies this list as well.\n\n- [x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios\n\n---------\n\nCo-authored-by: Elastic Machine
<elasticmachine@users.noreply.github.com>\nCo-authored-by: Karen
Grigoryan
<karen.grigoryan@elastic.co>","sha":"fd18951f8faa0a08af3d241c8bdf3f916d55cd68","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","v9.0.0","Team:Threat
Hunting:Explore","backport:prev-minor","v8.18.0","v9.1.0","v8.19.0"],"title":"[SecuritySolution]
Numbers of Network KPI metric are
cropped","number":211460,"url":"https://github.com/elastic/kibana/pull/211460","mergeCommit":{"message":"[SecuritySolution]
Numbers of Network KPI metric are cropped (#211460)\n\n## Summary\n\nFix
issue https://github.com/elastic/kibana/issues/210806\n\n\n### Network
Page\n| Before | After |\n|--------|-------|\n|
![Network\nBefore](https://github.com/user-attachments/assets/0b3277f7-dbe2-41a4-ac76-05a806bb42e8)\n|
![Network\nAfter](https://github.com/user-attachments/assets/12b16e81-d13b-495f-9d46-a4154aa8e0cf)\n|\n\n###
Host Page\n| Before | After |\n|--------|-------|\n|
![Host\nBefore](https://github.com/user-attachments/assets/1338b0e5-f4b1-4d1a-ad54-da392f0eff07)\n|
![Host\nAfter](https://github.com/user-attachments/assets/48af01d9-a4aa-450d-ac81-e2b4a724363f)\n|\n\n###
Users Page\n| Before | After |\n|--------|-------|\n|
![Users\nBefore](https://github.com/user-attachments/assets/d7acdf4d-9a4f-4b67-923c-a184e13b367f)\n|
![Users\nAfter](https://github.com/user-attachments/assets/43bf36bd-1e3b-47d7-b121-0d4142b18cbe)\n|\n\n\n###
Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers
should verify this PR satisfies this list as well.\n\n- [x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios\n\n---------\n\nCo-authored-by: Elastic Machine
<elasticmachine@users.noreply.github.com>\nCo-authored-by: Karen
Grigoryan
<karen.grigoryan@elastic.co>","sha":"fd18951f8faa0a08af3d241c8bdf3f916d55cd68"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/211460","number":211460,"mergeCommit":{"message":"[SecuritySolution]
Numbers of Network KPI metric are cropped (#211460)\n\n## Summary\n\nFix
issue https://github.com/elastic/kibana/issues/210806\n\n\n### Network
Page\n| Before | After |\n|--------|-------|\n|
![Network\nBefore](https://github.com/user-attachments/assets/0b3277f7-dbe2-41a4-ac76-05a806bb42e8)\n|
![Network\nAfter](https://github.com/user-attachments/assets/12b16e81-d13b-495f-9d46-a4154aa8e0cf)\n|\n\n###
Host Page\n| Before | After |\n|--------|-------|\n|
![Host\nBefore](https://github.com/user-attachments/assets/1338b0e5-f4b1-4d1a-ad54-da392f0eff07)\n|
![Host\nAfter](https://github.com/user-attachments/assets/48af01d9-a4aa-450d-ac81-e2b4a724363f)\n|\n\n###
Users Page\n| Before | After |\n|--------|-------|\n|
![Users\nBefore](https://github.com/user-attachments/assets/d7acdf4d-9a4f-4b67-923c-a184e13b367f)\n|
![Users\nAfter](https://github.com/user-attachments/assets/43bf36bd-1e3b-47d7-b121-0d4142b18cbe)\n|\n\n\n###
Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers
should verify this PR satisfies this list as well.\n\n- [x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios\n\n---------\n\nCo-authored-by: Elastic Machine
<elasticmachine@users.noreply.github.com>\nCo-authored-by: Karen
Grigoryan
<karen.grigoryan@elastic.co>","sha":"fd18951f8faa0a08af3d241c8bdf3f916d55cd68"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Agustina Nahir Ruidiaz <61565784+agusruidiazgd@users.noreply.github.com>
JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this pull request Feb 27, 2025
…#211460)

## Summary

Fix issue elastic#210806


### Network Page
| Before | After |
|--------|-------|
| ![Network
Before](https://github.com/user-attachments/assets/0b3277f7-dbe2-41a4-ac76-05a806bb42e8)
| ![Network
After](https://github.com/user-attachments/assets/12b16e81-d13b-495f-9d46-a4154aa8e0cf)
|

### Host Page
| Before | After |
|--------|-------|
| ![Host
Before](https://github.com/user-attachments/assets/1338b0e5-f4b1-4d1a-ad54-da392f0eff07)
| ![Host
After](https://github.com/user-attachments/assets/48af01d9-a4aa-450d-ac81-e2b4a724363f)
|

### Users Page
| Before | After |
|--------|-------|
| ![Users
Before](https://github.com/user-attachments/assets/d7acdf4d-9a4f-4b67-923c-a184e13b367f)
| ![Users
After](https://github.com/user-attachments/assets/43bf36bd-1e3b-47d7-b121-0d4142b18cbe)
|


### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Karen Grigoryan <karen.grigoryan@elastic.co>
SoniaSanzV pushed a commit to SoniaSanzV/kibana that referenced this pull request Mar 4, 2025
…lastic#211460) (elastic#212249)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[SecuritySolution] Numbers of Network KPI metric are cropped
(elastic#211460)](elastic#211460)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Agustina Nahir
Ruidiaz","email":"61565784+agusruidiazgd@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-02-24T14:18:12Z","message":"[SecuritySolution]
Numbers of Network KPI metric are cropped (elastic#211460)\n\n## Summary\n\nFix
issue https://github.com/elastic/kibana/issues/210806\n\n\n### Network
Page\n| Before | After |\n|--------|-------|\n|
![Network\nBefore](https://github.com/user-attachments/assets/0b3277f7-dbe2-41a4-ac76-05a806bb42e8)\n|
![Network\nAfter](https://github.com/user-attachments/assets/12b16e81-d13b-495f-9d46-a4154aa8e0cf)\n|\n\n###
Host Page\n| Before | After |\n|--------|-------|\n|
![Host\nBefore](https://github.com/user-attachments/assets/1338b0e5-f4b1-4d1a-ad54-da392f0eff07)\n|
![Host\nAfter](https://github.com/user-attachments/assets/48af01d9-a4aa-450d-ac81-e2b4a724363f)\n|\n\n###
Users Page\n| Before | After |\n|--------|-------|\n|
![Users\nBefore](https://github.com/user-attachments/assets/d7acdf4d-9a4f-4b67-923c-a184e13b367f)\n|
![Users\nAfter](https://github.com/user-attachments/assets/43bf36bd-1e3b-47d7-b121-0d4142b18cbe)\n|\n\n\n###
Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers
should verify this PR satisfies this list as well.\n\n- [x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios\n\n---------\n\nCo-authored-by: Elastic Machine
<elasticmachine@users.noreply.github.com>\nCo-authored-by: Karen
Grigoryan
<karen.grigoryan@elastic.co>","sha":"fd18951f8faa0a08af3d241c8bdf3f916d55cd68","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","v9.0.0","Team:Threat
Hunting:Explore","backport:prev-minor","v8.18.0","v9.1.0","v8.19.0"],"title":"[SecuritySolution]
Numbers of Network KPI metric are
cropped","number":211460,"url":"https://github.com/elastic/kibana/pull/211460","mergeCommit":{"message":"[SecuritySolution]
Numbers of Network KPI metric are cropped (elastic#211460)\n\n## Summary\n\nFix
issue https://github.com/elastic/kibana/issues/210806\n\n\n### Network
Page\n| Before | After |\n|--------|-------|\n|
![Network\nBefore](https://github.com/user-attachments/assets/0b3277f7-dbe2-41a4-ac76-05a806bb42e8)\n|
![Network\nAfter](https://github.com/user-attachments/assets/12b16e81-d13b-495f-9d46-a4154aa8e0cf)\n|\n\n###
Host Page\n| Before | After |\n|--------|-------|\n|
![Host\nBefore](https://github.com/user-attachments/assets/1338b0e5-f4b1-4d1a-ad54-da392f0eff07)\n|
![Host\nAfter](https://github.com/user-attachments/assets/48af01d9-a4aa-450d-ac81-e2b4a724363f)\n|\n\n###
Users Page\n| Before | After |\n|--------|-------|\n|
![Users\nBefore](https://github.com/user-attachments/assets/d7acdf4d-9a4f-4b67-923c-a184e13b367f)\n|
![Users\nAfter](https://github.com/user-attachments/assets/43bf36bd-1e3b-47d7-b121-0d4142b18cbe)\n|\n\n\n###
Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers
should verify this PR satisfies this list as well.\n\n- [x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios\n\n---------\n\nCo-authored-by: Elastic Machine
<elasticmachine@users.noreply.github.com>\nCo-authored-by: Karen
Grigoryan
<karen.grigoryan@elastic.co>","sha":"fd18951f8faa0a08af3d241c8bdf3f916d55cd68"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/211460","number":211460,"mergeCommit":{"message":"[SecuritySolution]
Numbers of Network KPI metric are cropped (elastic#211460)\n\n## Summary\n\nFix
issue https://github.com/elastic/kibana/issues/210806\n\n\n### Network
Page\n| Before | After |\n|--------|-------|\n|
![Network\nBefore](https://github.com/user-attachments/assets/0b3277f7-dbe2-41a4-ac76-05a806bb42e8)\n|
![Network\nAfter](https://github.com/user-attachments/assets/12b16e81-d13b-495f-9d46-a4154aa8e0cf)\n|\n\n###
Host Page\n| Before | After |\n|--------|-------|\n|
![Host\nBefore](https://github.com/user-attachments/assets/1338b0e5-f4b1-4d1a-ad54-da392f0eff07)\n|
![Host\nAfter](https://github.com/user-attachments/assets/48af01d9-a4aa-450d-ac81-e2b4a724363f)\n|\n\n###
Users Page\n| Before | After |\n|--------|-------|\n|
![Users\nBefore](https://github.com/user-attachments/assets/d7acdf4d-9a4f-4b67-923c-a184e13b367f)\n|
![Users\nAfter](https://github.com/user-attachments/assets/43bf36bd-1e3b-47d7-b121-0d4142b18cbe)\n|\n\n\n###
Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers
should verify this PR satisfies this list as well.\n\n- [x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios\n\n---------\n\nCo-authored-by: Elastic Machine
<elasticmachine@users.noreply.github.com>\nCo-authored-by: Karen
Grigoryan
<karen.grigoryan@elastic.co>","sha":"fd18951f8faa0a08af3d241c8bdf3f916d55cd68"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Agustina Nahir Ruidiaz <61565784+agusruidiazgd@users.noreply.github.com>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Mar 22, 2025
…#211460)

## Summary

Fix issue elastic#210806


### Network Page
| Before | After |
|--------|-------|
| ![Network
Before](https://github.com/user-attachments/assets/0b3277f7-dbe2-41a4-ac76-05a806bb42e8)
| ![Network
After](https://github.com/user-attachments/assets/12b16e81-d13b-495f-9d46-a4154aa8e0cf)
|

### Host Page
| Before | After |
|--------|-------|
| ![Host
Before](https://github.com/user-attachments/assets/1338b0e5-f4b1-4d1a-ad54-da392f0eff07)
| ![Host
After](https://github.com/user-attachments/assets/48af01d9-a4aa-450d-ac81-e2b4a724363f)
|

### Users Page
| Before | After |
|--------|-------|
| ![Users
Before](https://github.com/user-attachments/assets/d7acdf4d-9a4f-4b67-923c-a184e13b367f)
| ![Users
After](https://github.com/user-attachments/assets/43bf36bd-1e3b-47d7-b121-0d4142b18cbe)
|


### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Karen Grigoryan <karen.grigoryan@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes v8.18.0 v8.19.0 v9.0.0 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants