Skip to content

[Security Solution] Add rule upgrade preview FE integration tests (Rule Upgrade Flyout)#210377

Merged
maximpn merged 22 commits intoelastic:mainfrom
maximpn:add-frontend-integration-tests-for-rule-upgrade-flyout
May 1, 2025
Merged

[Security Solution] Add rule upgrade preview FE integration tests (Rule Upgrade Flyout)#210377
maximpn merged 22 commits intoelastic:mainfrom
maximpn:add-frontend-integration-tests-for-rule-upgrade-flyout

Conversation

@maximpn
Copy link
Copy Markdown
Contributor

@maximpn maximpn commented Feb 10, 2025

Partially addresses: #205645

Summary

This PR implements Frontend integration tests from the upgrading prebuilt rules one-by-one with preview test plan.

Details

This PR add Jest integration tests (@kbn/test/jest_integration preset) for Rule Upgrade Flyout. Test scenarios are described in upgrading prebuilt rules one-by-one with preview test plan.

Tests cover each diffable rule field separately to guarantee visibility on broken functionality.

esql_query and threat_mapping fields were skipped due to mocking difficulties.

Tests setup

  • Rules Management page is used as the root component to test functionality in integration
  • HTTP responses are mocked via mocking return values from Kibana.http.fetch() method
  • Test scenarios are the same for each diffable rule field and moved out to reusable utility functions

@maximpn maximpn added test release_note:skip Skip the PR/issue when compiling release notes v9.0.0 Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area backport:version Backport to applied version labels v8.18.0 v9.1.0 v8.19.0 labels Feb 10, 2025
@maximpn maximpn self-assigned this Feb 10, 2025
@maximpn maximpn added the impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. label Feb 10, 2025
@maximpn maximpn force-pushed the add-frontend-integration-tests-for-rule-upgrade-flyout branch 2 times, most recently from e051a96 to 345d49e Compare February 13, 2025 13:25
@maximpn maximpn force-pushed the add-frontend-integration-tests-for-rule-upgrade-flyout branch 3 times, most recently from 18c4294 to 01e0fda Compare March 27, 2025 14:39
@maximpn maximpn force-pushed the add-frontend-integration-tests-for-rule-upgrade-flyout branch 4 times, most recently from 559b114 to 53686f0 Compare April 4, 2025 09:22
@elastic elastic deleted a comment from elasticmachine Apr 4, 2025
@elastic elastic deleted a comment from elasticmachine Apr 4, 2025
@kibanamachine
Copy link
Copy Markdown
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#8150

[✅] x-pack/test/security_solution_api_integration/test_suites/detections_response/detection_engine/rule_execution_logic/machine_learning/trial_license_complete_tier/configs/serverless.config.ts: 50/50 tests passed.
[✅] x-pack/test/security_solution_api_integration/test_suites/detections_response/detection_engine/rule_execution_logic/machine_learning/trial_license_complete_tier/configs/ess.config.ts: 50/50 tests passed.

see run history

@maximpn maximpn marked this pull request as ready for review April 4, 2025 14:49
@maximpn maximpn requested review from a team as code owners April 4, 2025 14:49
@maximpn maximpn force-pushed the add-frontend-integration-tests-for-rule-upgrade-flyout branch from 7781d70 to 81bdbf6 Compare May 1, 2025 07:36
@prodsecmachine
Copy link
Copy Markdown
Collaborator

prodsecmachine commented May 1, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@elasticmachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #2 / integrations Endpoint Exceptions "before all" hook for "should add event.module=endpoint to entry if only wildcard operator is present"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 9.1MB 9.1MB +496.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 558 560 +2

Total ESLint disabled count

id before after diff
securitySolution 645 647 +2

History

cc @maximpn

@maximpn maximpn merged commit ea7ccca into elastic:main May 1, 2025
10 checks passed
@maximpn maximpn deleted the add-frontend-integration-tests-for-rule-upgrade-flyout branch May 1, 2025 09:39
@kibanamachine
Copy link
Copy Markdown
Contributor

Starting backport for target branches: 8.18, 8.19, 9.0

https://github.com/elastic/kibana/actions/runs/14773335675

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 1, 2025
…le Upgrade Flyout) (elastic#210377)

**Partially addresses:** elastic#205645

## Summary

This PR implements Frontend integration tests from the [upgrading prebuilt rules one-by-one with preview test plan](https://github.com/elastic/kibana/blob/main/x-pack/solutions/security/plugins/security_solution/docs/testing/test_plans/detection_response/prebuilt_rules/prebuilt_rule_upgrade_with_preview.md).

## Details

This PR add Jest integration tests (`@kbn/test/jest_integration` preset) for Rule Upgrade Flyout. Test scenarios are described in [upgrading prebuilt rules one-by-one with preview test plan](https://github.com/elastic/kibana/blob/main/x-pack/solutions/security/plugins/security_solution/docs/testing/test_plans/detection_response/prebuilt_rules/prebuilt_rule_upgrade_with_preview.md).

Tests cover each `diffable rule` field separately to guarantee visibility on broken functionality.

`esql_query` and `threat_mapping` fields were skipped due to mocking difficulties.

### Tests setup

- Rules Management page is used as the root component to test functionality in integration
- HTTP responses are mocked via mocking return values from `Kibana.http.fetch()` method
- Test scenarios are the same for each diffable rule field and moved out to reusable utility functions

(cherry picked from commit ea7ccca)
@kibanamachine
Copy link
Copy Markdown
Contributor

💔 Some backports could not be created

Status Branch Result
8.18 Backport failed because of merge conflicts
8.19 Backport failed because of merge conflicts
9.0

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 210377

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 1, 2025
…ts (Rule Upgrade Flyout) (#210377) (#219828)

# Backport

This will backport the following commits from `main` to `9.0`:
- [[Security Solution] Add rule upgrade preview FE integration tests
(Rule Upgrade Flyout)
(#210377)](#210377)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Maxim
Palenov","email":"maxim.palenov@elastic.co"},"sourceCommit":{"committedDate":"2025-05-01T09:39:17Z","message":"[Security
Solution] Add rule upgrade preview FE integration tests (Rule Upgrade
Flyout) (#210377)\n\n**Partially addresses:**
https://github.com/elastic/kibana/pull/205645\n\n## Summary\n\nThis PR
implements Frontend integration tests from the [upgrading prebuilt rules
one-by-one with preview test
plan](https://github.com/elastic/kibana/blob/main/x-pack/solutions/security/plugins/security_solution/docs/testing/test_plans/detection_response/prebuilt_rules/prebuilt_rule_upgrade_with_preview.md).\n\n##
Details\n\nThis PR add Jest integration tests
(`@kbn/test/jest_integration` preset) for Rule Upgrade Flyout. Test
scenarios are described in [upgrading prebuilt rules one-by-one with
preview test
plan](https://github.com/elastic/kibana/blob/main/x-pack/solutions/security/plugins/security_solution/docs/testing/test_plans/detection_response/prebuilt_rules/prebuilt_rule_upgrade_with_preview.md).\n\nTests
cover each `diffable rule` field separately to guarantee visibility on
broken functionality.\n\n`esql_query` and `threat_mapping` fields were
skipped due to mocking difficulties.\n\n### Tests setup\n\n- Rules
Management page is used as the root component to test functionality in
integration\n- HTTP responses are mocked via mocking return values from
`Kibana.http.fetch()` method\n- Test scenarios are the same for each
diffable rule field and moved out to reusable utility
functions","sha":"ea7cccab0884923d46e9bcf3a2b4106b0c3dd0f2","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","release_note:skip","impact:high","v9.0.0","Team:Detections
and Resp","Team: SecuritySolution","Team:Detection Rule
Management","Feature:Prebuilt Detection
Rules","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Security
Solution] Add rule upgrade preview FE integration tests (Rule Upgrade
Flyout)","number":210377,"url":"https://github.com/elastic/kibana/pull/210377","mergeCommit":{"message":"[Security
Solution] Add rule upgrade preview FE integration tests (Rule Upgrade
Flyout) (#210377)\n\n**Partially addresses:**
https://github.com/elastic/kibana/pull/205645\n\n## Summary\n\nThis PR
implements Frontend integration tests from the [upgrading prebuilt rules
one-by-one with preview test
plan](https://github.com/elastic/kibana/blob/main/x-pack/solutions/security/plugins/security_solution/docs/testing/test_plans/detection_response/prebuilt_rules/prebuilt_rule_upgrade_with_preview.md).\n\n##
Details\n\nThis PR add Jest integration tests
(`@kbn/test/jest_integration` preset) for Rule Upgrade Flyout. Test
scenarios are described in [upgrading prebuilt rules one-by-one with
preview test
plan](https://github.com/elastic/kibana/blob/main/x-pack/solutions/security/plugins/security_solution/docs/testing/test_plans/detection_response/prebuilt_rules/prebuilt_rule_upgrade_with_preview.md).\n\nTests
cover each `diffable rule` field separately to guarantee visibility on
broken functionality.\n\n`esql_query` and `threat_mapping` fields were
skipped due to mocking difficulties.\n\n### Tests setup\n\n- Rules
Management page is used as the root component to test functionality in
integration\n- HTTP responses are mocked via mocking return values from
`Kibana.http.fetch()` method\n- Test scenarios are the same for each
diffable rule field and moved out to reusable utility
functions","sha":"ea7cccab0884923d46e9bcf3a2b4106b0c3dd0f2"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.19"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/210377","number":210377,"mergeCommit":{"message":"[Security
Solution] Add rule upgrade preview FE integration tests (Rule Upgrade
Flyout) (#210377)\n\n**Partially addresses:**
https://github.com/elastic/kibana/pull/205645\n\n## Summary\n\nThis PR
implements Frontend integration tests from the [upgrading prebuilt rules
one-by-one with preview test
plan](https://github.com/elastic/kibana/blob/main/x-pack/solutions/security/plugins/security_solution/docs/testing/test_plans/detection_response/prebuilt_rules/prebuilt_rule_upgrade_with_preview.md).\n\n##
Details\n\nThis PR add Jest integration tests
(`@kbn/test/jest_integration` preset) for Rule Upgrade Flyout. Test
scenarios are described in [upgrading prebuilt rules one-by-one with
preview test
plan](https://github.com/elastic/kibana/blob/main/x-pack/solutions/security/plugins/security_solution/docs/testing/test_plans/detection_response/prebuilt_rules/prebuilt_rule_upgrade_with_preview.md).\n\nTests
cover each `diffable rule` field separately to guarantee visibility on
broken functionality.\n\n`esql_query` and `threat_mapping` fields were
skipped due to mocking difficulties.\n\n### Tests setup\n\n- Rules
Management page is used as the root component to test functionality in
integration\n- HTTP responses are mocked via mocking return values from
`Kibana.http.fetch()` method\n- Test scenarios are the same for each
diffable rule field and moved out to reusable utility
functions","sha":"ea7cccab0884923d46e9bcf3a2b4106b0c3dd0f2"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Maxim Palenov <maxim.palenov@elastic.co>
@mistic
Copy link
Copy Markdown
Contributor

mistic commented May 6, 2025

This PR didn't make it into the latest 9.0.1 BC. Updating the labels.

akowalska622 pushed a commit to akowalska622/kibana that referenced this pull request May 29, 2025
…le Upgrade Flyout) (elastic#210377)

**Partially addresses:** elastic#205645

## Summary

This PR implements Frontend integration tests from the [upgrading prebuilt rules one-by-one with preview test plan](https://github.com/elastic/kibana/blob/main/x-pack/solutions/security/plugins/security_solution/docs/testing/test_plans/detection_response/prebuilt_rules/prebuilt_rule_upgrade_with_preview.md).

## Details

This PR add Jest integration tests (`@kbn/test/jest_integration` preset) for Rule Upgrade Flyout. Test scenarios are described in [upgrading prebuilt rules one-by-one with preview test plan](https://github.com/elastic/kibana/blob/main/x-pack/solutions/security/plugins/security_solution/docs/testing/test_plans/detection_response/prebuilt_rules/prebuilt_rule_upgrade_with_preview.md).

Tests cover each `diffable rule` field separately to guarantee visibility on broken functionality.

`esql_query` and `threat_mapping` fields were skipped due to mocking difficulties.

### Tests setup

- Rules Management page is used as the root component to test functionality in integration
- HTTP responses are mocked via mocking return values from `Kibana.http.fetch()` method
- Test scenarios are the same for each diffable rule field and moved out to reusable utility functions
maximpn added a commit to maximpn/kibana that referenced this pull request Jun 26, 2025
…le Upgrade Flyout) (elastic#210377)

**Partially addresses:** elastic#205645

## Summary

This PR implements Frontend integration tests from the [upgrading prebuilt rules one-by-one with preview test plan](https://github.com/elastic/kibana/blob/main/x-pack/solutions/security/plugins/security_solution/docs/testing/test_plans/detection_response/prebuilt_rules/prebuilt_rule_upgrade_with_preview.md).

## Details

This PR add Jest integration tests (`@kbn/test/jest_integration` preset) for Rule Upgrade Flyout. Test scenarios are described in [upgrading prebuilt rules one-by-one with preview test plan](https://github.com/elastic/kibana/blob/main/x-pack/solutions/security/plugins/security_solution/docs/testing/test_plans/detection_response/prebuilt_rules/prebuilt_rule_upgrade_with_preview.md).

Tests cover each `diffable rule` field separately to guarantee visibility on broken functionality.

`esql_query` and `threat_mapping` fields were skipped due to mocking difficulties.

### Tests setup

- Rules Management page is used as the root component to test functionality in integration
- HTTP responses are mocked via mocking return values from `Kibana.http.fetch()` method
- Test scenarios are the same for each diffable rule field and moved out to reusable utility functions

(cherry picked from commit ea7ccca)

# Conflicts:
#	x-pack/solutions/security/plugins/security_solution/public/common/lib/kibana/kibana_react.mock.ts
@maximpn
Copy link
Copy Markdown
Contributor Author

maximpn commented Jun 26, 2025

💚 All backports created successfully

Status Branch Result
8.19
8.18

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

maximpn added a commit that referenced this pull request Jul 3, 2025
…sts (Rule Upgrade Flyout) (#210377) (#225549)

# Backport

This will backport the following commits from `main` to `8.18`:
 - [[Security Solution] Add rule upgrade preview FE integration tests (Rule Upgrade Flyout) (#210377)](#210377)

<!--- Backport version: 10.0.1 -->

### Questions ?
Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Maxim Palenov","email":"maxim.palenov@elastic.co"},"sourceCommit":{"committedDate":"2025-05-01T09:39:17Z","message":"[Security Solution] Add rule upgrade preview FE integration tests (Rule Upgrade Flyout) (#210377)\n\n**Partially addresses:** https://github.com/elastic/kibana/pull/205645\n\n## Summary\n\nThis PR implements Frontend integration tests from the [upgrading prebuilt rules one-by-one with preview test plan](https://github.com/elastic/kibana/blob/main/x-pack/solutions/security/plugins/security_solution/docs/testing/test_plans/detection_response/prebuilt_rules/prebuilt_rule_upgrade_with_preview.md).\n\n## Details\n\nThis PR add Jest integration tests (`@kbn/test/jest_integration` preset) for Rule Upgrade Flyout. Test scenarios are described in [upgrading prebuilt rules one-by-one with preview test plan](https://github.com/elastic/kibana/blob/main/x-pack/solutions/security/plugins/security_solution/docs/testing/test_plans/detection_response/prebuilt_rules/prebuilt_rule_upgrade_with_preview.md).\n\nTests cover each `diffable rule` field separately to guarantee visibility on broken functionality.\n\n`esql_query` and `threat_mapping` fields were skipped due to mocking difficulties.\n\n### Tests setup\n\n- Rules Management page is used as the root component to test functionality in integration\n- HTTP responses are mocked via mocking return values from `Kibana.http.fetch()` method\n- Test scenarios are the same for each diffable rule field and moved out to reusable utility functions","sha":"ea7cccab0884923d46e9bcf3a2b4106b0c3dd0f2","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","release_note:skip","impact:high","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","backport:version","v8.18.0","v9.1.0","v8.19.0","v9.0.2"],"title":"[Security Solution] Add rule upgrade preview FE integration tests (Rule Upgrade Flyout)","number":210377,"url":"https://github.com/elastic/kibana/pull/210377","mergeCommit":{"message":"[Security Solution] Add rule upgrade preview FE integration tests (Rule Upgrade Flyout) (#210377)\n\n**Partially addresses:** https://github.com/elastic/kibana/pull/205645\n\n## Summary\n\nThis PR implements Frontend integration tests from the [upgrading prebuilt rules one-by-one with preview test plan](https://github.com/elastic/kibana/blob/main/x-pack/solutions/security/plugins/security_solution/docs/testing/test_plans/detection_response/prebuilt_rules/prebuilt_rule_upgrade_with_preview.md).\n\n## Details\n\nThis PR add Jest integration tests (`@kbn/test/jest_integration` preset) for Rule Upgrade Flyout. Test scenarios are described in [upgrading prebuilt rules one-by-one with preview test plan](https://github.com/elastic/kibana/blob/main/x-pack/solutions/security/plugins/security_solution/docs/testing/test_plans/detection_response/prebuilt_rules/prebuilt_rule_upgrade_with_preview.md).\n\nTests cover each `diffable rule` field separately to guarantee visibility on broken functionality.\n\n`esql_query` and `threat_mapping` fields were skipped due to mocking difficulties.\n\n### Tests setup\n\n- Rules Management page is used as the root component to test functionality in integration\n- HTTP responses are mocked via mocking return values from `Kibana.http.fetch()` method\n- Test scenarios are the same for each diffable rule field and moved out to reusable utility functions","sha":"ea7cccab0884923d46e9bcf3a2b4106b0c3dd0f2"}},"sourceBranch":"main","suggestedTargetBranches":["8.18","8.19"],"targetPullRequestStates":[{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/210377","number":210377,"mergeCommit":{"message":"[Security Solution] Add rule upgrade preview FE integration tests (Rule Upgrade Flyout) (#210377)\n\n**Partially addresses:** https://github.com/elastic/kibana/pull/205645\n\n## Summary\n\nThis PR implements Frontend integration tests from the [upgrading prebuilt rules one-by-one with preview test plan](https://github.com/elastic/kibana/blob/main/x-pack/solutions/security/plugins/security_solution/docs/testing/test_plans/detection_response/prebuilt_rules/prebuilt_rule_upgrade_with_preview.md).\n\n## Details\n\nThis PR add Jest integration tests (`@kbn/test/jest_integration` preset) for Rule Upgrade Flyout. Test scenarios are described in [upgrading prebuilt rules one-by-one with preview test plan](https://github.com/elastic/kibana/blob/main/x-pack/solutions/security/plugins/security_solution/docs/testing/test_plans/detection_response/prebuilt_rules/prebuilt_rule_upgrade_with_preview.md).\n\nTests cover each `diffable rule` field separately to guarantee visibility on broken functionality.\n\n`esql_query` and `threat_mapping` fields were skipped due to mocking difficulties.\n\n### Tests setup\n\n- Rules Management page is used as the root component to test functionality in integration\n- HTTP responses are mocked via mocking return values from `Kibana.http.fetch()` method\n- Test scenarios are the same for each diffable rule field and moved out to reusable utility functions","sha":"ea7cccab0884923d46e9bcf3a2b4106b0c3dd0f2"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/219828","number":219828,"state":"MERGED","mergeCommit":{"sha":"d9fb3045212de2593577f738b10ee31dfd896a46","message":"[9.0] [Security Solution] Add rule upgrade preview FE integration tests (Rule Upgrade Flyout) (#210377) (#219828)\n\n# Backport\n\nThis will backport the following commits from `main` to `9.0`:\n- [[Security Solution] Add rule upgrade preview FE integration tests\n(Rule Upgrade Flyout)\n(#210377)](https://github.com/elastic/kibana/pull/210377)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Maxim Palenov <maxim.palenov@elastic.co>"}}]}] BACKPORT-->
@kibanamachine
Copy link
Copy Markdown
Contributor

Starting backport for target branches: 8.18, 8.19, 9.0, 9.1

https://github.com/elastic/kibana/actions/runs/16060340256

@kibanamachine
Copy link
Copy Markdown
Contributor

Starting backport for target branches: 8.18, 8.19, 9.0, 9.1

https://github.com/elastic/kibana/actions/runs/16060344564

@kibanamachine
Copy link
Copy Markdown
Contributor

💔 All backports failed

Status Branch Result
8.18 Backport failed because of merge conflicts
8.19 Backport failed because of merge conflicts
9.0 Backport failed because of merge conflicts
9.1 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 210377

Questions ?

Please refer to the Backport tool documentation

1 similar comment
@kibanamachine
Copy link
Copy Markdown
Contributor

💔 All backports failed

Status Branch Result
8.18 Backport failed because of merge conflicts
8.19 Backport failed because of merge conflicts
9.0 Backport failed because of merge conflicts
9.1 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 210377

Questions ?

Please refer to the Backport tool documentation

maximpn added a commit that referenced this pull request Jul 4, 2025
…sts (Rule Upgrade Flyout) (#210377) (#225548)

# Backport

This will backport the following commits from `main` to `8.19`:
- [[Security Solution] Add rule upgrade preview FE integration tests
(Rule Upgrade Flyout)
(#210377)](#210377)

<!--- Backport version: 10.0.1 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Maxim
Palenov","email":"maxim.palenov@elastic.co"},"sourceCommit":{"committedDate":"2025-05-01T09:39:17Z","message":"[Security
Solution] Add rule upgrade preview FE integration tests (Rule Upgrade
Flyout) (#210377)\n\n**Partially addresses:**
https://github.com/elastic/kibana/pull/205645\n\n## Summary\n\nThis PR
implements Frontend integration tests from the [upgrading prebuilt rules
one-by-one with preview test
plan](https://github.com/elastic/kibana/blob/main/x-pack/solutions/security/plugins/security_solution/docs/testing/test_plans/detection_response/prebuilt_rules/prebuilt_rule_upgrade_with_preview.md).\n\n##
Details\n\nThis PR add Jest integration tests
(`@kbn/test/jest_integration` preset) for Rule Upgrade Flyout. Test
scenarios are described in [upgrading prebuilt rules one-by-one with
preview test
plan](https://github.com/elastic/kibana/blob/main/x-pack/solutions/security/plugins/security_solution/docs/testing/test_plans/detection_response/prebuilt_rules/prebuilt_rule_upgrade_with_preview.md).\n\nTests
cover each `diffable rule` field separately to guarantee visibility on
broken functionality.\n\n`esql_query` and `threat_mapping` fields were
skipped due to mocking difficulties.\n\n### Tests setup\n\n- Rules
Management page is used as the root component to test functionality in
integration\n- HTTP responses are mocked via mocking return values from
`Kibana.http.fetch()` method\n- Test scenarios are the same for each
diffable rule field and moved out to reusable utility
functions","sha":"ea7cccab0884923d46e9bcf3a2b4106b0c3dd0f2","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","release_note:skip","impact:high","Team:Detections
and Resp","Team: SecuritySolution","Team:Detection Rule
Management","Feature:Prebuilt Detection
Rules","backport:version","v8.18.0","v9.1.0","v8.19.0","v9.0.2"],"title":"[Security
Solution] Add rule upgrade preview FE integration tests (Rule Upgrade
Flyout)","number":210377,"url":"https://github.com/elastic/kibana/pull/210377","mergeCommit":{"message":"[Security
Solution] Add rule upgrade preview FE integration tests (Rule Upgrade
Flyout) (#210377)\n\n**Partially addresses:**
https://github.com/elastic/kibana/pull/205645\n\n## Summary\n\nThis PR
implements Frontend integration tests from the [upgrading prebuilt rules
one-by-one with preview test
plan](https://github.com/elastic/kibana/blob/main/x-pack/solutions/security/plugins/security_solution/docs/testing/test_plans/detection_response/prebuilt_rules/prebuilt_rule_upgrade_with_preview.md).\n\n##
Details\n\nThis PR add Jest integration tests
(`@kbn/test/jest_integration` preset) for Rule Upgrade Flyout. Test
scenarios are described in [upgrading prebuilt rules one-by-one with
preview test
plan](https://github.com/elastic/kibana/blob/main/x-pack/solutions/security/plugins/security_solution/docs/testing/test_plans/detection_response/prebuilt_rules/prebuilt_rule_upgrade_with_preview.md).\n\nTests
cover each `diffable rule` field separately to guarantee visibility on
broken functionality.\n\n`esql_query` and `threat_mapping` fields were
skipped due to mocking difficulties.\n\n### Tests setup\n\n- Rules
Management page is used as the root component to test functionality in
integration\n- HTTP responses are mocked via mocking return values from
`Kibana.http.fetch()` method\n- Test scenarios are the same for each
diffable rule field and moved out to reusable utility
functions","sha":"ea7cccab0884923d46e9bcf3a2b4106b0c3dd0f2"}},"sourceBranch":"main","suggestedTargetBranches":["8.18","8.19"],"targetPullRequestStates":[{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/210377","number":210377,"mergeCommit":{"message":"[Security
Solution] Add rule upgrade preview FE integration tests (Rule Upgrade
Flyout) (#210377)\n\n**Partially addresses:**
https://github.com/elastic/kibana/pull/205645\n\n## Summary\n\nThis PR
implements Frontend integration tests from the [upgrading prebuilt rules
one-by-one with preview test
plan](https://github.com/elastic/kibana/blob/main/x-pack/solutions/security/plugins/security_solution/docs/testing/test_plans/detection_response/prebuilt_rules/prebuilt_rule_upgrade_with_preview.md).\n\n##
Details\n\nThis PR add Jest integration tests
(`@kbn/test/jest_integration` preset) for Rule Upgrade Flyout. Test
scenarios are described in [upgrading prebuilt rules one-by-one with
preview test
plan](https://github.com/elastic/kibana/blob/main/x-pack/solutions/security/plugins/security_solution/docs/testing/test_plans/detection_response/prebuilt_rules/prebuilt_rule_upgrade_with_preview.md).\n\nTests
cover each `diffable rule` field separately to guarantee visibility on
broken functionality.\n\n`esql_query` and `threat_mapping` fields were
skipped due to mocking difficulties.\n\n### Tests setup\n\n- Rules
Management page is used as the root component to test functionality in
integration\n- HTTP responses are mocked via mocking return values from
`Kibana.http.fetch()` method\n- Test scenarios are the same for each
diffable rule field and moved out to reusable utility
functions","sha":"ea7cccab0884923d46e9bcf3a2b4106b0c3dd0f2"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/219828","number":219828,"state":"MERGED","mergeCommit":{"sha":"d9fb3045212de2593577f738b10ee31dfd896a46","message":"[9.0]
[Security Solution] Add rule upgrade preview FE integration tests (Rule
Upgrade Flyout) (#210377) (#219828)\n\n# Backport\n\nThis will backport
the following commits from `main` to `9.0`:\n- [[Security Solution] Add
rule upgrade preview FE integration tests\n(Rule Upgrade
Flyout)\n(#210377)](https://github.com/elastic/kibana/pull/210377)\n\n\n\n###
Questions ?\nPlease refer to the [Backport
tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by:
Maxim Palenov <maxim.palenov@elastic.co>"}}]}] BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. release_note:skip Skip the PR/issue when compiling release notes Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. test v8.18.0 v8.18.4 v8.19.0 v9.0.2 v9.1.0 v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants