[Upgrade Assistant] Critical Kibana API deprecations should not block upgrades#209128

Merged

jloleysens merged 2 commits intoelastic:mainfrom

jloleysens:ua/ignore-kibana-critical-api-deprecations-for-upgrade

Feb 3, 2025

Contributor

jloleysens commented Jan 31, 2025 •

edited by kibanamachine

Loading

Summary

Filters out any deprecated Kibana API usages from blocking upgrade status.

Checklist

Unit or functional tests were updated or added to match the most common scenarios

Risks

Should be mitigated by E2E tests


          filter out critical Kibana api deprecations from readiness status

ee09814

jloleysens added Team:Core release_note:skip Feature:Upgrade Assistant v9.0.0 backport:version v8.18.0 v9.1.0 v8.19.0 labels

jloleysens requested a review from a team as a code owner

January 31, 2025 15:24

Contributor

elasticmachine commented Jan 31, 2025

Pinging @elastic/kibana-core (Team:Core)

jloleysens commented

View reviewed changes

x-pack/platform/plugins/private/upgrade_assistant/server/lib/kibana_status.ts

-                const totalCriticalDeprecations = kibanaDeprecations.filter((d) => d.level === 'critical').length;
+                const totalCriticalDeprecations = kibanaDeprecations.filter(
+                  (d) => d.deprecationType !== 'api' && d.level === 'critical'

Contributor Author

jloleysens Jan 31, 2025

The "critical" change

x-pack/test/upgrade_assistant_integration/upgrade_assistant/index.ts

    
                  loadTestFile(require.resolve('./reindexing'));

                describe('upgrade assistant', function () {

                  // FAILING VERSION BUMP: https://github.com/elastic/kibana/issues/209048

                  // loadTestFile(require.resolve('./reindexing'));

Contributor Author

jloleysens Jan 31, 2025

I think we only want to skip the reindexing for now...

TinaHeiligers approved these changes

View reviewed changes

Contributor

TinaHeiligers left a comment

LGTM (code review only)


          Merge branch 'main' into ua/ignore-kibana-critical-api-deprecations-f…

760cefe

…or-upgrade

jloleysens enabled auto-merge (squash)

February 3, 2025 09:29

jloleysens merged commit 6bcdac4 into elastic:main

Contributor

kibanamachine commented Feb 3, 2025

Starting backport for target branches: 8.18, 8.x, 9.0

https://github.com/elastic/kibana/actions/runs/13112486413

Contributor

elasticmachine commented Feb 3, 2025

💚 Build Succeeded

Buildkite Build
Commit: 760cefe

Metrics [docs]

✅ unchanged

History

💚 Build #272327 succeeded ee09814

Contributor

kibanamachine commented Feb 3, 2025

💔 All backports failed

Status	Branch	Result
❌	8.18	Backport failed because of merge conflicts
❌	8.x	Backport failed because of merge conflicts You might need to backport the following PRs to 8.x: - [Core] [UA] Support API Deprecations (#196081)
❌	9.0	Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 209128

Questions ?

Please refer to the Backport tool documentation

kibanamachine added the backport missing label

Contributor

kibanamachine commented Feb 5, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 209128 locally

kibanamachine mentioned this pull request

[Streams 🌊] Introduce GroupStreams #208126

Merged

Contributor

kibanamachine commented Feb 6, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 209128 locally

7 similar comments

Contributor

kibanamachine commented Feb 7, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 209128 locally

Contributor

kibanamachine commented Feb 10, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 209128 locally

Contributor

kibanamachine commented Feb 11, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 209128 locally

Contributor

kibanamachine commented Feb 12, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 209128 locally

Contributor

kibanamachine commented Feb 13, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 209128 locally

Contributor

kibanamachine commented Feb 14, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 209128 locally

Contributor

kibanamachine commented Feb 17, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 209128 locally

jloleysens mentioned this pull request

[9.0] [Upgrade Assistant] Critical Kibana API deprecations should not block upgrades (#209128) #211572

Merged

jloleysens added a commit to jloleysens/kibana that referenced this pull request


          [Upgrade Assistant] Critical Kibana API deprecations should not block…

b98a613

… upgrades (elastic#209128)

## Summary

Filters out any deprecated Kibana API usages from blocking upgrade
status.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### Risks

Should be mitigated by E2E tests

(cherry picked from commit 6bcdac4)

# Conflicts:
#	x-pack/test/upgrade_assistant_integration/upgrade_assistant/index.ts

jloleysens mentioned this pull request

[8.x] [Upgrade Assistant] Critical Kibana API deprecations should not block upgrades (#209128) #211573

Merged

jloleysens added a commit to jloleysens/kibana that referenced this pull request


          [Upgrade Assistant] Critical Kibana API deprecations should not block…

04fa9e5

… upgrades (elastic#209128)

## Summary

Filters out any deprecated Kibana API usages from blocking upgrade
status.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### Risks

Should be mitigated by E2E tests

(cherry picked from commit 6bcdac4)

# Conflicts:
#	x-pack/test/upgrade_assistant_integration/upgrade_assistant/index.ts

jloleysens added a commit to jloleysens/kibana that referenced this pull request


          [Upgrade Assistant] Critical Kibana API deprecations should not block…

965da27

… upgrades (elastic#209128)

## Summary

Filters out any deprecated Kibana API usages from blocking upgrade
status.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### Risks

Should be mitigated by E2E tests

(cherry picked from commit 6bcdac4)

# Conflicts:
#	x-pack/test/upgrade_assistant_integration/upgrade_assistant/index.ts

jloleysens mentioned this pull request

[8.18] [Upgrade Assistant] Critical Kibana API deprecations should not block upgrades (#209128) #211574

Merged

Contributor Author

jloleysens commented Feb 18, 2025

💚 All backports created successfully

Status	Branch	Result
✅	9.0
✅	8.x
✅	8.18

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

jloleysens added a commit that referenced this pull request


          [9.0] [Upgrade Assistant] Critical Kibana API deprecations should not…

319dd21

… block upgrades (#209128) (#211572)

# Backport

This will backport the following commits from `main` to `9.0`:
- [[Upgrade Assistant] Critical Kibana API deprecations should not block
upgrades (#209128)](#209128)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Jean-Louis
Leysens","email":"jeanlouis.leysens@elastic.co"},"sourceCommit":{"committedDate":"2025-02-03T11:29:05Z","message":"[Upgrade
Assistant] Critical Kibana API deprecations should not block upgrades
(#209128)\n\n## Summary\r\n\r\nFilters out any deprecated Kibana API
usages from blocking upgrade\r\nstatus.\r\n\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n\r\n###
Risks\r\n\r\nShould be mitigated by E2E
tests","sha":"6bcdac4571ffff20e62328332d2b073f892d3b61","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","Feature:Upgrade
Assistant","backport
missing","v9.0.0","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Upgrade
Assistant] Critical Kibana API deprecations should not block
upgrades","number":209128,"url":"https://github.com/elastic/kibana/pull/209128","mergeCommit":{"message":"[Upgrade
Assistant] Critical Kibana API deprecations should not block upgrades
(#209128)\n\n## Summary\r\n\r\nFilters out any deprecated Kibana API
usages from blocking upgrade\r\nstatus.\r\n\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n\r\n###
Risks\r\n\r\nShould be mitigated by E2E
tests","sha":"6bcdac4571ffff20e62328332d2b073f892d3b61"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209128","number":209128,"mergeCommit":{"message":"[Upgrade
Assistant] Critical Kibana API deprecations should not block upgrades
(#209128)\n\n## Summary\r\n\r\nFilters out any deprecated Kibana API
usages from blocking upgrade\r\nstatus.\r\n\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n\r\n###
Risks\r\n\r\nShould be mitigated by E2E
tests","sha":"6bcdac4571ffff20e62328332d2b073f892d3b61"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Contributor

kibanamachine commented Feb 18, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

jloleysens added a commit that referenced this pull request


          [8.x] [Upgrade Assistant] Critical Kibana API deprecations should not…

bddce22

… block upgrades (#209128) (#211573)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Upgrade Assistant] Critical Kibana API deprecations should not block
upgrades (#209128)](#209128)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Jean-Louis
Leysens","email":"jeanlouis.leysens@elastic.co"},"sourceCommit":{"committedDate":"2025-02-03T11:29:05Z","message":"[Upgrade
Assistant] Critical Kibana API deprecations should not block upgrades
(#209128)\n\n## Summary\r\n\r\nFilters out any deprecated Kibana API
usages from blocking upgrade\r\nstatus.\r\n\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n\r\n###
Risks\r\n\r\nShould be mitigated by E2E
tests","sha":"6bcdac4571ffff20e62328332d2b073f892d3b61","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","Feature:Upgrade
Assistant","backport
missing","v9.0.0","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Upgrade
Assistant] Critical Kibana API deprecations should not block
upgrades","number":209128,"url":"https://github.com/elastic/kibana/pull/209128","mergeCommit":{"message":"[Upgrade
Assistant] Critical Kibana API deprecations should not block upgrades
(#209128)\n\n## Summary\r\n\r\nFilters out any deprecated Kibana API
usages from blocking upgrade\r\nstatus.\r\n\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n\r\n###
Risks\r\n\r\nShould be mitigated by E2E
tests","sha":"6bcdac4571ffff20e62328332d2b073f892d3b61"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209128","number":209128,"mergeCommit":{"message":"[Upgrade
Assistant] Critical Kibana API deprecations should not block upgrades
(#209128)\n\n## Summary\r\n\r\nFilters out any deprecated Kibana API
usages from blocking upgrade\r\nstatus.\r\n\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n\r\n###
Risks\r\n\r\nShould be mitigated by E2E
tests","sha":"6bcdac4571ffff20e62328332d2b073f892d3b61"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

jloleysens added a commit that referenced this pull request


          [8.18] [Upgrade Assistant] Critical Kibana API deprecations should no…

8fbbf29

…t block upgrades (#209128) (#211574)

# Backport

This will backport the following commits from `main` to `8.18`:
- [[Upgrade Assistant] Critical Kibana API deprecations should not block
upgrades (#209128)](#209128)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Jean-Louis
Leysens","email":"jeanlouis.leysens@elastic.co"},"sourceCommit":{"committedDate":"2025-02-03T11:29:05Z","message":"[Upgrade
Assistant] Critical Kibana API deprecations should not block upgrades
(#209128)\n\n## Summary\r\n\r\nFilters out any deprecated Kibana API
usages from blocking upgrade\r\nstatus.\r\n\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n\r\n###
Risks\r\n\r\nShould be mitigated by E2E
tests","sha":"6bcdac4571ffff20e62328332d2b073f892d3b61","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","Feature:Upgrade
Assistant","backport
missing","v9.0.0","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Upgrade
Assistant] Critical Kibana API deprecations should not block
upgrades","number":209128,"url":"https://github.com/elastic/kibana/pull/209128","mergeCommit":{"message":"[Upgrade
Assistant] Critical Kibana API deprecations should not block upgrades
(#209128)\n\n## Summary\r\n\r\nFilters out any deprecated Kibana API
usages from blocking upgrade\r\nstatus.\r\n\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n\r\n###
Risks\r\n\r\nShould be mitigated by E2E
tests","sha":"6bcdac4571ffff20e62328332d2b073f892d3b61"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209128","number":209128,"mergeCommit":{"message":"[Upgrade
Assistant] Critical Kibana API deprecations should not block upgrades
(#209128)\n\n## Summary\r\n\r\nFilters out any deprecated Kibana API
usages from blocking upgrade\r\nstatus.\r\n\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n\r\n###
Risks\r\n\r\nShould be mitigated by E2E
tests","sha":"6bcdac4571ffff20e62328332d2b073f892d3b61"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

kibanamachine removed the backport missing label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Feature:Upgrade Assistant release_note:skip Team:Core v8.18.0 v8.19.0 v9.0.0 v9.1.0