[Fleet] Improve package verification memory usage#208475
Merged
nchaulet merged 2 commits intoelastic:mainfrom Jan 28, 2025
Merged
[Fleet] Improve package verification memory usage#208475nchaulet merged 2 commits intoelastic:mainfrom
nchaulet merged 2 commits intoelastic:mainfrom
Conversation
Contributor
|
Pinging @elastic/fleet (Team:Fleet) |
Member
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build Succeeded
Metrics [docs]
cc @nchaulet |
juliaElastic
approved these changes
Jan 28, 2025
Contributor
|
Starting backport for target branches: 8.x |
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Contributor
|
Starting backport for target branches: 8.17, 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 28, 2025
(cherry picked from commit 2887aa6)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 28, 2025
(cherry picked from commit 2887aa6)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 28, 2025
…08535) # Backport This will backport the following commits from `main` to `8.x`: - [[Fleet] Improve package verification memory usage (#208475)](#208475) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nicolas Chaulet","email":"nicolas.chaulet@elastic.co"},"sourceCommit":{"committedDate":"2025-01-28T13:46:28Z","message":"[Fleet] Improve package verification memory usage (#208475)","sha":"2887aa698573427756d302648a2ed53f568b8c38","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","backport:prev-minor","backport:8.17"],"title":"[Fleet] Improve package verification memory usage","number":208475,"url":"https://github.com/elastic/kibana/pull/208475","mergeCommit":{"message":"[Fleet] Improve package verification memory usage (#208475)","sha":"2887aa698573427756d302648a2ed53f568b8c38"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/208475","number":208475,"mergeCommit":{"message":"[Fleet] Improve package verification memory usage (#208475)","sha":"2887aa698573427756d302648a2ed53f568b8c38"}}]}] BACKPORT--> Co-authored-by: Nicolas Chaulet <nicolas.chaulet@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Jan 28, 2025
…208537) # Backport This will backport the following commits from `main` to `8.17`: - [[Fleet] Improve package verification memory usage (#208475)](#208475) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nicolas Chaulet","email":"nicolas.chaulet@elastic.co"},"sourceCommit":{"committedDate":"2025-01-28T13:46:28Z","message":"[Fleet] Improve package verification memory usage (#208475)","sha":"2887aa698573427756d302648a2ed53f568b8c38","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","backport:prev-minor","backport:version","backport:8.17","v8.17.2"],"title":"[Fleet] Improve package verification memory usage","number":208475,"url":"https://github.com/elastic/kibana/pull/208475","mergeCommit":{"message":"[Fleet] Improve package verification memory usage (#208475)","sha":"2887aa698573427756d302648a2ed53f568b8c38"}},"sourceBranch":"main","suggestedTargetBranches":["8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/208475","number":208475,"mergeCommit":{"message":"[Fleet] Improve package verification memory usage (#208475)","sha":"2887aa698573427756d302648a2ed53f568b8c38"}},{"branch":"8.17","label":"v8.17.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"url":"https://github.com/elastic/kibana/pull/208535","number":208535,"branch":"8.x","state":"OPEN"}]}] BACKPORT--> Co-authored-by: Nicolas Chaulet <nicolas.chaulet@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related to #208210
It seems we were consuming a significant amount of external memory (in particular for larger package like
security_detection_engine) due to a non optimal usage ofopenpgpto verify the package signature that PR should improve it.Benchmark
This compare the external memory consumption of two
security_detection_enginepackage installation one with that fix, one without. I run that test a few times with always the same resultI also ran that tests by changing the code to do 10 times the package verification and you can really see the difference
