Skip to content

[Asset inventory] Add initial cypress test#207647

Merged
opauloh merged 10 commits intoelastic:mainfrom
opauloh:fix_asset_inventory_privileges
Jan 27, 2025
Merged

[Asset inventory] Add initial cypress test#207647
opauloh merged 10 commits intoelastic:mainfrom
opauloh:fix_asset_inventory_privileges

Conversation

@opauloh
Copy link
Copy Markdown
Contributor

@opauloh opauloh commented Jan 22, 2025 •
edited
Loading

Summary

This PR introduces initial cypress test and also a basic test was configured to test for the presence of the Asset Inventory page when the Feature Flag assetInventoryUXEnabled is set.

@opauloh opauloh added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 Team:Cloud Security Cloud Security team related labels Jan 22, 2025
@opauloh opauloh requested review from a team as code owners January 22, 2025 03:52
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jan 22, 2025

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

@opauloh opauloh requested a review from rylnd January 22, 2025 03:52
@opauloh opauloh added the backport:skip This PR does not require backporting label Jan 22, 2025
@opauloh opauloh requested a review from albertoblaz January 22, 2025 03:54
albertoblaz
albertoblaz approved these changes Jan 22, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@albertoblaz albertoblaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice stuff!!

JordanSh
JordanSh approved these changes Jan 22, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@JordanSh JordanSh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch @opauloh 🧙‍♂️

@opauloh opauloh changed the title asset inventory page initial cypress test [Asset inventory] Add initial cypress test Jan 23, 2025
@opauloh
Copy link
Copy Markdown
Contributor Author

opauloh commented Jan 23, 2025 •
edited
Loading

Update: to speed up the review process I separated this PR into two: #207970 and #207647. This PR is now only about adding the initial cypress test

rylnd
rylnd approved these changes Jan 23, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@rylnd rylnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@opauloh opauloh enabled auto-merge (squash) January 27, 2025 15:07
@opauloh opauloh mentioned this pull request Jan 27, 2025
Merged
@opauloh opauloh merged commit c03313a into elastic:main Jan 27, 2025
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jan 27, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #20 / CustomFieldsForm renders text as default custom field type

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 21.3MB 21.3MB +36.0B

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxcold maxcold maxcold approved these changes

@cavokz cavokz cavokz approved these changes

@rylnd rylnd rylnd approved these changes

@albertoblaz albertoblaz albertoblaz approved these changes

@michaelolo24 michaelolo24 michaelolo24 approved these changes

@JordanSh JordanSh JordanSh approved these changes

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related v9.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@opauloh @elasticmachine @maxcold @cavokz @rylnd @albertoblaz @michaelolo24 @JordanSh