Prevent hiding of fields when clicking on an index twice#2072
Merged
w33ble merged 1 commit intoelastic:masterfrom Dec 2, 2014
Merged
Prevent hiding of fields when clicking on an index twice#2072w33ble merged 1 commit intoelastic:masterfrom
w33ble merged 1 commit intoelastic:masterfrom
Conversation
Contributor
|
Thanks for fixing a bug I introduced! 🍔 🐋 |
w33ble
added a commit
that referenced
this pull request
Dec 2, 2014
Prevent hiding of fields when clicking on an index twice
edmarmoretti
pushed a commit
to edmarmoretti/kibana-pt-br
that referenced
this pull request
Sep 7, 2025
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
nikitaindik
added a commit
to nikitaindik/kibana
that referenced
this pull request
Mar 3, 2026
Adds a maxSize constraint to the tags field in the prebuilt rule assets saved object schema to resolve CodeQL alert elastic#2072 (unbounded-array-in-schema). Made-with: Cursor
nikitaindik
added a commit
that referenced
this pull request
Mar 6, 2026
…ebuilt rule assets (#255741) **Resolves: https://github.com/elastic/kibana/security/code-scanning/2072** ## Summary Adds a `maxSize` constraint to the `tags` field in the `security-rule` saved object schema (`prebuilt_rule_assets_type.ts`), resolving [CodeQL alert #2072](https://github.com/elastic/kibana/security/code-scanning/2072) (unbounded-array-in-schema). - Introduced a `MAX_TAGS_PER_RULE` constant (100) to bound the `schema.arrayOf()` call - Prebuilt rules typically have fewer than 15 tags, so 100 is a generous safe limit - No model version bump needed since this is a validation-only change with no structural/mapping impact --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
kapral18
pushed a commit
to kapral18/kibana
that referenced
this pull request
Mar 9, 2026
…ebuilt rule assets (elastic#255741) **Resolves: https://github.com/elastic/kibana/security/code-scanning/2072** ## Summary Adds a `maxSize` constraint to the `tags` field in the `security-rule` saved object schema (`prebuilt_rule_assets_type.ts`), resolving [CodeQL alert elastic#2072](https://github.com/elastic/kibana/security/code-scanning/2072) (unbounded-array-in-schema). - Introduced a `MAX_TAGS_PER_RULE` constant (100) to bound the `schema.arrayOf()` call - Prebuilt rules typically have fewer than 15 tags, so 100 is a generous safe limit - No model version bump needed since this is a validation-only change with no structural/mapping impact --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
qn895
pushed a commit
to qn895/kibana
that referenced
this pull request
Mar 11, 2026
…ebuilt rule assets (elastic#255741) **Resolves: https://github.com/elastic/kibana/security/code-scanning/2072** ## Summary Adds a `maxSize` constraint to the `tags` field in the `security-rule` saved object schema (`prebuilt_rule_assets_type.ts`), resolving [CodeQL alert elastic#2072](https://github.com/elastic/kibana/security/code-scanning/2072) (unbounded-array-in-schema). - Introduced a `MAX_TAGS_PER_RULE` constant (100) to bound the `schema.arrayOf()` call - Prebuilt rules typically have fewer than 15 tags, so 100 is a generous safe limit - No model version bump needed since this is a validation-only change with no structural/mapping impact --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When managing index patterns, the URL it sends you to when you click on an index pattern does not specify the tab to show (fields or scripted fields). So, when the controller loads, it checks to see if a tab is specified in the URL, and if not, it selects the first tab by default. However, when you click on an index pattern that's already in view, the controller does not run again, so the selected tab is lost, so no tabs are shown.
This fix changes the controller to watch the tab specified in the URL, and any time the tab isn't specified, it selects the first tab.
Closes #2052.