[Rule Migration] Add PackageClient to fetch integrations#207197
Merged
P1llus merged 4 commits intoelastic:mainfrom Jan 21, 2025
Merged
[Rule Migration] Add PackageClient to fetch integrations#207197P1llus merged 4 commits intoelastic:mainfrom
P1llus merged 4 commits intoelastic:mainfrom
Conversation
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Contributor
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
P1llus
commented
Jan 20, 2025
...y_solution/server/lib/siem_migrations/rules/data/rule_migrations_data_integrations_client.ts
Show resolved
Hide resolved
janmonschke
approved these changes
Jan 20, 2025
P1llus
commented
Jan 20, 2025
...ugins/security_solution/server/lib/siem_migrations/rules/task/rule_migrations_task_client.ts
Outdated
Show resolved
Hide resolved
semd
reviewed
Jan 20, 2025
...y_solution/server/lib/siem_migrations/rules/data/rule_migrations_data_integrations_client.ts
Outdated
Show resolved
Hide resolved
semd
reviewed
Jan 20, 2025
...y_solution/server/lib/siem_migrations/rules/data/rule_migrations_data_integrations_client.ts
Show resolved
Hide resolved
semd
reviewed
Jan 20, 2025
...y_solution/server/lib/siem_migrations/rules/data/rule_migrations_data_integrations_client.ts
Outdated
Show resolved
Hide resolved
Contributor
💔 Build Failed
Failed CI StepsTest Failures
Metrics [docs]
History
cc @P1llus |
Contributor
|
Starting backport for target branches: 8.x |
Member
Author
|
Unsure why elasticmachine did not report it, but reran the flaky tests (not related to this PR) and it was successful in buildkite, github also reported all tests passing. |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 21, 2025
) ## Summary Awaiting the changes to the EPR API to include datasets we temporarily included a JSON file to simulate the expected outcome so we could move forward while waiting. Since the changes is now done, the calls to https://epr.elastic.co/search? now returns data_streams in their responses so this PR replaces the temp JSON with the proper PackageClient implementation. Tested a few migrations with both prebuilt rule matches and without, and seems to be working as intended. The integration count also seems to be consistent with what to be expected. (cherry picked from commit 1e5abbe)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 21, 2025
…) (#207391) # Backport This will backport the following commits from `main` to `8.x`: - [[Rule Migration] Add PackageClient to fetch integrations (#207197)](#207197) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Marius Iversen","email":"marius.iversen@elastic.co"},"sourceCommit":{"committedDate":"2025-01-21T15:46:44Z","message":"[Rule Migration] Add PackageClient to fetch integrations (#207197)\n\n## Summary\r\n\r\nAwaiting the changes to the EPR API to include datasets we temporarily\r\nincluded a JSON file to simulate the expected outcome so we could move\r\nforward while waiting.\r\n\r\nSince the changes is now done, the calls to\r\nhttps://epr.elastic.co/search? now returns data_streams in their\r\nresponses so this PR replaces the temp JSON with the proper\r\nPackageClient implementation.\r\n\r\nTested a few migrations with both prebuilt rule matches and without, and\r\nseems to be working as intended. The integration count also seems to be\r\nconsistent with what to be expected.","sha":"1e5abbe8eeb198a62b9ef43179db3124fc6c7a1b","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat Hunting","Team: SecuritySolution","backport:version","v8.18.0"],"title":"[Rule Migration] Add PackageClient to fetch integrations","number":207197,"url":"https://github.com/elastic/kibana/pull/207197","mergeCommit":{"message":"[Rule Migration] Add PackageClient to fetch integrations (#207197)\n\n## Summary\r\n\r\nAwaiting the changes to the EPR API to include datasets we temporarily\r\nincluded a JSON file to simulate the expected outcome so we could move\r\nforward while waiting.\r\n\r\nSince the changes is now done, the calls to\r\nhttps://epr.elastic.co/search? now returns data_streams in their\r\nresponses so this PR replaces the temp JSON with the proper\r\nPackageClient implementation.\r\n\r\nTested a few migrations with both prebuilt rule matches and without, and\r\nseems to be working as intended. The integration count also seems to be\r\nconsistent with what to be expected.","sha":"1e5abbe8eeb198a62b9ef43179db3124fc6c7a1b"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/207197","number":207197,"mergeCommit":{"message":"[Rule Migration] Add PackageClient to fetch integrations (#207197)\n\n## Summary\r\n\r\nAwaiting the changes to the EPR API to include datasets we temporarily\r\nincluded a JSON file to simulate the expected outcome so we could move\r\nforward while waiting.\r\n\r\nSince the changes is now done, the calls to\r\nhttps://epr.elastic.co/search? now returns data_streams in their\r\nresponses so this PR replaces the temp JSON with the proper\r\nPackageClient implementation.\r\n\r\nTested a few migrations with both prebuilt rule matches and without, and\r\nseems to be working as intended. The integration count also seems to be\r\nconsistent with what to be expected.","sha":"1e5abbe8eeb198a62b9ef43179db3124fc6c7a1b"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Marius Iversen <marius.iversen@elastic.co>
viduni94
pushed a commit
to viduni94/kibana
that referenced
this pull request
Jan 23, 2025
) ## Summary Awaiting the changes to the EPR API to include datasets we temporarily included a JSON file to simulate the expected outcome so we could move forward while waiting. Since the changes is now done, the calls to https://epr.elastic.co/search? now returns data_streams in their responses so this PR replaces the temp JSON with the proper PackageClient implementation. Tested a few migrations with both prebuilt rule matches and without, and seems to be working as intended. The integration count also seems to be consistent with what to be expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Awaiting the changes to the EPR API to include datasets we temporarily included a JSON file to simulate the expected outcome so we could move forward while waiting.
Since the changes is now done, the calls to https://epr.elastic.co/search? now returns data_streams in their responses so this PR replaces the temp JSON with the proper PackageClient implementation.
Tested a few migrations with both prebuilt rule matches and without, and seems to be working as intended. The integration count also seems to be consistent with what to be expected.