[dashboard] remove unused class dshDashboardViewportWrapper--isFullscreen#206991
Merged
nreese merged 1 commit intoelastic:mainfrom Jan 16, 2025
Merged
[dashboard] remove unused class dshDashboardViewportWrapper--isFullscreen#206991nreese merged 1 commit intoelastic:mainfrom
nreese merged 1 commit intoelastic:mainfrom
Conversation
Contributor
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
ThomThomson
approved these changes
Jan 16, 2025
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
|
Contributor
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 16, 2025
…reen (elastic#206991) elastic#205341 removed `dshDashboardViewportWrapper--isFullscreen` from "src/platform/plugins/shared/dashboard/public/dashboard_container/component/viewport/_dashboard_viewport.scss". The PR failed to remove the class from rendered DOM. (cherry picked from commit 47226c9)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 16, 2025
…Fullscreen (#206991) (#207003) # Backport This will backport the following commits from `main` to `8.x`: - [[dashboard] remove unused class dshDashboardViewportWrapper--isFullscreen (#206991)](#206991) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nathan Reese","email":"reese.nathan@elastic.co"},"sourceCommit":{"committedDate":"2025-01-16T19:52:16Z","message":"[dashboard] remove unused class dshDashboardViewportWrapper--isFullscreen (#206991)\n\nhttps://github.com//pull/205341 removed\r\n`dshDashboardViewportWrapper--isFullscreen` from\r\n\"src/platform/plugins/shared/dashboard/public/dashboard_container/component/viewport/_dashboard_viewport.scss\".\r\nThe PR failed to remove the class from rendered DOM.","sha":"47226c998682a2f04ce11ee6b4ab30d401bbd18f","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Presentation","release_note:skip","v9.0.0","backport:version","v8.18.0"],"title":"[dashboard] remove unused class dshDashboardViewportWrapper--isFullscreen","number":206991,"url":"https://github.com/elastic/kibana/pull/206991","mergeCommit":{"message":"[dashboard] remove unused class dshDashboardViewportWrapper--isFullscreen (#206991)\n\nhttps://github.com//pull/205341 removed\r\n`dshDashboardViewportWrapper--isFullscreen` from\r\n\"src/platform/plugins/shared/dashboard/public/dashboard_container/component/viewport/_dashboard_viewport.scss\".\r\nThe PR failed to remove the class from rendered DOM.","sha":"47226c998682a2f04ce11ee6b4ab30d401bbd18f"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/206991","number":206991,"mergeCommit":{"message":"[dashboard] remove unused class dshDashboardViewportWrapper--isFullscreen (#206991)\n\nhttps://github.com//pull/205341 removed\r\n`dshDashboardViewportWrapper--isFullscreen` from\r\n\"src/platform/plugins/shared/dashboard/public/dashboard_container/component/viewport/_dashboard_viewport.scss\".\r\nThe PR failed to remove the class from rendered DOM.","sha":"47226c998682a2f04ce11ee6b4ab30d401bbd18f"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Nathan Reese <reese.nathan@elastic.co>
viduni94
pushed a commit
to viduni94/kibana
that referenced
this pull request
Jan 23, 2025
…reen (elastic#206991) elastic#205341 removed `dshDashboardViewportWrapper--isFullscreen` from "src/platform/plugins/shared/dashboard/public/dashboard_container/component/viewport/_dashboard_viewport.scss". The PR failed to remove the class from rendered DOM.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#205341 removed
dshDashboardViewportWrapper--isFullscreenfrom "src/platform/plugins/shared/dashboard/public/dashboard_container/component/viewport/_dashboard_viewport.scss". The PR failed to remove the class from rendered DOM.