Skip to content

Fix telemetry CLI to write empty properties collection#205746

Merged
dokmic merged 1 commit intoelastic:mainfrom
dokmic:bugfix/telemetry-cli-fix
Jan 7, 2025
Merged

Fix telemetry CLI to write empty properties collection#205746
dokmic merged 1 commit intoelastic:mainfrom
dokmic:bugfix/telemetry-cli-fix

Conversation

@dokmic
Copy link
Copy Markdown
Contributor

@dokmic dokmic commented Jan 7, 2025

Summary

Follow-up of #205613. Remove check blocking empty properties from writing.

@dokmic dokmic requested a review from a team as a code owner January 7, 2025 14:12
@dokmic dokmic added Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// v9.0.0 backport:version Backport to applied version labels v8.18.0 labels Jan 7, 2025
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-core (Team:Core)

@dokmic dokmic added the release_note:skip Skip the PR/issue when compiling release notes label Jan 7, 2025
@dokmic dokmic enabled auto-merge (squash) January 7, 2025 16:23
Copy link
Copy Markdown
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dokmic dokmic merged commit aa8195c into elastic:main Jan 7, 2025
@kibanamachine
Copy link
Copy Markdown
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12655551314

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 7, 2025
Follow-up of elastic#205613. Remove check blocking empty properties from
writing.

(cherry picked from commit aa8195c)
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jan 7, 2025
#205786)

# Backport

This will backport the following commits from `main` to `8.x`:
- [Fix telemetry CLI to write empty properties collection
(#205746)](#205746)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Michael
Dokolin","email":"mikhail.dokolin@elastic.co"},"sourceCommit":{"committedDate":"2025-01-07T16:46:43Z","message":"Fix
telemetry CLI to write empty properties collection
(#205746)\n\nFollow-up of #205613. Remove check blocking empty
properties
from\nwriting.","sha":"aa8195ced450bf97145fa27cadd3e6b8c922487f","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","v9.0.0","backport:version","v8.18.0"],"title":"Fix
telemetry CLI to write empty properties
collection","number":205746,"url":"https://github.com/elastic/kibana/pull/205746","mergeCommit":{"message":"Fix
telemetry CLI to write empty properties collection
(#205746)\n\nFollow-up of #205613. Remove check blocking empty
properties
from\nwriting.","sha":"aa8195ced450bf97145fa27cadd3e6b8c922487f"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205746","number":205746,"mergeCommit":{"message":"Fix
telemetry CLI to write empty properties collection
(#205746)\n\nFollow-up of #205613. Remove check blocking empty
properties
from\nwriting.","sha":"aa8195ced450bf97145fa27cadd3e6b8c922487f"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Michael Dokolin <mikhail.dokolin@elastic.co>
@dokmic dokmic deleted the bugfix/telemetry-cli-fix branch January 7, 2025 19:52
viduni94 pushed a commit to viduni94/kibana that referenced this pull request Jan 23, 2025
Follow-up of elastic#205613. Remove check blocking empty properties from
writing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// v8.18.0 v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants