[Cloud Security] Feature Flag Support for Cloud Security Posture Plugin#205438

Merged

Omolola-Akinleye merged 13 commits intoelastic:mainfrom

Omolola-Akinleye:register_feature_flag_csp_plugin

Jan 10, 2025

Contributor

Omolola-Akinleye commented Jan 2, 2025 •

edited by kibanamachine

Loading

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Changes

Adds enableExperimental to server configSchema
Makes feature flags configurable via xpack.cloudSecurityPosture.enableExperimental in kibana.dev.yml
Implements ExperimentFeatureService.get() for accessing feature flags
Add passing initliaterContext to plugin in order to access our plugin config

Benefits

Avoids circular dependency with Security Solution useIsExperimentalFeatureEnabled and prop drilling feature flags from Fleet plugin PackagePolicyReplaceDefineStepExtensionComponentProps
Provides server-side configuration support
Enables pre-release feature testing
Creates centralized feature flag management

This allows controlled testing of new features before release through configuration rather than code changes.


          register enableExperimental feature flags to the cloud security plugin

fd2aaff

Omolola-Akinleye added enhancement Team:Cloud Security v8.18.0 labels

Omolola-Akinleye self-assigned this

Omolola-Akinleye requested a review from a team as a code owner

January 2, 2025 20:25

Contributor

elasticmachine commented Jan 2, 2025

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

Omolola-Akinleye added backport:prev-minor release_note:enhancement labels


          update import

a146bdf

seanrathier approved these changes

View reviewed changes

Contributor

seanrathier left a comment

This is going to be useful, thanks!


          use type import and fix type build error

5d17703

Contributor Author

Omolola-Akinleye commented Jan 6, 2025

@elasticmachine merge upstream

elasticmachine and others added 4 commits

January 6, 2025 18:22


          Merge branch 'main' into register_feature_flag_csp_plugin

9fab149


          fix types

930f0c7


          Merge branch 'register_feature_flag_csp_plugin' of github.com:Omolola…

0e8fa5d

…-Akinleye/kibana into register_feature_flag_csp_plugin


          fix the build step for the page load bundle size

860ce32

Omolola-Akinleye requested a review from a team as a code owner

January 6, 2025 19:33

jbudz approved these changes

View reviewed changes

Contributor

jbudz left a comment

packages/kbn-optimizer/limits.yml LGTM


          Merge branch 'main' into register_feature_flag_csp_plugin

08c688c

Omolola-Akinleye added the v9.0.0 label

Omolola-Akinleye added 3 commits

January 7, 2025 10:42


          fix broken config setting ftr test

657a83a


          Merge remote-tracking branch 'upstream/main' into register_feature_fl…

12a472b

…ag_csp_plugin


          Merge branch 'register_feature_flag_csp_plugin' of github.com:Omolola…

2b0be45

…-Akinleye/kibana into register_feature_flag_csp_plugin

Omolola-Akinleye requested a review from a team as a code owner

January 7, 2025 15:49

jeramysoucy approved these changes

View reviewed changes

Contributor

jeramysoucy left a comment

Kibana Security changes LGTM

maxcold previously requested changes

View reviewed changes

Contributor

maxcold left a comment

pls check the bundle size increase

packages/kbn-optimizer/limits.yml Outdated

                 cloudFullStory: 18493
                 cloudLinks: 55984
-                cloudSecurityPosture: 19109
+                cloudSecurityPosture: 34398

Contributor

maxcold Jan 9, 2025

why this increase in the bundle size? almost 80% percent increase in my opinion signals that smth is off

Contributor Author

Omolola-Akinleye Jan 9, 2025

Thanks @maxcold! I ran the script node scripts/build_kibana_platform_plugins --focus {pluginId} --update-limits to increase the bundle size which automatically add 15kb to currentSize. I will just manually update the limits.yml

Contributor

maxcold Jan 10, 2025

ah, I see, the actual change is +1kb. I am still not sure where it is coming from but it is not a big issue I guess

Omolola-Akinleye added 2 commits

January 9, 2025 13:17


          manually update limit.yml

a253de8


          Merge branch 'main' into register_feature_flag_csp_plugin

f23fdc3

Omolola-Akinleye requested a review from maxcold

January 9, 2025 21:39

Contributor

kibanamachine commented Jan 14, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 205438 locally

Contributor

jbudz commented Jan 14, 2025

@Omolola-Akinleye the backport can be retried by toggling backport:prev-minor if this hasn't already been backported. The rate limit issues should be resolved now.

Contributor

kibanamachine commented Jan 15, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 205438 locally

5 similar comments

Contributor

kibanamachine commented Jan 16, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 205438 locally

Contributor

kibanamachine commented Jan 17, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 205438 locally

Contributor

kibanamachine commented Jan 20, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 205438 locally

Contributor

kibanamachine commented Jan 21, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 205438 locally

Contributor

kibanamachine commented Jan 22, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 205438 locally

viduni94 pushed a commit to viduni94/kibana that referenced this pull request


          [Cloud Security] Feature Flag Support for Cloud Security Posture Plug…

e3760cd

…in (elastic#205438)

## Summary

Summarize your PR. If it involves visual changes include a screenshot or
gif.

## Changes

* Adds `enableExperimental` to server `configSchema`
* Makes feature flags configurable via
`xpack.cloudSecurityPosture.enableExperimental` in `kibana.dev.yml`
* Implements `ExperimentFeatureService.get()` for accessing feature
flags
* Add passing `initliaterContext` to plugin in order to access our
plugin config

## Benefits

* Avoids circular dependency with Security Solution
`useIsExperimentalFeatureEnabled` and prop drilling feature flags from
Fleet plugin `PackagePolicyReplaceDefineStepExtensionComponentProps`
* Provides server-side configuration support
* Enables pre-release feature testing
* Creates centralized feature flag management

This allows controlled testing of new features before release through
configuration rather than code changes.

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Contributor

kibanamachine commented Jan 23, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 205438 locally

4 similar comments

Contributor

kibanamachine commented Jan 24, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 205438 locally

Contributor

kibanamachine commented Jan 27, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 205438 locally

Contributor

kibanamachine commented Jan 28, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 205438 locally

Contributor

kibanamachine commented Jan 29, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 205438 locally

Contributor

opauloh commented Jan 30, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet. To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label. You can also create backports manually by running node scripts/backport --pr 205438 locally

cc @Omolola-Akinleye

Contributor

kibanamachine commented Jan 31, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 205438 locally

8 similar comments

Contributor

kibanamachine commented Feb 3, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 205438 locally

Contributor

kibanamachine commented Feb 4, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 205438 locally

Contributor

kibanamachine commented Feb 5, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 205438 locally

Contributor

kibanamachine commented Feb 6, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 205438 locally

Contributor

kibanamachine commented Feb 7, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 205438 locally

Contributor

kibanamachine commented Feb 10, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 205438 locally

Contributor

kibanamachine commented Feb 11, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 205438 locally

Contributor

kibanamachine commented Feb 12, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 205438 locally

opauloh added release_note:skip backport:skip and removed release_note:enhancement backport missing backport:prev-minor labels

kibanamachine mentioned this pull request

chore(NA): upgrade to webpack 5 #191106

Merged

39 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip enhancement release_note:skip Team:Cloud Security v8.18.0 v9.0.0