[Security Solution][THI] - remove obsolete timelineEsqlTabDisabled feature flag#205175
Merged
PhilippeOberti merged 2 commits intoelastic:mainfrom Jan 11, 2025
Merged
Conversation
Contributor
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
9370bf8 to
01cabfe
Compare
kqualters-elastic
approved these changes
Jan 10, 2025
stephmilovic
approved these changes
Jan 10, 2025
Contributor
|
Starting backport for target branches: 8.x |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Page load bundle
History
|
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 11, 2025
…ature flag (elastic#205175) ## Summary This PR removes the `timelineEsqlTabDisabled` feature flag that was introduced a long time ago and has been in `disabled: false` state for many months. I noticed that the line was moved in [this PR](elastic#176064) over 6 months ago but the introduction of the feature precedes that. No UI changes introduced! (cherry picked from commit 3d6f452)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 11, 2025
…led feature flag (#205175) (#206364) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution][THI] - remove obsolete timelineEsqlTabDisabled feature flag (#205175)](#205175) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Philippe Oberti","email":"philippe.oberti@elastic.co"},"sourceCommit":{"committedDate":"2025-01-11T00:14:19Z","message":"[Security Solution][THI] - remove obsolete timelineEsqlTabDisabled feature flag (#205175)\n\n## Summary\r\n\r\nThis PR removes the `timelineEsqlTabDisabled` feature flag that was\r\nintroduced a long time ago and has been in `disabled: false` state for\r\nmany months.\r\nI noticed that the line was moved in [this\r\nPR](#176064) over 6 months ago but\r\nthe introduction of the feature precedes that.\r\n\r\nNo UI changes introduced!","sha":"3d6f45292f794b10449c96a1446517490ce8168e","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat Hunting:Investigations","backport:version","v8.18.0"],"title":"[Security Solution][THI] - remove obsolete timelineEsqlTabDisabled feature flag","number":205175,"url":"https://github.com/elastic/kibana/pull/205175","mergeCommit":{"message":"[Security Solution][THI] - remove obsolete timelineEsqlTabDisabled feature flag (#205175)\n\n## Summary\r\n\r\nThis PR removes the `timelineEsqlTabDisabled` feature flag that was\r\nintroduced a long time ago and has been in `disabled: false` state for\r\nmany months.\r\nI noticed that the line was moved in [this\r\nPR](#176064) over 6 months ago but\r\nthe introduction of the feature precedes that.\r\n\r\nNo UI changes introduced!","sha":"3d6f45292f794b10449c96a1446517490ce8168e"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205175","number":205175,"mergeCommit":{"message":"[Security Solution][THI] - remove obsolete timelineEsqlTabDisabled feature flag (#205175)\n\n## Summary\r\n\r\nThis PR removes the `timelineEsqlTabDisabled` feature flag that was\r\nintroduced a long time ago and has been in `disabled: false` state for\r\nmany months.\r\nI noticed that the line was moved in [this\r\nPR](#176064) over 6 months ago but\r\nthe introduction of the feature precedes that.\r\n\r\nNo UI changes introduced!","sha":"3d6f45292f794b10449c96a1446517490ce8168e"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Philippe Oberti <philippe.oberti@elastic.co>
viduni94
pushed a commit
to viduni94/kibana
that referenced
this pull request
Jan 23, 2025
…ature flag (elastic#205175) ## Summary This PR removes the `timelineEsqlTabDisabled` feature flag that was introduced a long time ago and has been in `disabled: false` state for many months. I noticed that the line was moved in [this PR](elastic#176064) over 6 months ago but the introduction of the feature precedes that. No UI changes introduced!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the
timelineEsqlTabDisabledfeature flag that was introduced a long time ago and has been indisabled: falsestate for many months.I noticed that the line was moved in this PR over 6 months ago but the introduction of the feature precedes that.
No UI changes introduced!