Skip to content

Sustainable Kibana Architecture: Move plugins owned by @elastic/appex-sharedux#204959

Merged
Dosant merged 56 commits intoelastic:mainfrom
Dosant:kbn-team-1309-relocate-20241219135219
Jan 3, 2025
Merged

Sustainable Kibana Architecture: Move plugins owned by @elastic/appex-sharedux#204959
Dosant merged 56 commits intoelastic:mainfrom
Dosant:kbn-team-1309-relocate-20241219135219

Conversation

@Dosant
Copy link
Copy Markdown
Contributor

@Dosant Dosant commented Dec 19, 2024

Summary

Part of #203163

Relocating only shared-ux-owned plugins for now . Tip on how to review changes if GitHub UI is unmanageable - https://elastic.slack.com/archives/C07TCKTA22E/p1734606026689389

node scripts/relocate.js --include "@kbn/advanced-settings-plugin" --include "@kbn/banners-plugin" --include "@kbn/content-management-plugin" --include "@kbn/custom-branding-plugin" --include "@kbn/files-management-plugin" --include "@kbn/files-plugin" --include "@kbn/global-search-bar-plugin" --include "@kbn/global-search-plugin" --include "@kbn/global-search-providers-plugin" --include "@kbn/guided-onboarding-plugin" --include "@kbn/home-plugin" --include "@kbn/image-embeddable-plugin" --include "@kbn/kibana-overview-plugin" --include "@kbn/kibana-react-plugin" --include "@kbn/kibana-utils-plugin" --include "@kbn/navigation-plugin" --include "@kbn/no-data-page-plugin" --include "@kbn/notifications-plugin" --include "@kbn/reporting-plugin" --include "@kbn/saved-objects-plugin" --include "@kbn/saved-objects-tagging-oss-plugin" --include "@kbn/saved-objects-tagging-plugin" --include "@kbn/screenshot-mode-plugin" --include "@kbn/serverless" --include "@kbn/share-plugin" --include --include "@kbn/ui-actions-enhanced-plugin" --include "@kbn/ui-actions-plugin"
  ┌─────────────────────────────────────────┬───────────────────────────────────────────────────────────┐
  │  Id                                     │  Target folder                                            │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/content-management-plugin         │  src/platform/plugins/shared/content_management           │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/custom-branding-plugin            │  x-pack/platform/plugins/private/custom_branding          │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/files-management-plugin           │  src/platform/plugins/private/files_management            │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/files-plugin                      │  src/platform/plugins/shared/files                        │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/global-search-bar-plugin          │  x-pack/platform/plugins/private/global_search_bar        │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/global-search-plugin              │  x-pack/platform/plugins/shared/global_search             │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/global-search-providers-plugin    │  x-pack/platform/plugins/private/global_search_providers  │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/guided-onboarding-plugin          │  src/platform/plugins/shared/guided_onboarding            │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/home-plugin                       │  src/platform/plugins/shared/home                         │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/image-embeddable-plugin           │  src/platform/plugins/private/image_embeddable            │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/kibana-overview-plugin            │  src/platform/plugins/private/kibana_overview             │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/kibana-react-plugin               │  src/platform/plugins/shared/kibana_react                 │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/kibana-utils-plugin               │  src/platform/plugins/shared/kibana_utils                 │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/navigation-plugin                 │  src/platform/plugins/shared/navigation                   │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/no-data-page-plugin               │  src/platform/plugins/private/no_data_page                │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/notifications-plugin              │  x-pack/platform/plugins/shared/notifications             │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/reporting-plugin                  │  x-pack/platform/plugins/private/reporting                │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/saved-objects-plugin              │  src/platform/plugins/shared/saved_objects                │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/saved-objects-tagging-oss-plugin  │  src/platform/plugins/shared/saved_objects_tagging_oss    │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/saved-objects-tagging-plugin      │  x-pack/platform/plugins/private/saved_objects_tagging    │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/screenshot-mode-plugin            │  src/platform/plugins/shared/screenshot_mode              │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/serverless                        │  x-pack/platform/plugins/shared/serverless                │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/share-plugin                      │  src/platform/plugins/shared/share                        │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/ui-actions-enhanced-plugin        │  src/platform/plugins/shared/ui_actions_enhanced          │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/ui-actions-plugin                 │  src/platform/plugins/shared/ui_actions                   │
  └─────────────────────────────────────────┴───────────────────────────────────────────────────────────┘

@github-actions
Copy link
Copy Markdown
Contributor

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@Dosant Dosant changed the title Kbn team 1309 relocate 20241219135219 Sustainable Kibana Architecture: Move plugins owned by @elastic/appex-sharedux Dec 19, 2024
@Dosant Dosant added release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Platform AppEx-SharedUX (formerly Global Experience) t// backport:prev-minor labels Dec 19, 2024
@Dosant Dosant removed the request for review from ashokaditya January 2, 2025 16:21
@Dosant
Copy link
Copy Markdown
Contributor Author

Dosant commented Jan 2, 2025

@elasticmachine merge upstream

@elasticmachine
Copy link
Copy Markdown
Contributor

merge conflict between base and head

@Dosant Dosant enabled auto-merge (squash) January 3, 2025 11:37
@Dosant Dosant merged commit 9215df9 into elastic:main Jan 3, 2025
@kibanamachine
Copy link
Copy Markdown
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12597145645

@elasticmachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #71 / Cloud Security Posture Test adding Cloud Security Posture Integrations CSPM AWS CIS_AWS Organization Cloud Formation Clicking on Launch CloudFormation on post intall modal should lead user to Cloud Formation page

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
kibanaReact 197.1KB 197.1KB -12.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kibanaReact 37.3KB 36.9KB -410.0B

History

@kibanamachine
Copy link
Copy Markdown
Contributor

💔 All backports failed

Status Branch Result
8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 204959

Questions ?

Please refer to the Backport tool documentation

@Dosant
Copy link
Copy Markdown
Contributor Author

Dosant commented Jan 3, 2025

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

Dosant added a commit to Dosant/kibana that referenced this pull request Jan 3, 2025
…x-sharedux` (elastic#204959)

## Summary

Part of elastic#203163

Relocating only shared-ux-owned plugins for now

(cherry picked from commit 9215df9)

# Conflicts:
#	.github/CODEOWNERS
#	.i18nrc.json
#	docs/developer/plugin-list.asciidoc
#	package.json
#	src/platform/plugins/shared/saved_objects/tsconfig.json
#	x-pack/.gitignore
#	x-pack/.i18nrc.json
#	x-pack/platform/plugins/private/reporting/.gitignore
#	x-pack/platform/plugins/private/reporting/server/config/index.test.ts
#	x-pack/platform/plugins/private/reporting/server/deprecations/__snapshots__/reporting_role.test.ts.snap
#	x-pack/platform/plugins/private/reporting/server/deprecations/reporting_role.test.ts
#	x-pack/platform/plugins/private/reporting/server/deprecations/reporting_role.ts
#	x-pack/platform/plugins/private/reporting/server/routes/internal/generate/csv_searchsource_immediate.ts
Dosant added a commit that referenced this pull request Jan 5, 2025
…c/appex-sharedux` (#204959) (#205508)

# Backport

This will backport the following commits from `main` to `8.x`:
- [Sustainable Kibana Architecture: Move plugins owned by
`@elastic/appex-sharedux`
(#204959)](#204959)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Anton
Dosov","email":"anton.dosov@elastic.co"},"sourceCommit":{"committedDate":"2025-01-03T11:38:57Z","message":"Sustainable
Kibana Architecture: Move plugins owned by `@elastic/appex-sharedux`
(#204959)\n\n## Summary\r\n\r\nPart of
https://github.com/elastic/kibana/pull/203163\r\n\r\nRelocating only
shared-ux-owned plugins for
now","sha":"9215df9200edac72f2225760043ac45c9e82cdf0","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:SharedUX","backport:prev-minor","plugin
groups"],"number":204959,"url":"https://github.com/elastic/kibana/pull/204959","mergeCommit":{"message":"Sustainable
Kibana Architecture: Move plugins owned by `@elastic/appex-sharedux`
(#204959)\n\n## Summary\r\n\r\nPart of
https://github.com/elastic/kibana/pull/203163\r\n\r\nRelocating only
shared-ux-owned plugins for
now","sha":"9215df9200edac72f2225760043ac45c9e82cdf0"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204959","number":204959,"mergeCommit":{"message":"Sustainable
Kibana Architecture: Move plugins owned by `@elastic/appex-sharedux`
(#204959)\n\n## Summary\r\n\r\nPart of
https://github.com/elastic/kibana/pull/203163\r\n\r\nRelocating only
shared-ux-owned plugins for
now","sha":"9215df9200edac72f2225760043ac45c9e82cdf0"}}]}] BACKPORT-->

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Timothy Sullivan <tsullivan@elastic.co>
dokmic added a commit that referenced this pull request Jan 6, 2025
After merging #202748, #204959, and #201653, all of the properties in
some telemetry schemas were moved completely, but `node
scripts/telemetry_check --fix` didn't update the `properties` object
correctly.

Also, in #202748 and #201653, the relocation script changed some paths,
confusing them with `@kbn/security-plugin` and `@kbn/cloud-plugin`.
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 6, 2025
…#205613)

After merging elastic#202748, elastic#204959, and elastic#201653, all of the properties in
some telemetry schemas were moved completely, but `node
scripts/telemetry_check --fix` didn't update the `properties` object
correctly.

Also, in elastic#202748 and elastic#201653, the relocation script changed some paths,
confusing them with `@kbn/security-plugin` and `@kbn/cloud-plugin`.

(cherry picked from commit 5409631)
kibanamachine added a commit that referenced this pull request Jan 6, 2025
…205613) (#205641)

# Backport

This will backport the following commits from `main` to `8.x`:
- [Sustainable Kibana Architecture: Fix after-relocation issues
(#205613)](#205613)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Michael
Dokolin","email":"mikhail.dokolin@elastic.co"},"sourceCommit":{"committedDate":"2025-01-06T18:02:36Z","message":"Sustainable
Kibana Architecture: Fix after-relocation issues (#205613)\n\nAfter
merging #202748, #204959, and #201653, all of the properties in\nsome
telemetry schemas were moved completely, but
`node\nscripts/telemetry_check --fix` didn't update the `properties`
object\ncorrectly.\n\nAlso, in #202748 and #201653, the relocation
script changed some paths,\nconfusing them with `@kbn/security-plugin`
and
`@kbn/cloud-plugin`.","sha":"540963148dc671b02655ced8285dbbd817d9d5c9","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","v9.0.0","backport:version","v8.18.0","plugin
groups"],"title":"Sustainable Kibana Architecture: Fix after-relocation
issues","number":205613,"url":"https://github.com/elastic/kibana/pull/205613","mergeCommit":{"message":"Sustainable
Kibana Architecture: Fix after-relocation issues (#205613)\n\nAfter
merging #202748, #204959, and #201653, all of the properties in\nsome
telemetry schemas were moved completely, but
`node\nscripts/telemetry_check --fix` didn't update the `properties`
object\ncorrectly.\n\nAlso, in #202748 and #201653, the relocation
script changed some paths,\nconfusing them with `@kbn/security-plugin`
and
`@kbn/cloud-plugin`.","sha":"540963148dc671b02655ced8285dbbd817d9d5c9"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205613","number":205613,"mergeCommit":{"message":"Sustainable
Kibana Architecture: Fix after-relocation issues (#205613)\n\nAfter
merging #202748, #204959, and #201653, all of the properties in\nsome
telemetry schemas were moved completely, but
`node\nscripts/telemetry_check --fix` didn't update the `properties`
object\ncorrectly.\n\nAlso, in #202748 and #201653, the relocation
script changed some paths,\nconfusing them with `@kbn/security-plugin`
and
`@kbn/cloud-plugin`.","sha":"540963148dc671b02655ced8285dbbd817d9d5c9"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Michael Dokolin <mikhail.dokolin@elastic.co>
viduni94 pushed a commit to viduni94/kibana that referenced this pull request Jan 23, 2025
…x-sharedux` (elastic#204959)

## Summary

Part of elastic#203163

Relocating only shared-ux-owned plugins for now
viduni94 pushed a commit to viduni94/kibana that referenced this pull request Jan 23, 2025
…#205613)

After merging elastic#202748, elastic#204959, and elastic#201653, all of the properties in
some telemetry schemas were moved completely, but `node
scripts/telemetry_check --fix` didn't update the `properties` object
correctly.

Also, in elastic#202748 and elastic#201653, the relocation script changed some paths,
confusing them with `@kbn/security-plugin` and `@kbn/cloud-plugin`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin groups Relocate all plugins and packages under their respective platform/solution groups release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Platform AppEx-SharedUX (formerly Global Experience) t// v8.18.0 v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.