[Cloud Security] Move @kbn/cloud-security-posture-storybook-config for Kibana sustainability #204500
Merged
kfirpeled merged 4 commits intoelastic:mainfrom Dec 18, 2024
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
Ikuni17
reviewed
Dec 17, 2024
Contributor
Ikuni17
left a comment
There was a problem hiding this comment.
I started a build with the storybooks label to double check we're good.
Contributor
Author
Thanks @Ikuni17, I was not aware of that label. |
Contributor
Author
|
/ci |
kfirpeled
approved these changes
Dec 17, 2024
Contributor
kfirpeled
left a comment
There was a problem hiding this comment.
lgtm
thanks @seanrathier
1 task
Contributor
Author
|
@Ikuni17 here is the build with the storybook label I am curious about where the Storybook is published/uploaded. |
Contributor
💚 Build Succeeded
Metrics [docs]
History
cc @seanrathier |
Contributor
|
@seanrathier checkout the last build comment You have a reference to it |
8 tasks
Ikuni17
approved these changes
Dec 17, 2024
Contributor
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 18, 2024
…r Kibana sustainability (elastic#204500) ## Summary Move @kbn/cloud-security-posture-storybook-config package to `x-pack/solutions/security/packages/kbn-cloud-security-posture/.storybook` Renamed removed the `config` folder to align with the `.storybook` [naming convention](https://github.com/elastic/kibana/pull/204500/files#diff-91918a63f6365a8f40f674ab54a8df7ce9aeb313f77fe8eda76284d712ef5425R21).  ### Related Issues - elastic#202862 --------- Co-authored-by: Brad White <Ikuni17@users.noreply.github.com> (cherry picked from commit d6cb398)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 18, 2024
…fig for Kibana sustainability (#204500) (#204736) # Backport This will backport the following commits from `main` to `8.x`: - [[Cloud Security] Move @kbn/cloud-security-posture-storybook-config for Kibana sustainability (#204500)](#204500) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"seanrathier","email":"sean.rathier@gmail.com"},"sourceCommit":{"committedDate":"2024-12-18T12:09:38Z","message":"[Cloud Security] Move @kbn/cloud-security-posture-storybook-config for Kibana sustainability (#204500)\n\n## Summary\r\n\r\nMove @kbn/cloud-security-posture-storybook-config package to\r\n`x-pack/solutions/security/packages/kbn-cloud-security-posture/.storybook`\r\n\r\nRenamed removed the `config` folder to align with the `.storybook`\r\n[naming\r\nconvention](https://github.com/elastic/kibana/pull/204500/files#diff-91918a63f6365a8f40f674ab54a8df7ce9aeb313f77fe8eda76284d712ef5425R21).\r\n\r\n\r\n\r\n### Related Issues\r\n- https://github.com/elastic/kibana/pull/202862\r\n\r\n---------\r\n\r\nCo-authored-by: Brad White <Ikuni17@users.noreply.github.com>","sha":"d6cb398d1ab09af93369e84f0aa13f0688357082","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Cloud Security","backport:prev-minor","ci:build-storybooks"],"title":"[Cloud Security] Move @kbn/cloud-security-posture-storybook-config for Kibana sustainability ","number":204500,"url":"https://github.com/elastic/kibana/pull/204500","mergeCommit":{"message":"[Cloud Security] Move @kbn/cloud-security-posture-storybook-config for Kibana sustainability (#204500)\n\n## Summary\r\n\r\nMove @kbn/cloud-security-posture-storybook-config package to\r\n`x-pack/solutions/security/packages/kbn-cloud-security-posture/.storybook`\r\n\r\nRenamed removed the `config` folder to align with the `.storybook`\r\n[naming\r\nconvention](https://github.com/elastic/kibana/pull/204500/files#diff-91918a63f6365a8f40f674ab54a8df7ce9aeb313f77fe8eda76284d712ef5425R21).\r\n\r\n\r\n\r\n### Related Issues\r\n- https://github.com/elastic/kibana/pull/202862\r\n\r\n---------\r\n\r\nCo-authored-by: Brad White <Ikuni17@users.noreply.github.com>","sha":"d6cb398d1ab09af93369e84f0aa13f0688357082"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204500","number":204500,"mergeCommit":{"message":"[Cloud Security] Move @kbn/cloud-security-posture-storybook-config for Kibana sustainability (#204500)\n\n## Summary\r\n\r\nMove @kbn/cloud-security-posture-storybook-config package to\r\n`x-pack/solutions/security/packages/kbn-cloud-security-posture/.storybook`\r\n\r\nRenamed removed the `config` folder to align with the `.storybook`\r\n[naming\r\nconvention](https://github.com/elastic/kibana/pull/204500/files#diff-91918a63f6365a8f40f674ab54a8df7ce9aeb313f77fe8eda76284d712ef5425R21).\r\n\r\n\r\n\r\n### Related Issues\r\n- https://github.com/elastic/kibana/pull/202862\r\n\r\n---------\r\n\r\nCo-authored-by: Brad White <Ikuni17@users.noreply.github.com>","sha":"d6cb398d1ab09af93369e84f0aa13f0688357082"}}]}] BACKPORT--> Co-authored-by: seanrathier <sean.rathier@gmail.com>
JoseLuisGJ
pushed a commit
to JoseLuisGJ/kibana
that referenced
this pull request
Dec 19, 2024
…r Kibana sustainability (elastic#204500) ## Summary Move @kbn/cloud-security-posture-storybook-config package to `x-pack/solutions/security/packages/kbn-cloud-security-posture/.storybook` Renamed removed the `config` folder to align with the `.storybook` [naming convention](https://github.com/elastic/kibana/pull/204500/files#diff-91918a63f6365a8f40f674ab54a8df7ce9aeb313f77fe8eda76284d712ef5425R21).  ### Related Issues - elastic#202862 --------- Co-authored-by: Brad White <Ikuni17@users.noreply.github.com>
benakansara
pushed a commit
to benakansara/kibana
that referenced
this pull request
Jan 2, 2025
…r Kibana sustainability (elastic#204500) ## Summary Move @kbn/cloud-security-posture-storybook-config package to `x-pack/solutions/security/packages/kbn-cloud-security-posture/.storybook` Renamed removed the `config` folder to align with the `.storybook` [naming convention](https://github.com/elastic/kibana/pull/204500/files#diff-91918a63f6365a8f40f674ab54a8df7ce9aeb313f77fe8eda76284d712ef5425R21).  ### Related Issues - elastic#202862 --------- Co-authored-by: Brad White <Ikuni17@users.noreply.github.com>
viduni94
pushed a commit
to viduni94/kibana
that referenced
this pull request
Jan 23, 2025
…r Kibana sustainability (elastic#204500) ## Summary Move @kbn/cloud-security-posture-storybook-config package to `x-pack/solutions/security/packages/kbn-cloud-security-posture/.storybook` Renamed removed the `config` folder to align with the `.storybook` [naming convention](https://github.com/elastic/kibana/pull/204500/files#diff-91918a63f6365a8f40f674ab54a8df7ce9aeb313f77fe8eda76284d712ef5425R21).  ### Related Issues - elastic#202862 --------- Co-authored-by: Brad White <Ikuni17@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move @kbn/cloud-security-posture-storybook-config package to
x-pack/solutions/security/packages/kbn-cloud-security-posture/.storybookRenamed removed the
configfolder to align with the.storybooknaming convention.Related Issues
@elastic/kibana-cloud-security-posture#202862