Skip to content

[8.16] [Security Solution] Disable Install All button when installation is in progress (#201731)#201961

Merged
kibanamachine merged 1 commit intoelastic:8.16from
kibanamachine:backport/8.16/pr-201731
Nov 27, 2024
Merged

[8.16] [Security Solution] Disable Install All button when installation is in progress (#201731)#201961
kibanamachine merged 1 commit intoelastic:8.16from
kibanamachine:backport/8.16/pr-201731

Conversation

@kibanamachine
Copy link
Copy Markdown
Contributor

Backport

This will backport the following commits from main to 8.16:

Questions ?

Please refer to the Backport tool documentation

…n progress (elastic#201731)

**Resolves: elastic#180660**

## Summary

In this PR I am fixing a problem of the `Install All` button being
re-enabled when entering the page again.
I am fixing only the UI problem here, only for the scenario described in
the ticket: single user interacting with single instance of Kibana.
During investigation I discovered and discussed with the team other
scenarios which may lead to race condition when installing rules, but
the team agreed to work on them separately.

The fix uses `useIsMutating` hook to check that the mutation is pending.
Such information is added to the `AddPrebuiltRulesTableContext` and then
used to disable the `Install All` button in the component.

Recording:

https://github.com/user-attachments/assets/777dd6a5-2441-4101-8368-04cdcede1409

### Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [X] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7483
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7484

(cherry picked from commit 9ca719c)
@kibanamachine kibanamachine added the backport This PR is a backport of another PR label Nov 27, 2024
@kibanamachine kibanamachine enabled auto-merge (squash) November 27, 2024 12:19
@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 20.2MB 20.2MB +180.0B

cc @jkelas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants