Spike for unusual test timeout for fleet#201443
Spike for unusual test timeout for fleet#201443eokoneyo wants to merge 2 commits intoelastic:mainfrom
Conversation
|
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
There was a problem hiding this comment.
There's no need to wrap fireEvent in act
There was a problem hiding this comment.
We shouldn't be cleaning up just before test starts, what's more with jest this is handled automatically for us
There was a problem hiding this comment.
Also there's no need to render here, if we still invoke render again in each test suite
There was a problem hiding this comment.
there's no need to have assertions run within an act function
1392385 to
fde6dad
Compare
|
|
||
| import React from 'react'; | ||
|
|
||
| import { act, fireEvent } from '@testing-library/react'; |
There was a problem hiding this comment.
removing instances of act wrapped around fireEvent shaved some seconds off the test running time here;
with act
## with waitFor
|
|
||
| describe('RootPrivilegesCallout', () => { | ||
| function render(rootIntegrations?: Array<{ name: string; title: string }>) { | ||
| cleanup(); |
There was a problem hiding this comment.
yields from from removing this:
| if (!deleteRowEl) { | ||
| throw new Error('Delete row button not found'); | ||
| } |
There was a problem hiding this comment.
This should actually be an assertion
| if (deleteRowButtons.length !== 3) { | ||
| throw new Error('Delete row buttons not found'); | ||
| } |
There was a problem hiding this comment.
This could be an assertion
|
This has been picked up, in the PR referenced to this particular one |
## Summary Changes in elastic#201443 with some tweaks Closes elastic#201210 Closes elastic#200786 Closes elastic#191804 Closes elastic#199204
Summary
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesIdentify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.