[Discover] Remove the legacy table by jughosta · Pull Request #201254 · elastic/kibana

jughosta · 2024-11-21T17:33:11Z

Closes [Discover] Remove legacy/classic table #167582

Summary

This PR removes the code related to the legacy doc table and 2 Advanced Settings: doc_table:legacy and truncate:maxHeight.

The legacy table in Discover was replaced by the new data grid in v8.3. The doc_table:legacy Advanced Setting was added to let users switch back to the legacy table if necessary. The removal of the setting and the legacy table entirely would allow us to reduce bundle size, maintenance burden, and code complexity.

Also the legacy table does not support many new features which were added to the grid only (e.g. comparing selected documents, context-aware UI based on current solution project, column resizing, bulk row selection, copy actions, new doc viewer flyout, and more).

Since v8.15 doc_table:legacy is marked as deprecated on Advanced Settings page via #179899

Since v8.16 truncate:maxHeight is marked as deprecated too via #183736

The removal of these 2 settings and the associated code is planned for v9.

Checklist

Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.

github-actions · 2024-11-21T17:33:26Z

A documentation preview will be available soon.

🔨 Buildkite builds
📚 HTML diff
📙 Preview page

Request a new doc build by commenting

Rebuild this PR: run docs-build
Rebuild this PR and all Elastic docs: run docs-build rebuild

_{run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.}

_{If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.}

… 167582-remove-legacy-table

jughosta · 2024-11-26T09:05:33Z

src/plugins/kibana_usage_collection/server/collectors/management/schema.ts

Is it safe to remove them from the schema?

jughosta · 2024-11-26T09:05:56Z

src/plugins/kibana_usage_collection/server/collectors/management/types.ts

Is it safe to remove them from this types?

jughosta · 2024-11-26T09:06:30Z

src/plugins/telemetry/schema/oss_plugins.json

Is it safe to remove them from this schema?

Yes... this schema is for informational purposes, and it doesn't directly apply to mappings.

The idea was that the telemetry dictionary would tell us when it was removed. But we never managed to fully build that internal feature 😅

elasticmachine · 2024-11-26T10:01:15Z

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

sabarasaba

kibana management changes lgtm

Dosant

packages/kbn-management/settings/setting_ids/index.ts lgtm! :)

pheyos

Functional test service changes for data_grid and doc_table LGTM

jbudz

.buildkite/ftr_platform_stateful_configs.yml

jgowdyelastic

ML changes LGTM

nreese

kibana-presentation changes LGTM
code review only

afharo

Core changes LGTM

afharo · 2024-11-26T17:24:56Z

src/plugins/telemetry/schema/oss_plugins.json

Yes... this schema is for informational purposes, and it doesn't directly apply to mappings.

The idea was that the telemetry dictionary would tell us when it was removed. But we never managed to fully build that internal feature 😅

davismcphee

It's beautiful 🥹

I tested locally and it's working as expected -- no more legacy doc table and no noticeable differences in Discover. Thanks for removing this and LGTM, it's so nice to be able to drop all this tech debt 🤘

kertal · 2024-12-02T06:34:24Z

@elasticmachine merge upstream

l-suarez

Looks as expected. Thanks!

elasticmachine · 2024-12-03T10:55:23Z

💛 Build succeeded, but was flaky

Failed CI Steps

FTR Configs #61

Test Failures

[job] [logs] FTR Configs #61 / Observability Rules Synthetics SyntheticsCustomStatusRule "after all" hook in "SyntheticsCustomStatusRule"

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`apm`	1923	1922	-1
`canvas`	1293	1292	-1
`cloudSecurityPosture`	661	660	-1
`discover`	983	941	-42
`esqlDataGrid`	370	369	-1
`eventAnnotationListing`	593	592	-1
`lens`	1519	1518	-1
`logsExplorer`	570	569	-1
`logsShared`	363	362	-1
`observability`	1074	1073	-1
`searchPlayground`	271	270	-1
`securitySolution`	6310	6309	-1
`slo`	857	856	-1
`unifiedDocViewer`	225	216	-9
`unifiedHistogram`	193	192	-1
total			-64

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/discover-utils`	234	227	-7
`@kbn/management-settings-ids`	139	137	-2
total			-9

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`aiops`	613.9KB	613.9KB	-41.0B
`discover`	812.9KB	784.8KB	-28.1KB
`unifiedDocViewer`	126.0KB	115.8KB	-10.3KB
total			-38.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`discover`	51.1KB	44.1KB	-7.1KB
`unifiedDocViewer`	12.3KB	11.8KB	-482.0B
total			-7.5KB

Unknown metric groups

API count

id	before	after	diff
`@kbn/discover-utils`	284	277	-7
`@kbn/management-settings-ids`	140	138	-2
total			-9

async chunk count

id	before	after	diff
`unifiedDocViewer`	10	8	-2

ESLint disabled line counts

id	before	after	diff
`discover`	24	18	-6
`unifiedDocViewer`	9	8	-1
total			-7

References to deprecated APIs

id	before	after	diff
`discover`	9	8	-1

Total ESLint disabled count

id	before	after	diff
`discover`	26	20	-6
`unifiedDocViewer`	9	8	-1
total			-7

History

💛 Build #255797 was flaky 228aa03
💚 Build #255290 succeeded e4d601a
💛 Build #254976 was flaky 6a667af
💛 Build #254856 was flaky 94d2ab7
💛 Build #254233 was flaky 66b3f56
💔 Build #254040 failed 189a62d

cc @jughosta

- Closes elastic#167582 ## Summary This PR removes the code related to the legacy doc table and 2 Advanced Settings: `doc_table:legacy` and `truncate:maxHeight`. The legacy table in Discover was replaced by the new data grid in v8.3. The `doc_table:legacy` Advanced Setting was added to let users switch back to the legacy table if necessary. The removal of the setting and the legacy table entirely would allow us to reduce bundle size, maintenance burden, and code complexity. Also the legacy table does not support many new features which were added to the grid only (e.g. comparing selected documents, context-aware UI based on current solution project, column resizing, bulk row selection, copy actions, new doc viewer flyout, and more). Since v8.15 `doc_table:legacy` is marked as deprecated on Advanced Settings page via elastic#179899 Since v8.16 `truncate:maxHeight` is marked as deprecated too via elastic#183736 The removal of these 2 settings and the associated code is planned for v9. ### Checklist - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

[Discover] Initial clean up

7274d1e

jughosta added release_note:deprecation backport:skip This PR does not require backporting Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// labels Nov 21, 2024

jughosta self-assigned this Nov 21, 2024

jughosta and others added 17 commits November 21, 2024 18:52

[Discover] Clean up translations

c5c8d21

[Discover] Remove the reference

b47faca

[Discover] Update tests

cf59379

[Discover] Remove legacy view from DocViewer

041c9de

[Discover] Clean up

0074895

[Discover] Exclude legacy tests

24ff08a

[Discover] Remove from context

e9c99e0

[Discover] Remove from embeddable

4118f7c

[Discover] Clean up

b5dc7aa

Merge branch 'main' into 167582-remove-legacy-table

2a79fb3

[Discover] Remove legacy view from Discover main page

4d06178

[Discover] Clean up tests

7eebf07

[Discover] Clean up translations

dcc82bc

[Discover] Clean up more

e4f1e41

[CI] Auto-commit changed files from 'node scripts/notice'

02720b3

[Discover] Clean up more

724e35b

Merge remote-tracking branch 'origin/167582-remove-legacy-table' into…

189a62d

… 167582-remove-legacy-table

jughosta added release_note:breaking and removed release_note:deprecation labels Nov 25, 2024

jughosta added 2 commits November 25, 2024 15:51

[Discover] Clean up more

910113e

Merge branch 'main' into 167582-remove-legacy-table

66b3f56

jughosta commented Nov 26, 2024

View reviewed changes

jughosta requested review from a team as code owners November 26, 2024 10:01

sabarasaba approved these changes Nov 26, 2024

View reviewed changes

Dosant approved these changes Nov 26, 2024

View reviewed changes

kertal added the Feature:Discover Discover Application label Nov 26, 2024

pheyos approved these changes Nov 26, 2024

View reviewed changes

jbudz approved these changes Nov 26, 2024

View reviewed changes

jgowdyelastic approved these changes Nov 26, 2024

View reviewed changes

nreese approved these changes Nov 26, 2024

View reviewed changes

afharo approved these changes Nov 26, 2024

View reviewed changes

jughosta added 3 commits November 27, 2024 11:49

Merge branch 'main' into 167582-remove-legacy-table

94d2ab7

Merge branch 'main' into 167582-remove-legacy-table

a1c48c9

[Discover] Remove new references

6a667af

davismcphee approved these changes Nov 28, 2024

View reviewed changes

kertal requested a review from l-suarez November 28, 2024 07:42

Merge branch 'main' into 167582-remove-legacy-table

e4d601a

jughosta mentioned this pull request Nov 28, 2024

[Discover] Remove discover:searchFieldsFromSource setting TMP jughosta/kibana#13

Closed

10 tasks

Merge branch 'main' into 167582-remove-legacy-table

228aa03

l-suarez approved these changes Dec 2, 2024

View reviewed changes

jughosta added 2 commits December 3, 2024 10:10

Merge with main

f900727

[Discover] Remove new occurrences

a3ce399

jughosta merged commit 14bdd8d into elastic:main Dec 3, 2024

kibanamachine added the v9.0.0 label Dec 3, 2024

Conversation

jughosta commented Nov 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

github-actions bot commented Nov 21, 2024

Uh oh!

jughosta Nov 26, 2024

Choose a reason for hiding this comment

Uh oh!

jughosta Nov 26, 2024

Choose a reason for hiding this comment

Uh oh!

jughosta Nov 26, 2024

Choose a reason for hiding this comment

Uh oh!

afharo Nov 26, 2024

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Nov 26, 2024

Uh oh!

sabarasaba left a comment

Choose a reason for hiding this comment

Uh oh!

Dosant left a comment

Choose a reason for hiding this comment

Uh oh!

pheyos left a comment

Choose a reason for hiding this comment

Uh oh!

jbudz left a comment

Choose a reason for hiding this comment

Uh oh!

jgowdyelastic left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nreese left a comment

Choose a reason for hiding this comment

Uh oh!

afharo left a comment

Choose a reason for hiding this comment

Uh oh!

afharo Nov 26, 2024

Choose a reason for hiding this comment

Uh oh!

davismcphee left a comment

Choose a reason for hiding this comment

Uh oh!

kertal commented Dec 2, 2024

Uh oh!

l-suarez left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Dec 3, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Page load bundle

API count

async chunk count

ESLint disabled line counts

References to deprecated APIs

Total ESLint disabled count

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

jughosta commented Nov 21, 2024 •

edited

Loading

jgowdyelastic left a comment •

edited

Loading

l-suarez left a comment •

edited

Loading