[ResponseOps][Connectors]Possible to open close incident in ServiceNow#199989
Merged
georgianaonoleata1904 merged 6 commits intoelastic:mainfrom Nov 19, 2024
Merged
Conversation
Contributor
|
Pinging @elastic/response-ops (Team:ResponseOps) |
cnasikas
approved these changes
Nov 18, 2024
x-pack/plugins/stack_connectors/server/connector_types/lib/servicenow/service.test.ts
Outdated
Show resolved
Hide resolved
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
Contributor
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 19, 2024
elastic#199989) Closes elastic#184646 ## Summary - updated the code to include additional validation, ensuring that updateIncident({...}) is not called when incidentToBeClosed object is empty, this ensured that cases where getIncident or getIncidentByCorrelationId return an empty object are properly handled. - small change in Run connector flyout > configuration tab: fixed typo, "read-only" instead of "readonly" (cherry picked from commit 5d77a1a)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
1 similar comment
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
kibanamachine
added a commit
that referenced
this pull request
Nov 26, 2024
…viceNow (#199989) (#200726) # Backport This will backport the following commits from `main` to `8.x`: - [[ResponseOps][Connectors]Possible to open close incident in ServiceNow (#199989)](#199989) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Georgiana-Andreea Onoleață","email":"georgiana.onoleata@elastic.co"},"sourceCommit":{"committedDate":"2024-11-19T12:48:30Z","message":"[ResponseOps][Connectors]Possible to open close incident in ServiceNow (#199989)\n\nCloses https://github.com/elastic/kibana/issues/184646\r\n\r\n## Summary\r\n\r\n- updated the code to include additional validation, ensuring that\r\nupdateIncident({...}) is not called when incidentToBeClosed object is\r\nempty, this ensured that cases where getIncident or\r\ngetIncidentByCorrelationId return an empty object are properly handled.\r\n\r\n- small change in Run connector flyout > configuration tab: fixed typo,\r\n\"read-only\" instead of \"readonly\"","sha":"5d77a1a67c5eb243b14ea0613e411cc13ec73406","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:ResponseOps","v9.0.0","backport:prev-minor","v8.17.0"],"title":"[ResponseOps][Connectors]Possible to open close incident in ServiceNow","number":199989,"url":"https://github.com/elastic/kibana/pull/199989","mergeCommit":{"message":"[ResponseOps][Connectors]Possible to open close incident in ServiceNow (#199989)\n\nCloses https://github.com/elastic/kibana/issues/184646\r\n\r\n## Summary\r\n\r\n- updated the code to include additional validation, ensuring that\r\nupdateIncident({...}) is not called when incidentToBeClosed object is\r\nempty, this ensured that cases where getIncident or\r\ngetIncidentByCorrelationId return an empty object are properly handled.\r\n\r\n- small change in Run connector flyout > configuration tab: fixed typo,\r\n\"read-only\" instead of \"readonly\"","sha":"5d77a1a67c5eb243b14ea0613e411cc13ec73406"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199989","number":199989,"mergeCommit":{"message":"[ResponseOps][Connectors]Possible to open close incident in ServiceNow (#199989)\n\nCloses https://github.com/elastic/kibana/issues/184646\r\n\r\n## Summary\r\n\r\n- updated the code to include additional validation, ensuring that\r\nupdateIncident({...}) is not called when incidentToBeClosed object is\r\nempty, this ensured that cases where getIncident or\r\ngetIncidentByCorrelationId return an empty object are properly handled.\r\n\r\n- small change in Run connector flyout > configuration tab: fixed typo,\r\n\"read-only\" instead of \"readonly\"","sha":"5d77a1a67c5eb243b14ea0613e411cc13ec73406"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Georgiana-Andreea Onoleață <georgiana.onoleata@elastic.co>
paulinashakirova
pushed a commit
to paulinashakirova/kibana
that referenced
this pull request
Nov 26, 2024
elastic#199989) Closes elastic#184646 ## Summary - updated the code to include additional validation, ensuring that updateIncident({...}) is not called when incidentToBeClosed object is empty, this ensured that cases where getIncident or getIncidentByCorrelationId return an empty object are properly handled. - small change in Run connector flyout > configuration tab: fixed typo, "read-only" instead of "readonly"
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
elastic#199989) Closes elastic#184646 ## Summary - updated the code to include additional validation, ensuring that updateIncident({...}) is not called when incidentToBeClosed object is empty, this ensured that cases where getIncident or getIncidentByCorrelationId return an empty object are properly handled. - small change in Run connector flyout > configuration tab: fixed typo, "read-only" instead of "readonly"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #184646
Summary
updated the code to include additional validation, ensuring that updateIncident({...}) is not called when incidentToBeClosed object is empty, this ensured that cases where getIncident or getIncidentByCorrelationId return an empty object are properly handled.
small change in Run connector flyout > configuration tab: fixed typo, "read-only" instead of "readonly"