Changed log level for message with authz opt out#199678
Changed log level for message with authz opt out#199678elena-shostak merged 3 commits intoelastic:mainfrom
Conversation
|
Pinging @elastic/kibana-security (Team:Security) |
TinaHeiligers
left a comment
There was a problem hiding this comment.
Using debug level will prevent spamming the logs by default.
Thank you!
LGTM
| if (security) { | ||
| if (isAuthzDisabled(security.authz)) { | ||
| logger.warn( | ||
| logger.debug( |
There was a problem hiding this comment.
question: Is there any value in this log entry at all? I mean, we already have HTTP logs if we want to know which endpoint is being called, and if we want to check whether this endpoint has authorization enabled or disabled, we just need to know the Kibana version, since the definition is mostly static and set in the code.
If, for some reason, we want to keep this as a debug log, it would make sense to remove the request.url.search part, as it’s not relevant to the authorization decision (it's essentially based on path) and might potentially contain sensitive data that we don’t want to record in logs.
There was a problem hiding this comment.
tbh I think we are okay to delete it, don't see any issues with that, we are just generating additional noise with it
💔 Build Failed
Failed CI StepsTest Failures
Metrics [docs]
History
|
|
@elasticmachine merge upstream |
|
Starting backport for target branches: 8.x |
## Summary Changed log level for message with authz opt out from `warn` to `debug` __Closes: https://github.com/elastic/kibana/issues/199677__ (cherry picked from commit 9bb3661)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
…9772) # Backport This will backport the following commits from `main` to `8.x`: - [Changed log level for message with authz opt out (#199678)](#199678) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Elena Shostak","email":"165678770+elena-shostak@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-11-12T12:05:56Z","message":"Changed log level for message with authz opt out (#199678)\n\n## Summary\r\n\r\nChanged log level for message with authz opt out from `warn` to `debug`\r\n\r\n\r\n__Closes: https://github.com/elastic/kibana/issues/199677__","sha":"9bb3661060e01628a052e34bd471ecea0b428fa7","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Security","release_note:skip","Feature:Security/Authorization","v9.0.0","backport:prev-minor"],"title":"Changed log level for message with authz opt out","number":199678,"url":"https://github.com/elastic/kibana/pull/199678","mergeCommit":{"message":"Changed log level for message with authz opt out (#199678)\n\n## Summary\r\n\r\nChanged log level for message with authz opt out from `warn` to `debug`\r\n\r\n\r\n__Closes: https://github.com/elastic/kibana/issues/199677__","sha":"9bb3661060e01628a052e34bd471ecea0b428fa7"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199678","number":199678,"mergeCommit":{"message":"Changed log level for message with authz opt out (#199678)\n\n## Summary\r\n\r\nChanged log level for message with authz opt out from `warn` to `debug`\r\n\r\n\r\n__Closes: https://github.com/elastic/kibana/issues/199677__","sha":"9bb3661060e01628a052e34bd471ecea0b428fa7"}}]}] BACKPORT--> Co-authored-by: Elena Shostak <165678770+elena-shostak@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
## Summary Changed log level for message with authz opt out from `warn` to `debug` __Closes: https://github.com/elastic/kibana/issues/199677__
Summary
Changed log level for message with authz opt out from
warntodebugCloses: #199677