Closed
Conversation
Contributor
|
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
4 tasks
walterra
added a commit
that referenced
this pull request
Jan 29, 2026
## Summary Follow up to #246209. Implements elastic/kibana-team#2391. Also implements part of elastic/kibana-team#2179. This applies the work done in PoCs #199632 and #245716 to the new UI flow with the conversion modal added in #246209. This PR wires up the ES|QL conversion modal to actually perform the datasource conversion. Related to that, it also cleans up the inline editing flyout code by removing redundant props. - `handleConvertToEsql` callback to switch flyout from formBased to textBased mode - Updates visualization state to remap column IDs (xAccessor, accessors, splitAccessor) to ES|QL field names - Reduces prop drilling of `datasourceId` and `canEditTextBasedQuery`, adds `hideTextBasedEditor` to Redux state for Discover integration. Note: The full feature is still behind a dev-mode flag, it's not enabled in production. The scope of this PR is to enable the full UI flow of DSL->ES|QL conversion and enabling the conversion based on wether the button to convert is enabled. Out of scope of the PR is fine tuning actual conversions, we'll pick that up in follow-ups. https://github.com/user-attachments/assets/d545c759-417b-4705-a820-bc669ca17ae2 ### To test that the conversion button isn't showing up in production builds: ``` # local kibana build node scripts/build --skip-os-packages --skip-docker-contexts # create ./build/default/kibana-9.4.0-SNAPSHOT-darwin-aarch64/config/kibana.yml elasticsearch.hosts: - https://localhost:9200/ elasticsearch.password: **** elasticsearch.username: kibana_system # run kibana ./build/default/kibana-9.4.0-SNAPSHOT-darwin-aarch64/bin/kibana --elasticsearch.ssl.verificationMode=none ``` ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. - [x] Used `cursor-cli` with `opus-4.5` to refactor the PoCs onto the new UI flow. --------- Co-authored-by: Stratou <efstratia.kalafateli@elastic.co>
hannahbrooks
pushed a commit
to hannahbrooks/kibana
that referenced
this pull request
Jan 30, 2026
## Summary Follow up to elastic#246209. Implements elastic/kibana-team#2391. Also implements part of elastic/kibana-team#2179. This applies the work done in PoCs elastic#199632 and elastic#245716 to the new UI flow with the conversion modal added in elastic#246209. This PR wires up the ES|QL conversion modal to actually perform the datasource conversion. Related to that, it also cleans up the inline editing flyout code by removing redundant props. - `handleConvertToEsql` callback to switch flyout from formBased to textBased mode - Updates visualization state to remap column IDs (xAccessor, accessors, splitAccessor) to ES|QL field names - Reduces prop drilling of `datasourceId` and `canEditTextBasedQuery`, adds `hideTextBasedEditor` to Redux state for Discover integration. Note: The full feature is still behind a dev-mode flag, it's not enabled in production. The scope of this PR is to enable the full UI flow of DSL->ES|QL conversion and enabling the conversion based on wether the button to convert is enabled. Out of scope of the PR is fine tuning actual conversions, we'll pick that up in follow-ups. https://github.com/user-attachments/assets/d545c759-417b-4705-a820-bc669ca17ae2 ### To test that the conversion button isn't showing up in production builds: ``` # local kibana build node scripts/build --skip-os-packages --skip-docker-contexts # create ./build/default/kibana-9.4.0-SNAPSHOT-darwin-aarch64/config/kibana.yml elasticsearch.hosts: - https://localhost:9200/ elasticsearch.password: **** elasticsearch.username: kibana_system # run kibana ./build/default/kibana-9.4.0-SNAPSHOT-darwin-aarch64/bin/kibana --elasticsearch.ssl.verificationMode=none ``` ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. - [x] Used `cursor-cli` with `opus-4.5` to refactor the PoCs onto the new UI flow. --------- Co-authored-by: Stratou <efstratia.kalafateli@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PoC of how editing esql in lens could look like:
Things that are not implemented in this PoC: