Skip to content

[Custom threshold] Fix the custom equation label on the preview lens chart#199618

Merged
maryam-saeidi merged 2 commits intoelastic:mainfrom
maryam-saeidi:181876-fix-equation-label
Nov 12, 2024
Merged

[Custom threshold] Fix the custom equation label on the preview lens chart#199618
maryam-saeidi merged 2 commits intoelastic:mainfrom
maryam-saeidi:181876-fix-equation-label

Conversation

@maryam-saeidi
Copy link
Copy Markdown
Member

@maryam-saeidi maryam-saeidi commented Nov 11, 2024

Fixes #181876

Summary

This PR fixes the custom equation label on the preview lens chart.

With label Without label With group by field
image image image

@maryam-saeidi maryam-saeidi added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor labels Nov 11, 2024
@maryam-saeidi maryam-saeidi self-assigned this Nov 11, 2024
@maryam-saeidi maryam-saeidi requested a review from a team as a code owner November 11, 2024 11:17
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. labels Nov 11, 2024
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@github-actions
Copy link
Copy Markdown
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Copy Markdown
Contributor

@benakansara benakansara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Nov 12, 2024

💚 Build Succeeded

  • Buildkite Build
  • Commit: 4973d14
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-199618-4973d140507e

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 471.2KB 471.3KB +20.0B

History

cc @maryam-saeidi

@maryam-saeidi maryam-saeidi merged commit 8668757 into elastic:main Nov 12, 2024
@maryam-saeidi maryam-saeidi deleted the 181876-fix-equation-label branch November 12, 2024 12:01
@kibanamachine
Copy link
Copy Markdown
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11796811441

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 12, 2024
… lens chart (#199618) (#199770)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Custom threshold] Fix the custom equation label on the preview lens
chart (#199618)](#199618)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Maryam
Saeidi","email":"maryam.saeidi@elastic.co"},"sourceCommit":{"committedDate":"2024-11-12T12:01:36Z","message":"[Custom
threshold] Fix the custom equation label on the preview lens chart
(#199618)\n\nFixes #181876\r\n\r\n## Summary\r\n\r\nThis PR fixes the
custom equation label on the preview lens chart.\r\n\r\n|With
label|Without label|With group by
field|\r\n|---|---|---|\r\n\r\n|![image](https://github.com/user-attachments/assets/b4f1a1e7-8e67-4b24-ae48-379fe393f90a)|![image](https://github.com/user-attachments/assets/3ef2733f-9ce8-4b37-8ecf-c19c1371aced)|![image](https://github.com/user-attachments/assets/d638f49e-98e2-4df7-8852-84dc62b9f739)|","sha":"8668757459feca8b5792662d2dacd07b0bf94e74","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-management"],"title":"[Custom
threshold] Fix the custom equation label on the preview lens
chart","number":199618,"url":"https://github.com/elastic/kibana/pull/199618","mergeCommit":{"message":"[Custom
threshold] Fix the custom equation label on the preview lens chart
(#199618)\n\nFixes #181876\r\n\r\n## Summary\r\n\r\nThis PR fixes the
custom equation label on the preview lens chart.\r\n\r\n|With
label|Without label|With group by
field|\r\n|---|---|---|\r\n\r\n|![image](https://github.com/user-attachments/assets/b4f1a1e7-8e67-4b24-ae48-379fe393f90a)|![image](https://github.com/user-attachments/assets/3ef2733f-9ce8-4b37-8ecf-c19c1371aced)|![image](https://github.com/user-attachments/assets/d638f49e-98e2-4df7-8852-84dc62b9f739)|","sha":"8668757459feca8b5792662d2dacd07b0bf94e74"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199618","number":199618,"mergeCommit":{"message":"[Custom
threshold] Fix the custom equation label on the preview lens chart
(#199618)\n\nFixes #181876\r\n\r\n## Summary\r\n\r\nThis PR fixes the
custom equation label on the preview lens chart.\r\n\r\n|With
label|Without label|With group by
field|\r\n|---|---|---|\r\n\r\n|![image](https://github.com/user-attachments/assets/b4f1a1e7-8e67-4b24-ae48-379fe393f90a)|![image](https://github.com/user-attachments/assets/3ef2733f-9ce8-4b37-8ecf-c19c1371aced)|![image](https://github.com/user-attachments/assets/d638f49e-98e2-4df7-8852-84dc62b9f739)|","sha":"8668757459feca8b5792662d2dacd07b0bf94e74"}}]}]
BACKPORT-->

Co-authored-by: Maryam Saeidi <maryam.saeidi@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. v8.17.0 v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Custom threshold] Equation label is not used in the preview chart tooltip

4 participants