Skip to content

[Fleet] Added default index pattern creation to stream-based installation#199122

Merged
xcrzx merged 1 commit intoelastic:mainfrom
xcrzx:fix-default-index-patterns
Nov 7, 2024
Merged

[Fleet] Added default index pattern creation to stream-based installation#199122
xcrzx merged 1 commit intoelastic:mainfrom
xcrzx:fix-default-index-patterns

Conversation

@xcrzx
Copy link
Copy Markdown
Contributor

@xcrzx xcrzx commented Nov 6, 2024

Related to: #195888

Summary

Add default index pattern creation to the new stream-based package installation method to match the behavior of standard package installation.

Switching to stream-based package installation resulted in the default index patterns not being created, even after installing the rules package. While this likely doesn’t affect production, as multiple integrations are usually installed in Kibana (creating the default index pattern in any case), this change has impacted some tests: #199030. So restoring the original behaviour

Copy link
Copy Markdown
Contributor

@PhilippeOberti PhilippeOberti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this PR. The change fixes our Threat Hunting Investigations Cypress tests that started failing right after this PR was merged

@xcrzx xcrzx marked this pull request as ready for review November 6, 2024 16:18
@xcrzx xcrzx requested review from a team as code owners November 6, 2024 16:18
@xcrzx xcrzx self-assigned this Nov 6, 2024
@xcrzx xcrzx added Team:Fleet Team label for Observability Data Collection Fleet team v9.0.0 v8.17.0 labels Nov 6, 2024
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/fleet (Team:Fleet)

@xcrzx xcrzx added release_note:skip Skip the PR/issue when compiling release notes backport:version Backport to applied version labels labels Nov 6, 2024
Copy link
Copy Markdown
Contributor

@PhilippeOberti PhilippeOberti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for unskipping our test, left a super minor comment on removing the obsolete comment

Copy link
Copy Markdown
Contributor

@PhilippeOberti PhilippeOberti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the Threat Hunting Investigations team. Thanks for fixing this and unskipping our tests!!

Copy link
Copy Markdown
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

  • 💚 Build #248832 succeeded 35860cb9e9c41d0104e2d13a63b9e150df3f2cef
  • 💔 Build #248801 failed e96f27bd6a413945fc9e5ca923142782007a8bc1

cc @xcrzx

@xcrzx xcrzx merged commit 22d3e62 into elastic:main Nov 7, 2024
@kibanamachine
Copy link
Copy Markdown
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11719795899

@kibanamachine
Copy link
Copy Markdown
Contributor

💔 All backports failed

Status Branch Result
8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 199122

Questions ?

Please refer to the Backport tool documentation

@xcrzx
Copy link
Copy Markdown
Contributor Author

xcrzx commented Nov 8, 2024

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

mbondyra pushed a commit to mbondyra/kibana that referenced this pull request Nov 8, 2024
…tion (elastic#199122)

**Related to: elastic#195888

## Summary

Add default index pattern creation to the new stream-based package
installation method to match the behavior of standard package
installation.

Switching to stream-based package installation resulted in the default
index patterns not being created, even after installing the rules
package. While this likely doesn’t affect production, as multiple
integrations are usually installed in Kibana (creating the default index
pattern in any case), this change has impacted some tests:
elastic#199030. So restoring the original
behaviour
xcrzx pushed a commit that referenced this pull request Nov 8, 2024
…stallation (#199122) (#199453)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Fleet] Added default index pattern creation to stream-based
installation (#199122)](#199122)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dmitrii
Shevchenko","email":"dmitrii.shevchenko@elastic.co"},"sourceCommit":{"committedDate":"2024-11-07T09:04:56Z","message":"[Fleet]
Added default index pattern creation to stream-based installation
(#199122)\n\n**Related to:
https://github.com/elastic/kibana/pull/195888**\r\n\r\n##
Summary\r\n\r\nAdd default index pattern creation to the new
stream-based package\r\ninstallation method to match the behavior of
standard package\r\ninstallation.\r\n\r\nSwitching to stream-based
package installation resulted in the default\r\nindex patterns not being
created, even after installing the rules\r\npackage. While this likely
doesn’t affect production, as multiple\r\nintegrations are usually
installed in Kibana (creating the default index\r\npattern in any case),
this change has impacted some
tests:\r\nhttps://github.com//pull/199030. So restoring
the
original\r\nbehaviour","sha":"22d3e628931706dee4c0d8eec068575d264bb13e","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","backport:version","v8.17.0"],"number":199122,"url":"https://github.com/elastic/kibana/pull/199122","mergeCommit":{"message":"[Fleet]
Added default index pattern creation to stream-based installation
(#199122)\n\n**Related to:
https://github.com/elastic/kibana/pull/195888**\r\n\r\n##
Summary\r\n\r\nAdd default index pattern creation to the new
stream-based package\r\ninstallation method to match the behavior of
standard package\r\ninstallation.\r\n\r\nSwitching to stream-based
package installation resulted in the default\r\nindex patterns not being
created, even after installing the rules\r\npackage. While this likely
doesn’t affect production, as multiple\r\nintegrations are usually
installed in Kibana (creating the default index\r\npattern in any case),
this change has impacted some
tests:\r\nhttps://github.com//pull/199030. So restoring
the
original\r\nbehaviour","sha":"22d3e628931706dee4c0d8eec068575d264bb13e"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199122","number":199122,"mergeCommit":{"message":"[Fleet]
Added default index pattern creation to stream-based installation
(#199122)\n\n**Related to:
https://github.com/elastic/kibana/pull/195888**\r\n\r\n##
Summary\r\n\r\nAdd default index pattern creation to the new
stream-based package\r\ninstallation method to match the behavior of
standard package\r\ninstallation.\r\n\r\nSwitching to stream-based
package installation resulted in the default\r\nindex patterns not being
created, even after installing the rules\r\npackage. While this likely
doesn’t affect production, as multiple\r\nintegrations are usually
installed in Kibana (creating the default index\r\npattern in any case),
this change has impacted some
tests:\r\nhttps://github.com//pull/199030. So restoring
the
original\r\nbehaviour","sha":"22d3e628931706dee4c0d8eec068575d264bb13e"}},{"branch":"8.x","label":"v8.17.0","labelRegex":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
@xcrzx xcrzx deleted the fix-default-index-patterns branch November 8, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.17.0 v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants