[Obs AI Assistant] Remove the copy button if there is no content to copy#199064
Merged
viduni94 merged 3 commits intoelastic:mainfrom Nov 12, 2024
Merged
[Obs AI Assistant] Remove the copy button if there is no content to copy#199064viduni94 merged 3 commits intoelastic:mainfrom
viduni94 merged 3 commits intoelastic:mainfrom
Conversation
Contributor
|
Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant) |
9e7df43 to
1c4e54f
Compare
dgieselaar
approved these changes
Nov 8, 2024
1c4e54f to
906e6bb
Compare
Samiul-TheSoccerFan
approved these changes
Nov 12, 2024
Contributor
Samiul-TheSoccerFan
left a comment
There was a problem hiding this comment.
LGTM, code reviews only
906e6bb to
315dd49
Compare
315dd49 to
5488566
Compare
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
cc @viduni94 |
Contributor
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 12, 2024
…opy (elastic#199064) Closes elastic#196986 ## Summary ### Problem The copy button for a visualization does nothing, as there's no content to copy. When clicked on this button, a message is shown saying "Copied Message", but nothing is copied. ### Solution Remove the copy button, when there's no content to copy. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit a613277)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
3 tasks
kibanamachine
added a commit
that referenced
this pull request
Nov 12, 2024
…t to copy (#199064) (#199874) # Backport This will backport the following commits from `main` to `8.x`: - [[Obs AI Assistant] Remove the copy button if there is no content to copy (#199064)](#199064) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Viduni Wickramarachchi","email":"viduni.wickramarachchi@elastic.co"},"sourceCommit":{"committedDate":"2024-11-12T19:41:47Z","message":"[Obs AI Assistant] Remove the copy button if there is no content to copy (#199064)\n\nCloses https://github.com/elastic/kibana/issues/196986\r\n\r\n## Summary\r\n\r\n### Problem\r\nThe copy button for a visualization does nothing, as there's no content\r\nto copy. When clicked on this button, a message is shown saying \"Copied\r\nMessage\", but nothing is copied.\r\n\r\n### Solution\r\nRemove the copy button, when there's no content to copy.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"a613277a549a1be8643446bdf65517313a0c1e00","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:Obs AI Assistant","backport:version","v8.17.0"],"title":"[Obs AI Assistant] Remove the copy button if there is no content to copy","number":199064,"url":"https://github.com/elastic/kibana/pull/199064","mergeCommit":{"message":"[Obs AI Assistant] Remove the copy button if there is no content to copy (#199064)\n\nCloses https://github.com/elastic/kibana/issues/196986\r\n\r\n## Summary\r\n\r\n### Problem\r\nThe copy button for a visualization does nothing, as there's no content\r\nto copy. When clicked on this button, a message is shown saying \"Copied\r\nMessage\", but nothing is copied.\r\n\r\n### Solution\r\nRemove the copy button, when there's no content to copy.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"a613277a549a1be8643446bdf65517313a0c1e00"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199064","number":199064,"mergeCommit":{"message":"[Obs AI Assistant] Remove the copy button if there is no content to copy (#199064)\n\nCloses https://github.com/elastic/kibana/issues/196986\r\n\r\n## Summary\r\n\r\n### Problem\r\nThe copy button for a visualization does nothing, as there's no content\r\nto copy. When clicked on this button, a message is shown saying \"Copied\r\nMessage\", but nothing is copied.\r\n\r\n### Solution\r\nRemove the copy button, when there's no content to copy.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"a613277a549a1be8643446bdf65517313a0c1e00"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Viduni Wickramarachchi <viduni.wickramarachchi@elastic.co>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Nov 18, 2024
…opy (elastic#199064) Closes elastic#196986 ## Summary ### Problem The copy button for a visualization does nothing, as there's no content to copy. When clicked on this button, a message is shown saying "Copied Message", but nothing is copied. ### Solution Remove the copy button, when there's no content to copy. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Nov 18, 2024
…opy (elastic#199064) Closes elastic#196986 ## Summary ### Problem The copy button for a visualization does nothing, as there's no content to copy. When clicked on this button, a message is shown saying "Copied Message", but nothing is copied. ### Solution Remove the copy button, when there's no content to copy. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #196986
Summary
Problem
The copy button for a visualization does nothing, as there's no content to copy. When clicked on this button, a message is shown saying "Copied Message", but nothing is copied.
Solution
Remove the copy button, when there's no content to copy.
Screenshots
Before:
After:
Checklist