[Infra] Fix anomalies flyout navigation failing test#197999
Merged
jennypavlova merged 1 commit intoelastic:mainfrom Oct 29, 2024
Conversation
Contributor
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
Contributor
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7284[✅] x-pack/test/functional/apps/infra/config.ts: 25/25 tests passed. |
Contributor
💚 Build Succeeded
Metrics [docs]
|
MiriamAparicio
approved these changes
Oct 28, 2024
Contributor
MiriamAparicio
left a comment
There was a problem hiding this comment.
thanks for the fix
Contributor
|
Starting backport for target branches: 8.16 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 29, 2024
Closes elastic#192882 The issue was that the url was checked too early which resulted in checking the locator url instead of the page url after navigating so I added a check for loading before the URL check and this solved the issue. https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7284 (cherry picked from commit 3131dd9)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 29, 2024
…#198115) # Backport This will backport the following commits from `main` to `8.16`: - [[Infra] Fix anomalies flyout navigation failing test (#197999)](#197999) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"jennypavlova","email":"dzheni.pavlova@elastic.co"},"sourceCommit":{"committedDate":"2024-10-29T08:42:43Z","message":"[Infra] Fix anomalies flyout navigation failing test (#197999)\n\nCloses #192882 \r\n\r\nThe issue was that the url was checked too early which resulted in\r\nchecking the locator url instead of the page url after navigating so I\r\nadded a check for loading before the URL check and this solved the\r\nissue.\r\n\r\n\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7284","sha":"3131dd9bfa1ee28fa12f90bb6ae8060da9e44665","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:obs-ux-infra_services","v8.16.0","backport:version"],"title":"[Infra] Fix anomalies flyout navigation failing test","number":197999,"url":"https://github.com/elastic/kibana/pull/197999","mergeCommit":{"message":"[Infra] Fix anomalies flyout navigation failing test (#197999)\n\nCloses #192882 \r\n\r\nThe issue was that the url was checked too early which resulted in\r\nchecking the locator url instead of the page url after navigating so I\r\nadded a check for loading before the URL check and this solved the\r\nissue.\r\n\r\n\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7284","sha":"3131dd9bfa1ee28fa12f90bb6ae8060da9e44665"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197999","number":197999,"mergeCommit":{"message":"[Infra] Fix anomalies flyout navigation failing test (#197999)\n\nCloses #192882 \r\n\r\nThe issue was that the url was checked too early which resulted in\r\nchecking the locator url instead of the page url after navigating so I\r\nadded a check for loading before the URL check and this solved the\r\nissue.\r\n\r\n\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7284","sha":"3131dd9bfa1ee28fa12f90bb6ae8060da9e44665"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: jennypavlova <dzheni.pavlova@elastic.co>
tiansivive
pushed a commit
to tiansivive/kibana
that referenced
this pull request
Oct 29, 2024
Closes elastic#192882 The issue was that the url was checked too early which resulted in checking the locator url instead of the page url after navigating so I added a check for loading before the URL check and this solved the issue. https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7284
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #192882
The issue was that the url was checked too early which resulted in checking the locator url instead of the page url after navigating so I added a check for loading before the URL check and this solved the issue.
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7284