Skip to content

[EDR Workflows] Improve on unavailable shard exception flakiness in cypress#197864

Merged
gergoabraham merged 5 commits intoelastic:mainfrom
gergoabraham:dw-improve-on-unavailable-shard-exception-flakiness
Oct 29, 2024
Merged

[EDR Workflows] Improve on unavailable shard exception flakiness in cypress#197864
gergoabraham merged 5 commits intoelastic:mainfrom
gergoabraham:dw-improve-on-unavailable-shard-exception-flakiness

Conversation

@gergoabraham
Copy link
Copy Markdown
Contributor

@gergoabraham gergoabraham commented Oct 25, 2024

Summary

The cypress task cy.task('indexEndpointHosts') sometimes throws no_shard_available_action_exception, when transforms are stopped. This looks like a temporary issue, and in other tests it is simply retried.

This PR adds the retry logic for this type of error, and unskips some tests.

closes #194135
closes #191914

Checklist

Delete any items that are not applicable to this PR.

@gergoabraham gergoabraham added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.16.0 backport:version Backport to applied version labels v8.17.0 labels Oct 25, 2024
@gergoabraham gergoabraham self-assigned this Oct 25, 2024
@kibanamachine
Copy link
Copy Markdown
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#7266

[❌] Security Solution Defend Workflows - Cypress: 0/25 tests passed.

see run history

@gergoabraham gergoabraham force-pushed the dw-improve-on-unavailable-shard-exception-flakiness branch from d06624b to 3b8e893 Compare October 28, 2024 13:37
@kibanamachine
Copy link
Copy Markdown
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7283

[✅] Security Solution Defend Workflows - Cypress: 25/25 tests passed.

see run history

@gergoabraham gergoabraham marked this pull request as ready for review October 28, 2024 14:46
@gergoabraham gergoabraham requested a review from a team as a code owner October 28, 2024 14:46
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

cc @gergoabraham

@gergoabraham gergoabraham merged commit db18039 into elastic:main Oct 29, 2024
@gergoabraham gergoabraham deleted the dw-improve-on-unavailable-shard-exception-flakiness branch October 29, 2024 10:52
@kibanamachine
Copy link
Copy Markdown
Contributor

Starting backport for target branches: 8.16, 8.x

https://github.com/elastic/kibana/actions/runs/11572351550

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 29, 2024
…ypress (elastic#197864)

## Summary

The cypress task `cy.task('indexEndpointHosts')` sometimes throws
`no_shard_available_action_exception`, when transforms are stopped. This
looks like a temporary issue, and in other tests it is simply retried.

This PR adds the retry logic for this type of error, and unskips some
tests.

closes elastic#194135
closes elastic#191914

### Checklist

Delete any items that are not applicable to this PR.
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed

(cherry picked from commit db18039)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 29, 2024
…ypress (elastic#197864)

## Summary

The cypress task `cy.task('indexEndpointHosts')` sometimes throws
`no_shard_available_action_exception`, when transforms are stopped. This
looks like a temporary issue, and in other tests it is simply retried.

This PR adds the retry logic for this type of error, and unskips some
tests.

closes elastic#194135
closes elastic#191914

### Checklist

Delete any items that are not applicable to this PR.
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed

(cherry picked from commit db18039)
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 All backports created successfully

Status Branch Result
8.16
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

tiansivive pushed a commit to tiansivive/kibana that referenced this pull request Oct 29, 2024
…ypress (elastic#197864)

## Summary

The cypress task `cy.task('indexEndpointHosts')` sometimes throws
`no_shard_available_action_exception`, when transforms are stopped. This
looks like a temporary issue, and in other tests it is simply retried.

This PR adds the retry logic for this type of error, and unskips some
tests.

closes elastic#194135
closes elastic#191914

### Checklist

Delete any items that are not applicable to this PR.
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
kibanamachine added a commit that referenced this pull request Oct 30, 2024
…ss in cypress (#197864) (#198137)

# Backport

This will backport the following commits from `main` to `8.16`:
- [[EDR Workflows] Improve on unavailable shard exception flakiness in
cypress (#197864)](#197864)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Gergő
Ábrahám","email":"gergo.abraham@elastic.co"},"sourceCommit":{"committedDate":"2024-10-29T10:52:36Z","message":"[EDR
Workflows] Improve on unavailable shard exception flakiness in cypress
(#197864)\n\n## Summary\r\n\r\nThe cypress task
`cy.task('indexEndpointHosts')` sometimes
throws\r\n`no_shard_available_action_exception`, when transforms are
stopped. This\r\nlooks like a temporary issue, and in other tests it is
simply retried.\r\n\r\nThis PR adds the retry logic for this type of
error, and unskips some\r\ntests.\r\n\r\ncloses #194135\r\ncloses
#191914\r\n\r\n### Checklist\r\n\r\nDelete any items that are not
applicable to this PR.\r\n- [x] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests
changed","sha":"db18039dc40bc0e994be666a83a28a0452a0c6e2","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Defend
Workflows","v8.16.0","backport:version","v8.17.0"],"title":"[EDR
Workflows] Improve on unavailable shard exception flakiness in
cypress","number":197864,"url":"https://github.com/elastic/kibana/pull/197864","mergeCommit":{"message":"[EDR
Workflows] Improve on unavailable shard exception flakiness in cypress
(#197864)\n\n## Summary\r\n\r\nThe cypress task
`cy.task('indexEndpointHosts')` sometimes
throws\r\n`no_shard_available_action_exception`, when transforms are
stopped. This\r\nlooks like a temporary issue, and in other tests it is
simply retried.\r\n\r\nThis PR adds the retry logic for this type of
error, and unskips some\r\ntests.\r\n\r\ncloses #194135\r\ncloses
#191914\r\n\r\n### Checklist\r\n\r\nDelete any items that are not
applicable to this PR.\r\n- [x] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests
changed","sha":"db18039dc40bc0e994be666a83a28a0452a0c6e2"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197864","number":197864,"mergeCommit":{"message":"[EDR
Workflows] Improve on unavailable shard exception flakiness in cypress
(#197864)\n\n## Summary\r\n\r\nThe cypress task
`cy.task('indexEndpointHosts')` sometimes
throws\r\n`no_shard_available_action_exception`, when transforms are
stopped. This\r\nlooks like a temporary issue, and in other tests it is
simply retried.\r\n\r\nThis PR adds the retry logic for this type of
error, and unskips some\r\ntests.\r\n\r\ncloses #194135\r\ncloses
#191914\r\n\r\n### Checklist\r\n\r\nDelete any items that are not
applicable to this PR.\r\n- [x] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests
changed","sha":"db18039dc40bc0e994be666a83a28a0452a0c6e2"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Gergő Ábrahám <gergo.abraham@elastic.co>
kibanamachine added a commit that referenced this pull request Oct 30, 2024
…s in cypress (#197864) (#198138)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[EDR Workflows] Improve on unavailable shard exception flakiness in
cypress (#197864)](#197864)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Gergő
Ábrahám","email":"gergo.abraham@elastic.co"},"sourceCommit":{"committedDate":"2024-10-29T10:52:36Z","message":"[EDR
Workflows] Improve on unavailable shard exception flakiness in cypress
(#197864)\n\n## Summary\r\n\r\nThe cypress task
`cy.task('indexEndpointHosts')` sometimes
throws\r\n`no_shard_available_action_exception`, when transforms are
stopped. This\r\nlooks like a temporary issue, and in other tests it is
simply retried.\r\n\r\nThis PR adds the retry logic for this type of
error, and unskips some\r\ntests.\r\n\r\ncloses #194135\r\ncloses
#191914\r\n\r\n### Checklist\r\n\r\nDelete any items that are not
applicable to this PR.\r\n- [x] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests
changed","sha":"db18039dc40bc0e994be666a83a28a0452a0c6e2","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Defend
Workflows","v8.16.0","backport:version","v8.17.0"],"title":"[EDR
Workflows] Improve on unavailable shard exception flakiness in
cypress","number":197864,"url":"https://github.com/elastic/kibana/pull/197864","mergeCommit":{"message":"[EDR
Workflows] Improve on unavailable shard exception flakiness in cypress
(#197864)\n\n## Summary\r\n\r\nThe cypress task
`cy.task('indexEndpointHosts')` sometimes
throws\r\n`no_shard_available_action_exception`, when transforms are
stopped. This\r\nlooks like a temporary issue, and in other tests it is
simply retried.\r\n\r\nThis PR adds the retry logic for this type of
error, and unskips some\r\ntests.\r\n\r\ncloses #194135\r\ncloses
#191914\r\n\r\n### Checklist\r\n\r\nDelete any items that are not
applicable to this PR.\r\n- [x] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests
changed","sha":"db18039dc40bc0e994be666a83a28a0452a0c6e2"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197864","number":197864,"mergeCommit":{"message":"[EDR
Workflows] Improve on unavailable shard exception flakiness in cypress
(#197864)\n\n## Summary\r\n\r\nThe cypress task
`cy.task('indexEndpointHosts')` sometimes
throws\r\n`no_shard_available_action_exception`, when transforms are
stopped. This\r\nlooks like a temporary issue, and in other tests it is
simply retried.\r\n\r\nThis PR adds the retry logic for this type of
error, and unskips some\r\ntests.\r\n\r\ncloses #194135\r\ncloses
#191914\r\n\r\n### Checklist\r\n\r\nDelete any items that are not
applicable to this PR.\r\n- [x] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests
changed","sha":"db18039dc40bc0e994be666a83a28a0452a0c6e2"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Gergő Ábrahám <gergo.abraham@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment