[ObsUx][Infra] Unskip and try to fix hosts view test#197861
Merged
jennypavlova merged 4 commits intoelastic:mainfrom Oct 29, 2024
Merged
[ObsUx][Infra] Unskip and try to fix hosts view test#197861jennypavlova merged 4 commits intoelastic:mainfrom
jennypavlova merged 4 commits intoelastic:mainfrom
Conversation
Member
Author
|
/ci |
Contributor
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#7265[❌] x-pack/test/functional/apps/infra/config.ts: 0/50 tests passed. |
Contributor
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#7281[❌] x-pack/test/functional/apps/infra/config.ts: 0/25 tests passed. |
Contributor
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7282[✅] x-pack/test/functional/apps/infra/config.ts: 25/25 tests passed. |
Contributor
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
Contributor
💚 Build Succeeded
Metrics [docs]
History
|
MiriamAparicio
approved these changes
Oct 28, 2024
Contributor
MiriamAparicio
left a comment
There was a problem hiding this comment.
Thanks for fixing this tests
Contributor
|
Starting backport for target branches: 8.16 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 29, 2024
Closes elastic#191806 The parts of the unskipped test were fixed here - the only case I couldn't find the reason for failing after unskipping it is `should have an option to open the chart in lens` - for some reason, the whole menu is gone when checking the CI and I couldn't reproduce that so this will be the only skipped part so we can at least have all the other `Hosts view` tests (cherry picked from commit 735b2de)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 29, 2024
…#198116) # Backport This will backport the following commits from `main` to `8.16`: - [[ObsUx][Infra] Unskip and try to fix hosts view test (#197861)](#197861) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"jennypavlova","email":"dzheni.pavlova@elastic.co"},"sourceCommit":{"committedDate":"2024-10-29T08:43:20Z","message":"[ObsUx][Infra] Unskip and try to fix hosts view test (#197861)\n\nCloses #191806\r\n\r\nThe parts of the unskipped test were fixed here - the only case I\r\ncouldn't find the reason for failing after unskipping it is `should have\r\nan option to open the chart in lens` - for some reason, the whole menu\r\nis gone when checking the CI and I couldn't reproduce that so this will\r\nbe the only skipped part so we can at least have all the other `Hosts\r\nview` tests","sha":"735b2de08a5ab8d4b65e101cca6a044372726627","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:obs-ux-infra_services","v8.16.0","backport:version"],"title":"[ObsUx][Infra] Unskip and try to fix hosts view test","number":197861,"url":"https://github.com/elastic/kibana/pull/197861","mergeCommit":{"message":"[ObsUx][Infra] Unskip and try to fix hosts view test (#197861)\n\nCloses #191806\r\n\r\nThe parts of the unskipped test were fixed here - the only case I\r\ncouldn't find the reason for failing after unskipping it is `should have\r\nan option to open the chart in lens` - for some reason, the whole menu\r\nis gone when checking the CI and I couldn't reproduce that so this will\r\nbe the only skipped part so we can at least have all the other `Hosts\r\nview` tests","sha":"735b2de08a5ab8d4b65e101cca6a044372726627"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197861","number":197861,"mergeCommit":{"message":"[ObsUx][Infra] Unskip and try to fix hosts view test (#197861)\n\nCloses #191806\r\n\r\nThe parts of the unskipped test were fixed here - the only case I\r\ncouldn't find the reason for failing after unskipping it is `should have\r\nan option to open the chart in lens` - for some reason, the whole menu\r\nis gone when checking the CI and I couldn't reproduce that so this will\r\nbe the only skipped part so we can at least have all the other `Hosts\r\nview` tests","sha":"735b2de08a5ab8d4b65e101cca6a044372726627"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: jennypavlova <dzheni.pavlova@elastic.co>
tiansivive
pushed a commit
to tiansivive/kibana
that referenced
this pull request
Oct 29, 2024
Closes elastic#191806 The parts of the unskipped test were fixed here - the only case I couldn't find the reason for failing after unskipping it is `should have an option to open the chart in lens` - for some reason, the whole menu is gone when checking the CI and I couldn't reproduce that so this will be the only skipped part so we can at least have all the other `Hosts view` tests
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #191806
The parts of the unskipped test were fixed here - the only case I couldn't find the reason for failing after unskipping it is
should have an option to open the chart in lens- for some reason, the whole menu is gone when checking the CI and I couldn't reproduce that so this will be the only skipped part so we can at least have all the otherHosts viewtests