Skip to content

[ObsUx][Infra] Unskip and try to fix hosts view test#197861

Merged
jennypavlova merged 4 commits intoelastic:mainfrom
jennypavlova:191806-try-to-fix-failing-test
Oct 29, 2024
Merged

[ObsUx][Infra] Unskip and try to fix hosts view test#197861
jennypavlova merged 4 commits intoelastic:mainfrom
jennypavlova:191806-try-to-fix-failing-test

Conversation

@jennypavlova
Copy link
Copy Markdown
Member

@jennypavlova jennypavlova commented Oct 25, 2024

Closes #191806

The parts of the unskipped test were fixed here - the only case I couldn't find the reason for failing after unskipping it is should have an option to open the chart in lens - for some reason, the whole menu is gone when checking the CI and I couldn't reproduce that so this will be the only skipped part so we can at least have all the other Hosts view tests

@jennypavlova jennypavlova self-assigned this Oct 25, 2024
@jennypavlova
Copy link
Copy Markdown
Member Author

/ci

@jennypavlova jennypavlova added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation. v8.16.0 backport:version Backport to applied version labels labels Oct 25, 2024
@kibanamachine
Copy link
Copy Markdown
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#7265

[❌] x-pack/test/functional/apps/infra/config.ts: 0/50 tests passed.

see run history

@kibanamachine
Copy link
Copy Markdown
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#7281

[❌] x-pack/test/functional/apps/infra/config.ts: 0/25 tests passed.

see run history

@kibanamachine
Copy link
Copy Markdown
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7282

[✅] x-pack/test/functional/apps/infra/config.ts: 25/25 tests passed.

see run history

@jennypavlova jennypavlova marked this pull request as ready for review October 28, 2024 14:36
@jennypavlova jennypavlova requested a review from a team October 28, 2024 14:36
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

cc @jennypavlova

Copy link
Copy Markdown
Contributor

@MiriamAparicio MiriamAparicio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this tests

@jennypavlova jennypavlova merged commit 735b2de into elastic:main Oct 29, 2024
@kibanamachine
Copy link
Copy Markdown
Contributor

Starting backport for target branches: 8.16

https://github.com/elastic/kibana/actions/runs/11570224563

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 29, 2024
Closes elastic#191806

The parts of the unskipped test were fixed here - the only case I
couldn't find the reason for failing after unskipping it is `should have
an option to open the chart in lens` - for some reason, the whole menu
is gone when checking the CI and I couldn't reproduce that so this will
be the only skipped part so we can at least have all the other `Hosts
view` tests

(cherry picked from commit 735b2de)
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 All backports created successfully

Status Branch Result
8.16

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 29, 2024
…#198116)

# Backport

This will backport the following commits from `main` to `8.16`:
- [[ObsUx][Infra] Unskip and try to fix hosts view test
(#197861)](#197861)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"jennypavlova","email":"dzheni.pavlova@elastic.co"},"sourceCommit":{"committedDate":"2024-10-29T08:43:20Z","message":"[ObsUx][Infra]
Unskip and try to fix hosts view test (#197861)\n\nCloses
#191806\r\n\r\nThe parts of the unskipped test were fixed here - the
only case I\r\ncouldn't find the reason for failing after unskipping it
is `should have\r\nan option to open the chart in lens` - for some
reason, the whole menu\r\nis gone when checking the CI and I couldn't
reproduce that so this will\r\nbe the only skipped part so we can at
least have all the other `Hosts\r\nview`
tests","sha":"735b2de08a5ab8d4b65e101cca6a044372726627","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:obs-ux-infra_services","v8.16.0","backport:version"],"title":"[ObsUx][Infra]
Unskip and try to fix hosts view
test","number":197861,"url":"https://github.com/elastic/kibana/pull/197861","mergeCommit":{"message":"[ObsUx][Infra]
Unskip and try to fix hosts view test (#197861)\n\nCloses
#191806\r\n\r\nThe parts of the unskipped test were fixed here - the
only case I\r\ncouldn't find the reason for failing after unskipping it
is `should have\r\nan option to open the chart in lens` - for some
reason, the whole menu\r\nis gone when checking the CI and I couldn't
reproduce that so this will\r\nbe the only skipped part so we can at
least have all the other `Hosts\r\nview`
tests","sha":"735b2de08a5ab8d4b65e101cca6a044372726627"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197861","number":197861,"mergeCommit":{"message":"[ObsUx][Infra]
Unskip and try to fix hosts view test (#197861)\n\nCloses
#191806\r\n\r\nThe parts of the unskipped test were fixed here - the
only case I\r\ncouldn't find the reason for failing after unskipping it
is `should have\r\nan option to open the chart in lens` - for some
reason, the whole menu\r\nis gone when checking the CI and I couldn't
reproduce that so this will\r\nbe the only skipped part so we can at
least have all the other `Hosts\r\nview`
tests","sha":"735b2de08a5ab8d4b65e101cca6a044372726627"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: jennypavlova <dzheni.pavlova@elastic.co>
tiansivive pushed a commit to tiansivive/kibana that referenced this pull request Oct 29, 2024
Closes elastic#191806

The parts of the unskipped test were fixed here - the only case I
couldn't find the reason for failing after unskipping it is `should have
an option to open the chart in lens` - for some reason, the whole menu
is gone when checking the CI and I couldn't reproduce that so this will
be the only skipped part so we can at least have all the other `Hosts
view` tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation. v8.16.0 v9.0.0

Projects

None yet

4 participants