Conversation
Contributor
|
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
JordanSh
approved these changes
Oct 28, 2024
| export const useNavigateVulnerabilities = () => | ||
| useNavigate(findingsNavigation.vulnerabilities.path); | ||
|
|
||
| export const useNavigateNativeVulnerabilities = () => { |
Contributor
There was a problem hiding this comment.
In the long term we will probably have to pass the filter from the findings on click, which makes me think it might be better to just add the filter prop to the original useNavigateVulnerabilities hook and pass the data_stream filter to it, since the page already filtered for our data stream anyway.
though, If its technically complex we can change this later
Contributor
Author
There was a problem hiding this comment.
yep, let's change it later. Main reason, to make smaller changes as possible for 8.16 after the ff
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
Contributor
|
Starting backport for target branches: 8.16, 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 29, 2024
… CNVM dashboard (elastic#197648) ## Summary - fixes elastic/security-team#10915 (cherry picked from commit b4ed7a1)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 29, 2024
… CNVM dashboard (elastic#197648) ## Summary - fixes elastic/security-team#10915 (cherry picked from commit b4ed7a1)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
tiansivive
pushed a commit
to tiansivive/kibana
that referenced
this pull request
Oct 29, 2024
… CNVM dashboard (elastic#197648) ## Summary - fixes elastic/security-team#10915
kibanamachine
added a commit
that referenced
this pull request
Oct 30, 2024
…s from CNVM dashboard (#197648) (#198140) # Backport This will backport the following commits from `main` to `8.x`: - [[Cloud Security] add vulnerabilties data set to filter for links from CNVM dashboard (#197648)](#197648) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Maxim Kholod","email":"maxim.kholod@elastic.co"},"sourceCommit":{"committedDate":"2024-10-29T10:53:23Z","message":"[Cloud Security] add vulnerabilties data set to filter for links from CNVM dashboard (#197648)\n\n## Summary\r\n\r\n- fixes https://github.com/elastic/security-team/issues/10915","sha":"b4ed7a1945f5ea5b76be36833cdf11e28641cf8f","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Cloud Security","backport:prev-minor","v8.16.0","backport:version","v8.17.0"],"title":"[Cloud Security] add vulnerabilties data set to filter for links from CNVM dashboard","number":197648,"url":"https://github.com/elastic/kibana/pull/197648","mergeCommit":{"message":"[Cloud Security] add vulnerabilties data set to filter for links from CNVM dashboard (#197648)\n\n## Summary\r\n\r\n- fixes https://github.com/elastic/security-team/issues/10915","sha":"b4ed7a1945f5ea5b76be36833cdf11e28641cf8f"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197648","number":197648,"mergeCommit":{"message":"[Cloud Security] add vulnerabilties data set to filter for links from CNVM dashboard (#197648)\n\n## Summary\r\n\r\n- fixes https://github.com/elastic/security-team/issues/10915","sha":"b4ed7a1945f5ea5b76be36833cdf11e28641cf8f"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Maxim Kholod <maxim.kholod@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Oct 30, 2024
…ks from CNVM dashboard (#197648) (#198139) # Backport This will backport the following commits from `main` to `8.16`: - [[Cloud Security] add vulnerabilties data set to filter for links from CNVM dashboard (#197648)](#197648) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Maxim Kholod","email":"maxim.kholod@elastic.co"},"sourceCommit":{"committedDate":"2024-10-29T10:53:23Z","message":"[Cloud Security] add vulnerabilties data set to filter for links from CNVM dashboard (#197648)\n\n## Summary\r\n\r\n- fixes https://github.com/elastic/security-team/issues/10915","sha":"b4ed7a1945f5ea5b76be36833cdf11e28641cf8f","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Cloud Security","backport:prev-minor","v8.16.0","backport:version","v8.17.0"],"title":"[Cloud Security] add vulnerabilties data set to filter for links from CNVM dashboard","number":197648,"url":"https://github.com/elastic/kibana/pull/197648","mergeCommit":{"message":"[Cloud Security] add vulnerabilties data set to filter for links from CNVM dashboard (#197648)\n\n## Summary\r\n\r\n- fixes https://github.com/elastic/security-team/issues/10915","sha":"b4ed7a1945f5ea5b76be36833cdf11e28641cf8f"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197648","number":197648,"mergeCommit":{"message":"[Cloud Security] add vulnerabilties data set to filter for links from CNVM dashboard (#197648)\n\n## Summary\r\n\r\n- fixes https://github.com/elastic/security-team/issues/10915","sha":"b4ed7a1945f5ea5b76be36833cdf11e28641cf8f"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Maxim Kholod <maxim.kholod@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary