Update the test subjects of the feedback buttons#197311
Merged
gbamparop merged 2 commits intoelastic:mainfrom Oct 25, 2024
Merged
Update the test subjects of the feedback buttons#197311gbamparop merged 2 commits intoelastic:mainfrom
gbamparop merged 2 commits intoelastic:mainfrom
Conversation
Contributor
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Contributor
Author
|
@mykolaharmash do we need to update any dashboards? |
Contributor
We don't because these buttons trigger a custom event, dashboards don't rely on the automatic click event with the subject ID. |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
Contributor
|
Starting backport for target branches: 8.16, 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 25, 2024
Update the test subjects of the feedback buttons. Closes elastic#196297 Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit 188beda)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 25, 2024
Update the test subjects of the feedback buttons. Closes elastic#196297 Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit 188beda)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 25, 2024
…97763) # Backport This will backport the following commits from `main` to `8.16`: - [Update the test subjects of the feedback buttons (#197311)](#197311) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Giorgos Bamparopoulos","email":"georgios.bamparopoulos@elastic.co"},"sourceCommit":{"committedDate":"2024-10-25T07:14:00Z","message":"Update the test subjects of the feedback buttons (#197311)\n\nUpdate the test subjects of the feedback buttons.\r\n\r\nCloses https://github.com/elastic/kibana/issues/196297\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"188beda849ae886b164c9ccd3d5f7d2edf35479c","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","v8.16.0"],"title":"Update the test subjects of the feedback buttons","number":197311,"url":"https://github.com/elastic/kibana/pull/197311","mergeCommit":{"message":"Update the test subjects of the feedback buttons (#197311)\n\nUpdate the test subjects of the feedback buttons.\r\n\r\nCloses https://github.com/elastic/kibana/issues/196297\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"188beda849ae886b164c9ccd3d5f7d2edf35479c"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197311","number":197311,"mergeCommit":{"message":"Update the test subjects of the feedback buttons (#197311)\n\nUpdate the test subjects of the feedback buttons.\r\n\r\nCloses https://github.com/elastic/kibana/issues/196297\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"188beda849ae886b164c9ccd3d5f7d2edf35479c"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Giorgos Bamparopoulos <georgios.bamparopoulos@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Oct 25, 2024
…7764) # Backport This will backport the following commits from `main` to `8.x`: - [Update the test subjects of the feedback buttons (#197311)](#197311) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Giorgos Bamparopoulos","email":"georgios.bamparopoulos@elastic.co"},"sourceCommit":{"committedDate":"2024-10-25T07:14:00Z","message":"Update the test subjects of the feedback buttons (#197311)\n\nUpdate the test subjects of the feedback buttons.\r\n\r\nCloses https://github.com/elastic/kibana/issues/196297\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"188beda849ae886b164c9ccd3d5f7d2edf35479c","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","v8.16.0"],"title":"Update the test subjects of the feedback buttons","number":197311,"url":"https://github.com/elastic/kibana/pull/197311","mergeCommit":{"message":"Update the test subjects of the feedback buttons (#197311)\n\nUpdate the test subjects of the feedback buttons.\r\n\r\nCloses https://github.com/elastic/kibana/issues/196297\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"188beda849ae886b164c9ccd3d5f7d2edf35479c"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197311","number":197311,"mergeCommit":{"message":"Update the test subjects of the feedback buttons (#197311)\n\nUpdate the test subjects of the feedback buttons.\r\n\r\nCloses https://github.com/elastic/kibana/issues/196297\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"188beda849ae886b164c9ccd3d5f7d2edf35479c"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Giorgos Bamparopoulos <georgios.bamparopoulos@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the test subjects of the feedback buttons.
Closes #196297