Skip to content

Fix Typo: Change 'dashaboard' to 'dashboard' on APM-service Dashboards page #195773#196969

Merged
jennypavlova merged 16 commits intoelastic:mainfrom
nabeelmohamed:main
Oct 29, 2024
Merged

Fix Typo: Change 'dashaboard' to 'dashboard' on APM-service Dashboards page #195773#196969
jennypavlova merged 16 commits intoelastic:mainfrom
nabeelmohamed:main

Conversation

@nabeelmohamed
Copy link
Copy Markdown
Contributor

@nabeelmohamed nabeelmohamed commented Oct 19, 2024

Title: Fix Typo: Change 'dashaboard' to 'dashboard' on APM-service Dashboards page

Description:
This PR fixes a typo on the "Dashboards" page for APM-service. The typo "dashaboard" has been corrected to "dashboard" to ensure proper functionality and readability.

closes #195773

Changes Made:

  • Corrected the typo in the text "To get started, add your dashaboard" to "To get started, add your dashboard."

Testing:

  • Verified the change on the Dashboards page for APM-service.
  • Ensured no other instances of the typo exist in the codebase.

Release note:
Fixes a typo on the "Dashboards" page for APM-service, changing 'dashaboard' to 'dashboard'.

Additional Notes:
No additional notes.

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@nabeelmohamed nabeelmohamed requested a review from a team October 19, 2024 04:42
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation. labels Oct 19, 2024
@cla-checker-service
Copy link
Copy Markdown

cla-checker-service bot commented Oct 19, 2024

💚 CLA has been signed

@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@github-actions
Copy link
Copy Markdown
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@nabeelmohamed
Copy link
Copy Markdown
Contributor Author

hey need a help.after creating this PR i signed the contributor agreement. but in the checks its still unsuccessful. what to do . Also
prbot:release note labels — All PRs require a release_note:* label what should i do to to make this check successful. Somebody help

@nabeelmohamed nabeelmohamed changed the title Fix typo: change 'dashaboard' to 'dashboard' on APM-service Dashboard… mentioned in issue #195773 Fixes. the change 'dashaboard' to 'dashboard' on APM-service Dashboard… mentioned in issue #195773 Oct 19, 2024
@nabeelmohamed nabeelmohamed changed the title Fixes. the change 'dashaboard' to 'dashboard' on APM-service Dashboard… mentioned in issue #195773 Fix Typo: Change 'dashaboard' to 'dashboard' on APM-service Dashboards page #195773 Oct 19, 2024
@nabeelmohamed
Copy link
Copy Markdown
Contributor Author

@smith brother i have updated the typo error but its failing some label checks . help me resolve it

@crespocarlos crespocarlos added release_note:skip Skip the PR/issue when compiling release notes backport:prev-major labels Oct 21, 2024
@nabeelmohamed
Copy link
Copy Markdown
Contributor Author

run docs-build

@smith
Copy link
Copy Markdown
Contributor

smith commented Oct 21, 2024

@elasticmachine test this please

@smith smith enabled auto-merge (squash) October 21, 2024 15:41
@smith
Copy link
Copy Markdown
Contributor

smith commented Oct 21, 2024

@smith brother i have updated the typo error but its failing some label checks . help me resolve it

@nabeelmohamed it looks like you've got the labels right but the tests don't run automatically if you're not an Elastic employee. I've triggered the tests in the comment above and will merge once everything is green.

Sorry if it was more difficult than it should be to get started contributing, but we really appreciate you doing this work and would be happy to help you in any future contributions!

auto-merge was automatically disabled October 25, 2024 04:45

Head branch was pushed to by a user without write access

@nabeelmohamed nabeelmohamed requested a review from a team as a code owner October 25, 2024 04:45
…_object/ by removing unused objects like saveWithConfirmation and checkForDuplicateTitle.
export { CoreScopedHistory } from '@kbn/core-application-browser-internal';

export type {
SavedObjectsClientContract,
Copy link
Copy Markdown
Member

@gsoldevila gsoldevila Oct 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR also removes some exported members from src/core/public/index.ts and src/plugins/saved_objects/public/saved_object/index.ts.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the cahnges in src/plugins/saved_objects/public/saved_object/index.ts were made to original state by creating new commit instead of revert is it ok @gsoldevila

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that's fine, commits are squashed on merge.
The changes in src/core/public/index.ts still need to be reverted though.

Copy link
Copy Markdown
Member

@gsoldevila gsoldevila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please limit the changes to what's strictly in the scope of the PR.

@smith
Copy link
Copy Markdown
Contributor

smith commented Oct 28, 2024

@elasticmachine test this please

@jennypavlova
Copy link
Copy Markdown
Member

/ci

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 29, 2024

💚 Build Succeeded

  • Buildkite Build
  • Commit: 34fa741
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-196969-34fa7417c8e6

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.4MB 3.4MB -1.0B

History

@jennypavlova
Copy link
Copy Markdown
Member

run docs-build

@jennypavlova
Copy link
Copy Markdown
Member

run docs-build

@jennypavlova jennypavlova merged commit c7b8ca0 into elastic:main Oct 29, 2024
@kibanamachine
Copy link
Copy Markdown
Contributor

Starting backport for target branches: 8.15, 8.16, 8.x

https://github.com/elastic/kibana/actions/runs/11578487324

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 All backports created successfully

Status Branch Result
8.15 #198169
8.16 #198170
8.x #198171

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 30, 2024
@kibanamachine
Copy link
Copy Markdown
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

kibanamachine added a commit that referenced this pull request Oct 31, 2024
…; on APM-service Dashboards page #195773 (#196969) (#198171)

# Backport

This will backport the following commits from `main` to `8.x`:
- [Fix Typo: Change 'dashaboard' to 'dashboard' on
APM-service Dashboards page #195773
(#196969)](#196969)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Mohamed
Nabeel","email":"137497525+nabeelmohamed@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-10-29T16:40:37Z","message":"Fix
Typo: Change 'dashaboard' to 'dashboard' on APM-service Dashboards page
#195773 (#196969)\n\n**Title:** Fix Typo: Change 'dashaboard' to
'dashboard' on APM-service\r\nDashboards
page\r\n\r\n**Description:**\r\nThis PR fixes a typo on the
\"Dashboards\" page for APM-service. The typo\r\n\"dashaboard\" has been
corrected to \"dashboard\" to ensure proper\r\nfunctionality and
readability.\r\n\r\ncloses #195773\r\n\r\n**Changes Made:**\r\n-
Corrected the typo in the text \"To get started, add your
dashaboard\"\r\nto \"To get started, add your
dashboard.\"\r\n\r\n**Testing:**\r\n- Verified the change on the
Dashboards page for APM-service.\r\n- Ensured no other instances of the
typo exist in the codebase.\r\n\r\n**Release note:**\r\nFixes a typo on
the \"Dashboards\" page for APM-service, changing\r\n'dashaboard' to
'dashboard'.\r\n\r\n**Additional Notes:**\r\nNo additional
notes.\r\n\r\n\r\n## Summary\r\n\r\nSummarize your PR. If it involves
visual changes include a screenshot or\r\ngif.\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[
]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [x] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n- [x] Any UI touched in this PR is
usable by keyboard only (learn more\r\nabout [keyboard
accessibility](https://webaim.org/techniques/keyboard/))\r\n- [x] Any UI
touched in this PR does not create any new axe failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n-
[ ] If a plugin configuration key changed, check if it needs to
be\r\nallowlisted in the cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n-
[x] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[x] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n###
Risk Matrix\r\n\r\nDelete this section if it is not applicable to this
PR.\r\n\r\nBefore closing this PR, invite QA, stakeholders, and other
developers to\r\nidentify risks that should be tested prior to the
change/feature\r\nrelease.\r\n\r\nWhen forming the risk matrix, consider
some of the following examples\r\nand how they may potentially impact
the change:\r\n\r\n| Risk | Probability | Severity | Mitigation/Notes
|\r\n\r\n|---------------------------|-------------|----------|-------------------------|\r\n|
Multiple Spaces&mdash;unexpected behavior in non-default Kibana
Space.\r\n| Low | High | Integration tests will verify that all features
are still\r\nsupported in non-default Kibana Space and when user
switches between\r\nspaces. |\r\n| Multiple nodes&mdash;Elasticsearch
polling might have race conditions\r\nwhen multiple Kibana nodes are
polling for the same tasks. | High | Low\r\n| Tasks are idempotent, so
executing them multiple times will not result\r\nin logical error, but
will degrade performance. To test for this case we\r\nadd plenty of unit
tests around this logic and document manual testing\r\nprocedure. |\r\n|
Code should gracefully handle cases when feature X or plugin Y
are\r\ndisabled. | Medium | High | Unit tests will verify that any
feature flag\r\nor plugin combination still results in our service
operational. |\r\n| [See more potential
risk\r\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)
|\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for
breaking API changes and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)\r\n-
[ ] This will appear in the **Release Notes** and follow
the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by:
Cauê Marcondes
<55978943+cauemarcondes@users.noreply.github.com>\r\nCo-authored-by:
Nathan L Smith <nathan.smith@elastic.co>\r\nCo-authored-by: jennypavlova
<dzheni.pavlova@elastic.co>","sha":"c7b8ca00de0cec5cd99db6e4a218ad40dde27369","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","💝community","v9.0.0","backport:prev-major","ci:project-deploy-observability","Team:obs-ux-infra_services"],"title":"Fix
Typo: Change 'dashaboard' to 'dashboard' on APM-service Dashboards page
#195773","number":196969,"url":"https://github.com/elastic/kibana/pull/196969","mergeCommit":{"message":"Fix
Typo: Change 'dashaboard' to 'dashboard' on APM-service Dashboards page
#195773 (#196969)\n\n**Title:** Fix Typo: Change 'dashaboard' to
'dashboard' on APM-service\r\nDashboards
page\r\n\r\n**Description:**\r\nThis PR fixes a typo on the
\"Dashboards\" page for APM-service. The typo\r\n\"dashaboard\" has been
corrected to \"dashboard\" to ensure proper\r\nfunctionality and
readability.\r\n\r\ncloses #195773\r\n\r\n**Changes Made:**\r\n-
Corrected the typo in the text \"To get started, add your
dashaboard\"\r\nto \"To get started, add your
dashboard.\"\r\n\r\n**Testing:**\r\n- Verified the change on the
Dashboards page for APM-service.\r\n- Ensured no other instances of the
typo exist in the codebase.\r\n\r\n**Release note:**\r\nFixes a typo on
the \"Dashboards\" page for APM-service, changing\r\n'dashaboard' to
'dashboard'.\r\n\r\n**Additional Notes:**\r\nNo additional
notes.\r\n\r\n\r\n## Summary\r\n\r\nSummarize your PR. If it involves
visual changes include a screenshot or\r\ngif.\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[
]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [x] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n- [x] Any UI touched in this PR is
usable by keyboard only (learn more\r\nabout [keyboard
accessibility](https://webaim.org/techniques/keyboard/))\r\n- [x] Any UI
touched in this PR does not create any new axe failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n-
[ ] If a plugin configuration key changed, check if it needs to
be\r\nallowlisted in the cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n-
[x] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[x] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n###
Risk Matrix\r\n\r\nDelete this section if it is not applicable to this
PR.\r\n\r\nBefore closing this PR, invite QA, stakeholders, and other
developers to\r\nidentify risks that should be tested prior to the
change/feature\r\nrelease.\r\n\r\nWhen forming the risk matrix, consider
some of the following examples\r\nand how they may potentially impact
the change:\r\n\r\n| Risk | Probability | Severity | Mitigation/Notes
|\r\n\r\n|---------------------------|-------------|----------|-------------------------|\r\n|
Multiple Spaces&mdash;unexpected behavior in non-default Kibana
Space.\r\n| Low | High | Integration tests will verify that all features
are still\r\nsupported in non-default Kibana Space and when user
switches between\r\nspaces. |\r\n| Multiple nodes&mdash;Elasticsearch
polling might have race conditions\r\nwhen multiple Kibana nodes are
polling for the same tasks. | High | Low\r\n| Tasks are idempotent, so
executing them multiple times will not result\r\nin logical error, but
will degrade performance. To test for this case we\r\nadd plenty of unit
tests around this logic and document manual testing\r\nprocedure. |\r\n|
Code should gracefully handle cases when feature X or plugin Y
are\r\ndisabled. | Medium | High | Unit tests will verify that any
feature flag\r\nor plugin combination still results in our service
operational. |\r\n| [See more potential
risk\r\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)
|\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for
breaking API changes and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)\r\n-
[ ] This will appear in the **Release Notes** and follow
the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by:
Cauê Marcondes
<55978943+cauemarcondes@users.noreply.github.com>\r\nCo-authored-by:
Nathan L Smith <nathan.smith@elastic.co>\r\nCo-authored-by: jennypavlova
<dzheni.pavlova@elastic.co>","sha":"c7b8ca00de0cec5cd99db6e4a218ad40dde27369"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196969","number":196969,"mergeCommit":{"message":"Fix
Typo: Change 'dashaboard' to 'dashboard' on APM-service Dashboards page
#195773 (#196969)\n\n**Title:** Fix Typo: Change 'dashaboard' to
'dashboard' on APM-service\r\nDashboards
page\r\n\r\n**Description:**\r\nThis PR fixes a typo on the
\"Dashboards\" page for APM-service. The typo\r\n\"dashaboard\" has been
corrected to \"dashboard\" to ensure proper\r\nfunctionality and
readability.\r\n\r\ncloses #195773\r\n\r\n**Changes Made:**\r\n-
Corrected the typo in the text \"To get started, add your
dashaboard\"\r\nto \"To get started, add your
dashboard.\"\r\n\r\n**Testing:**\r\n- Verified the change on the
Dashboards page for APM-service.\r\n- Ensured no other instances of the
typo exist in the codebase.\r\n\r\n**Release note:**\r\nFixes a typo on
the \"Dashboards\" page for APM-service, changing\r\n'dashaboard' to
'dashboard'.\r\n\r\n**Additional Notes:**\r\nNo additional
notes.\r\n\r\n\r\n## Summary\r\n\r\nSummarize your PR. If it involves
visual changes include a screenshot or\r\ngif.\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[
]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [x] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n- [x] Any UI touched in this PR is
usable by keyboard only (learn more\r\nabout [keyboard
accessibility](https://webaim.org/techniques/keyboard/))\r\n- [x] Any UI
touched in this PR does not create any new axe failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n-
[ ] If a plugin configuration key changed, check if it needs to
be\r\nallowlisted in the cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n-
[x] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[x] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n###
Risk Matrix\r\n\r\nDelete this section if it is not applicable to this
PR.\r\n\r\nBefore closing this PR, invite QA, stakeholders, and other
developers to\r\nidentify risks that should be tested prior to the
change/feature\r\nrelease.\r\n\r\nWhen forming the risk matrix, consider
some of the following examples\r\nand how they may potentially impact
the change:\r\n\r\n| Risk | Probability | Severity | Mitigation/Notes
|\r\n\r\n|---------------------------|-------------|----------|-------------------------|\r\n|
Multiple Spaces&mdash;unexpected behavior in non-default Kibana
Space.\r\n| Low | High | Integration tests will verify that all features
are still\r\nsupported in non-default Kibana Space and when user
switches between\r\nspaces. |\r\n| Multiple nodes&mdash;Elasticsearch
polling might have race conditions\r\nwhen multiple Kibana nodes are
polling for the same tasks. | High | Low\r\n| Tasks are idempotent, so
executing them multiple times will not result\r\nin logical error, but
will degrade performance. To test for this case we\r\nadd plenty of unit
tests around this logic and document manual testing\r\nprocedure. |\r\n|
Code should gracefully handle cases when feature X or plugin Y
are\r\ndisabled. | Medium | High | Unit tests will verify that any
feature flag\r\nor plugin combination still results in our service
operational. |\r\n| [See more potential
risk\r\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)
|\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for
breaking API changes and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)\r\n-
[ ] This will appear in the **Release Notes** and follow
the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by:
Cauê Marcondes
<55978943+cauemarcondes@users.noreply.github.com>\r\nCo-authored-by:
Nathan L Smith <nathan.smith@elastic.co>\r\nCo-authored-by: jennypavlova
<dzheni.pavlova@elastic.co>","sha":"c7b8ca00de0cec5cd99db6e4a218ad40dde27369"}}]}]
BACKPORT-->

Co-authored-by: Mohamed Nabeel <137497525+nabeelmohamed@users.noreply.github.com>
Co-authored-by: Nathan L Smith <nathan.smith@elastic.co>
kibanamachine added a commit that referenced this pull request Oct 31, 2024
…7; on APM-service Dashboards page #195773 (#196969) (#198170)

# Backport

This will backport the following commits from `main` to `8.16`:
- [Fix Typo: Change &#x27;dashaboard&#x27; to &#x27;dashboard&#x27; on
APM-service Dashboards page #195773
(#196969)](#196969)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Mohamed
Nabeel","email":"137497525+nabeelmohamed@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-10-29T16:40:37Z","message":"Fix
Typo: Change 'dashaboard' to 'dashboard' on APM-service Dashboards page
#195773 (#196969)\n\n**Title:** Fix Typo: Change 'dashaboard' to
'dashboard' on APM-service\r\nDashboards
page\r\n\r\n**Description:**\r\nThis PR fixes a typo on the
\"Dashboards\" page for APM-service. The typo\r\n\"dashaboard\" has been
corrected to \"dashboard\" to ensure proper\r\nfunctionality and
readability.\r\n\r\ncloses #195773\r\n\r\n**Changes Made:**\r\n-
Corrected the typo in the text \"To get started, add your
dashaboard\"\r\nto \"To get started, add your
dashboard.\"\r\n\r\n**Testing:**\r\n- Verified the change on the
Dashboards page for APM-service.\r\n- Ensured no other instances of the
typo exist in the codebase.\r\n\r\n**Release note:**\r\nFixes a typo on
the \"Dashboards\" page for APM-service, changing\r\n'dashaboard' to
'dashboard'.\r\n\r\n**Additional Notes:**\r\nNo additional
notes.\r\n\r\n\r\n## Summary\r\n\r\nSummarize your PR. If it involves
visual changes include a screenshot or\r\ngif.\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[
]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [x] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n- [x] Any UI touched in this PR is
usable by keyboard only (learn more\r\nabout [keyboard
accessibility](https://webaim.org/techniques/keyboard/))\r\n- [x] Any UI
touched in this PR does not create any new axe failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n-
[ ] If a plugin configuration key changed, check if it needs to
be\r\nallowlisted in the cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n-
[x] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[x] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n###
Risk Matrix\r\n\r\nDelete this section if it is not applicable to this
PR.\r\n\r\nBefore closing this PR, invite QA, stakeholders, and other
developers to\r\nidentify risks that should be tested prior to the
change/feature\r\nrelease.\r\n\r\nWhen forming the risk matrix, consider
some of the following examples\r\nand how they may potentially impact
the change:\r\n\r\n| Risk | Probability | Severity | Mitigation/Notes
|\r\n\r\n|---------------------------|-------------|----------|-------------------------|\r\n|
Multiple Spaces&mdash;unexpected behavior in non-default Kibana
Space.\r\n| Low | High | Integration tests will verify that all features
are still\r\nsupported in non-default Kibana Space and when user
switches between\r\nspaces. |\r\n| Multiple nodes&mdash;Elasticsearch
polling might have race conditions\r\nwhen multiple Kibana nodes are
polling for the same tasks. | High | Low\r\n| Tasks are idempotent, so
executing them multiple times will not result\r\nin logical error, but
will degrade performance. To test for this case we\r\nadd plenty of unit
tests around this logic and document manual testing\r\nprocedure. |\r\n|
Code should gracefully handle cases when feature X or plugin Y
are\r\ndisabled. | Medium | High | Unit tests will verify that any
feature flag\r\nor plugin combination still results in our service
operational. |\r\n| [See more potential
risk\r\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)
|\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for
breaking API changes and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)\r\n-
[ ] This will appear in the **Release Notes** and follow
the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by:
Cauê Marcondes
<55978943+cauemarcondes@users.noreply.github.com>\r\nCo-authored-by:
Nathan L Smith <nathan.smith@elastic.co>\r\nCo-authored-by: jennypavlova
<dzheni.pavlova@elastic.co>","sha":"c7b8ca00de0cec5cd99db6e4a218ad40dde27369","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","💝community","v9.0.0","backport:prev-major","ci:project-deploy-observability","Team:obs-ux-infra_services"],"title":"Fix
Typo: Change 'dashaboard' to 'dashboard' on APM-service Dashboards page
#195773","number":196969,"url":"https://github.com/elastic/kibana/pull/196969","mergeCommit":{"message":"Fix
Typo: Change 'dashaboard' to 'dashboard' on APM-service Dashboards page
#195773 (#196969)\n\n**Title:** Fix Typo: Change 'dashaboard' to
'dashboard' on APM-service\r\nDashboards
page\r\n\r\n**Description:**\r\nThis PR fixes a typo on the
\"Dashboards\" page for APM-service. The typo\r\n\"dashaboard\" has been
corrected to \"dashboard\" to ensure proper\r\nfunctionality and
readability.\r\n\r\ncloses #195773\r\n\r\n**Changes Made:**\r\n-
Corrected the typo in the text \"To get started, add your
dashaboard\"\r\nto \"To get started, add your
dashboard.\"\r\n\r\n**Testing:**\r\n- Verified the change on the
Dashboards page for APM-service.\r\n- Ensured no other instances of the
typo exist in the codebase.\r\n\r\n**Release note:**\r\nFixes a typo on
the \"Dashboards\" page for APM-service, changing\r\n'dashaboard' to
'dashboard'.\r\n\r\n**Additional Notes:**\r\nNo additional
notes.\r\n\r\n\r\n## Summary\r\n\r\nSummarize your PR. If it involves
visual changes include a screenshot or\r\ngif.\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[
]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [x] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n- [x] Any UI touched in this PR is
usable by keyboard only (learn more\r\nabout [keyboard
accessibility](https://webaim.org/techniques/keyboard/))\r\n- [x] Any UI
touched in this PR does not create any new axe failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n-
[ ] If a plugin configuration key changed, check if it needs to
be\r\nallowlisted in the cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n-
[x] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[x] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n###
Risk Matrix\r\n\r\nDelete this section if it is not applicable to this
PR.\r\n\r\nBefore closing this PR, invite QA, stakeholders, and other
developers to\r\nidentify risks that should be tested prior to the
change/feature\r\nrelease.\r\n\r\nWhen forming the risk matrix, consider
some of the following examples\r\nand how they may potentially impact
the change:\r\n\r\n| Risk | Probability | Severity | Mitigation/Notes
|\r\n\r\n|---------------------------|-------------|----------|-------------------------|\r\n|
Multiple Spaces&mdash;unexpected behavior in non-default Kibana
Space.\r\n| Low | High | Integration tests will verify that all features
are still\r\nsupported in non-default Kibana Space and when user
switches between\r\nspaces. |\r\n| Multiple nodes&mdash;Elasticsearch
polling might have race conditions\r\nwhen multiple Kibana nodes are
polling for the same tasks. | High | Low\r\n| Tasks are idempotent, so
executing them multiple times will not result\r\nin logical error, but
will degrade performance. To test for this case we\r\nadd plenty of unit
tests around this logic and document manual testing\r\nprocedure. |\r\n|
Code should gracefully handle cases when feature X or plugin Y
are\r\ndisabled. | Medium | High | Unit tests will verify that any
feature flag\r\nor plugin combination still results in our service
operational. |\r\n| [See more potential
risk\r\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)
|\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for
breaking API changes and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)\r\n-
[ ] This will appear in the **Release Notes** and follow
the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by:
Cauê Marcondes
<55978943+cauemarcondes@users.noreply.github.com>\r\nCo-authored-by:
Nathan L Smith <nathan.smith@elastic.co>\r\nCo-authored-by: jennypavlova
<dzheni.pavlova@elastic.co>","sha":"c7b8ca00de0cec5cd99db6e4a218ad40dde27369"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196969","number":196969,"mergeCommit":{"message":"Fix
Typo: Change 'dashaboard' to 'dashboard' on APM-service Dashboards page
#195773 (#196969)\n\n**Title:** Fix Typo: Change 'dashaboard' to
'dashboard' on APM-service\r\nDashboards
page\r\n\r\n**Description:**\r\nThis PR fixes a typo on the
\"Dashboards\" page for APM-service. The typo\r\n\"dashaboard\" has been
corrected to \"dashboard\" to ensure proper\r\nfunctionality and
readability.\r\n\r\ncloses #195773\r\n\r\n**Changes Made:**\r\n-
Corrected the typo in the text \"To get started, add your
dashaboard\"\r\nto \"To get started, add your
dashboard.\"\r\n\r\n**Testing:**\r\n- Verified the change on the
Dashboards page for APM-service.\r\n- Ensured no other instances of the
typo exist in the codebase.\r\n\r\n**Release note:**\r\nFixes a typo on
the \"Dashboards\" page for APM-service, changing\r\n'dashaboard' to
'dashboard'.\r\n\r\n**Additional Notes:**\r\nNo additional
notes.\r\n\r\n\r\n## Summary\r\n\r\nSummarize your PR. If it involves
visual changes include a screenshot or\r\ngif.\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[
]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [x] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n- [x] Any UI touched in this PR is
usable by keyboard only (learn more\r\nabout [keyboard
accessibility](https://webaim.org/techniques/keyboard/))\r\n- [x] Any UI
touched in this PR does not create any new axe failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n-
[ ] If a plugin configuration key changed, check if it needs to
be\r\nallowlisted in the cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n-
[x] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[x] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n###
Risk Matrix\r\n\r\nDelete this section if it is not applicable to this
PR.\r\n\r\nBefore closing this PR, invite QA, stakeholders, and other
developers to\r\nidentify risks that should be tested prior to the
change/feature\r\nrelease.\r\n\r\nWhen forming the risk matrix, consider
some of the following examples\r\nand how they may potentially impact
the change:\r\n\r\n| Risk | Probability | Severity | Mitigation/Notes
|\r\n\r\n|---------------------------|-------------|----------|-------------------------|\r\n|
Multiple Spaces&mdash;unexpected behavior in non-default Kibana
Space.\r\n| Low | High | Integration tests will verify that all features
are still\r\nsupported in non-default Kibana Space and when user
switches between\r\nspaces. |\r\n| Multiple nodes&mdash;Elasticsearch
polling might have race conditions\r\nwhen multiple Kibana nodes are
polling for the same tasks. | High | Low\r\n| Tasks are idempotent, so
executing them multiple times will not result\r\nin logical error, but
will degrade performance. To test for this case we\r\nadd plenty of unit
tests around this logic and document manual testing\r\nprocedure. |\r\n|
Code should gracefully handle cases when feature X or plugin Y
are\r\ndisabled. | Medium | High | Unit tests will verify that any
feature flag\r\nor plugin combination still results in our service
operational. |\r\n| [See more potential
risk\r\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)
|\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for
breaking API changes and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)\r\n-
[ ] This will appear in the **Release Notes** and follow
the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by:
Cauê Marcondes
<55978943+cauemarcondes@users.noreply.github.com>\r\nCo-authored-by:
Nathan L Smith <nathan.smith@elastic.co>\r\nCo-authored-by: jennypavlova
<dzheni.pavlova@elastic.co>","sha":"c7b8ca00de0cec5cd99db6e4a218ad40dde27369"}}]}]
BACKPORT-->

Co-authored-by: Mohamed Nabeel <137497525+nabeelmohamed@users.noreply.github.com>
Co-authored-by: Nathan L Smith <nathan.smith@elastic.co>
@kibanamachine
Copy link
Copy Markdown
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

1 similar comment
@kibanamachine
Copy link
Copy Markdown
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Copy Markdown
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

1 similar comment
@kibanamachine
Copy link
Copy Markdown
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

kibanamachine added a commit that referenced this pull request Nov 6, 2024
…7; on APM-service Dashboards page #195773 (#196969) (#198169)

# Backport

This will backport the following commits from `main` to `8.15`:
- [Fix Typo: Change &#x27;dashaboard&#x27; to &#x27;dashboard&#x27; on
APM-service Dashboards page #195773
(#196969)](#196969)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Mohamed
Nabeel","email":"137497525+nabeelmohamed@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-10-29T16:40:37Z","message":"Fix
Typo: Change 'dashaboard' to 'dashboard' on APM-service Dashboards page
#195773 (#196969)\n\n**Title:** Fix Typo: Change 'dashaboard' to
'dashboard' on APM-service\r\nDashboards
page\r\n\r\n**Description:**\r\nThis PR fixes a typo on the
\"Dashboards\" page for APM-service. The typo\r\n\"dashaboard\" has been
corrected to \"dashboard\" to ensure proper\r\nfunctionality and
readability.\r\n\r\ncloses #195773\r\n\r\n**Changes Made:**\r\n-
Corrected the typo in the text \"To get started, add your
dashaboard\"\r\nto \"To get started, add your
dashboard.\"\r\n\r\n**Testing:**\r\n- Verified the change on the
Dashboards page for APM-service.\r\n- Ensured no other instances of the
typo exist in the codebase.\r\n\r\n**Release note:**\r\nFixes a typo on
the \"Dashboards\" page for APM-service, changing\r\n'dashaboard' to
'dashboard'.\r\n\r\n**Additional Notes:**\r\nNo additional
notes.\r\n\r\n\r\n## Summary\r\n\r\nSummarize your PR. If it involves
visual changes include a screenshot or\r\ngif.\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[
]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [x] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n- [x] Any UI touched in this PR is
usable by keyboard only (learn more\r\nabout [keyboard
accessibility](https://webaim.org/techniques/keyboard/))\r\n- [x] Any UI
touched in this PR does not create any new axe failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n-
[ ] If a plugin configuration key changed, check if it needs to
be\r\nallowlisted in the cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n-
[x] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[x] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n###
Risk Matrix\r\n\r\nDelete this section if it is not applicable to this
PR.\r\n\r\nBefore closing this PR, invite QA, stakeholders, and other
developers to\r\nidentify risks that should be tested prior to the
change/feature\r\nrelease.\r\n\r\nWhen forming the risk matrix, consider
some of the following examples\r\nand how they may potentially impact
the change:\r\n\r\n| Risk | Probability | Severity | Mitigation/Notes
|\r\n\r\n|---------------------------|-------------|----------|-------------------------|\r\n|
Multiple Spaces&mdash;unexpected behavior in non-default Kibana
Space.\r\n| Low | High | Integration tests will verify that all features
are still\r\nsupported in non-default Kibana Space and when user
switches between\r\nspaces. |\r\n| Multiple nodes&mdash;Elasticsearch
polling might have race conditions\r\nwhen multiple Kibana nodes are
polling for the same tasks. | High | Low\r\n| Tasks are idempotent, so
executing them multiple times will not result\r\nin logical error, but
will degrade performance. To test for this case we\r\nadd plenty of unit
tests around this logic and document manual testing\r\nprocedure. |\r\n|
Code should gracefully handle cases when feature X or plugin Y
are\r\ndisabled. | Medium | High | Unit tests will verify that any
feature flag\r\nor plugin combination still results in our service
operational. |\r\n| [See more potential
risk\r\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)
|\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for
breaking API changes and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)\r\n-
[ ] This will appear in the **Release Notes** and follow
the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by:
Cauê Marcondes
<55978943+cauemarcondes@users.noreply.github.com>\r\nCo-authored-by:
Nathan L Smith <nathan.smith@elastic.co>\r\nCo-authored-by: jennypavlova
<dzheni.pavlova@elastic.co>","sha":"c7b8ca00de0cec5cd99db6e4a218ad40dde27369","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","💝community","v9.0.0","backport:prev-major","ci:project-deploy-observability","Team:obs-ux-infra_services"],"title":"Fix
Typo: Change 'dashaboard' to 'dashboard' on APM-service Dashboards page
#195773","number":196969,"url":"https://github.com/elastic/kibana/pull/196969","mergeCommit":{"message":"Fix
Typo: Change 'dashaboard' to 'dashboard' on APM-service Dashboards page
#195773 (#196969)\n\n**Title:** Fix Typo: Change 'dashaboard' to
'dashboard' on APM-service\r\nDashboards
page\r\n\r\n**Description:**\r\nThis PR fixes a typo on the
\"Dashboards\" page for APM-service. The typo\r\n\"dashaboard\" has been
corrected to \"dashboard\" to ensure proper\r\nfunctionality and
readability.\r\n\r\ncloses #195773\r\n\r\n**Changes Made:**\r\n-
Corrected the typo in the text \"To get started, add your
dashaboard\"\r\nto \"To get started, add your
dashboard.\"\r\n\r\n**Testing:**\r\n- Verified the change on the
Dashboards page for APM-service.\r\n- Ensured no other instances of the
typo exist in the codebase.\r\n\r\n**Release note:**\r\nFixes a typo on
the \"Dashboards\" page for APM-service, changing\r\n'dashaboard' to
'dashboard'.\r\n\r\n**Additional Notes:**\r\nNo additional
notes.\r\n\r\n\r\n## Summary\r\n\r\nSummarize your PR. If it involves
visual changes include a screenshot or\r\ngif.\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[
]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [x] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n- [x] Any UI touched in this PR is
usable by keyboard only (learn more\r\nabout [keyboard
accessibility](https://webaim.org/techniques/keyboard/))\r\n- [x] Any UI
touched in this PR does not create any new axe failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n-
[ ] If a plugin configuration key changed, check if it needs to
be\r\nallowlisted in the cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n-
[x] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[x] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n###
Risk Matrix\r\n\r\nDelete this section if it is not applicable to this
PR.\r\n\r\nBefore closing this PR, invite QA, stakeholders, and other
developers to\r\nidentify risks that should be tested prior to the
change/feature\r\nrelease.\r\n\r\nWhen forming the risk matrix, consider
some of the following examples\r\nand how they may potentially impact
the change:\r\n\r\n| Risk | Probability | Severity | Mitigation/Notes
|\r\n\r\n|---------------------------|-------------|----------|-------------------------|\r\n|
Multiple Spaces&mdash;unexpected behavior in non-default Kibana
Space.\r\n| Low | High | Integration tests will verify that all features
are still\r\nsupported in non-default Kibana Space and when user
switches between\r\nspaces. |\r\n| Multiple nodes&mdash;Elasticsearch
polling might have race conditions\r\nwhen multiple Kibana nodes are
polling for the same tasks. | High | Low\r\n| Tasks are idempotent, so
executing them multiple times will not result\r\nin logical error, but
will degrade performance. To test for this case we\r\nadd plenty of unit
tests around this logic and document manual testing\r\nprocedure. |\r\n|
Code should gracefully handle cases when feature X or plugin Y
are\r\ndisabled. | Medium | High | Unit tests will verify that any
feature flag\r\nor plugin combination still results in our service
operational. |\r\n| [See more potential
risk\r\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)
|\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for
breaking API changes and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)\r\n-
[ ] This will appear in the **Release Notes** and follow
the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by:
Cauê Marcondes
<55978943+cauemarcondes@users.noreply.github.com>\r\nCo-authored-by:
Nathan L Smith <nathan.smith@elastic.co>\r\nCo-authored-by: jennypavlova
<dzheni.pavlova@elastic.co>","sha":"c7b8ca00de0cec5cd99db6e4a218ad40dde27369"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196969","number":196969,"mergeCommit":{"message":"Fix
Typo: Change 'dashaboard' to 'dashboard' on APM-service Dashboards page
#195773 (#196969)\n\n**Title:** Fix Typo: Change 'dashaboard' to
'dashboard' on APM-service\r\nDashboards
page\r\n\r\n**Description:**\r\nThis PR fixes a typo on the
\"Dashboards\" page for APM-service. The typo\r\n\"dashaboard\" has been
corrected to \"dashboard\" to ensure proper\r\nfunctionality and
readability.\r\n\r\ncloses #195773\r\n\r\n**Changes Made:**\r\n-
Corrected the typo in the text \"To get started, add your
dashaboard\"\r\nto \"To get started, add your
dashboard.\"\r\n\r\n**Testing:**\r\n- Verified the change on the
Dashboards page for APM-service.\r\n- Ensured no other instances of the
typo exist in the codebase.\r\n\r\n**Release note:**\r\nFixes a typo on
the \"Dashboards\" page for APM-service, changing\r\n'dashaboard' to
'dashboard'.\r\n\r\n**Additional Notes:**\r\nNo additional
notes.\r\n\r\n\r\n## Summary\r\n\r\nSummarize your PR. If it involves
visual changes include a screenshot or\r\ngif.\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[
]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [x] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n- [x] Any UI touched in this PR is
usable by keyboard only (learn more\r\nabout [keyboard
accessibility](https://webaim.org/techniques/keyboard/))\r\n- [x] Any UI
touched in this PR does not create any new axe failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n-
[ ] If a plugin configuration key changed, check if it needs to
be\r\nallowlisted in the cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n-
[x] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[x] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n###
Risk Matrix\r\n\r\nDelete this section if it is not applicable to this
PR.\r\n\r\nBefore closing this PR, invite QA, stakeholders, and other
developers to\r\nidentify risks that should be tested prior to the
change/feature\r\nrelease.\r\n\r\nWhen forming the risk matrix, consider
some of the following examples\r\nand how they may potentially impact
the change:\r\n\r\n| Risk | Probability | Severity | Mitigation/Notes
|\r\n\r\n|---------------------------|-------------|----------|-------------------------|\r\n|
Multiple Spaces&mdash;unexpected behavior in non-default Kibana
Space.\r\n| Low | High | Integration tests will verify that all features
are still\r\nsupported in non-default Kibana Space and when user
switches between\r\nspaces. |\r\n| Multiple nodes&mdash;Elasticsearch
polling might have race conditions\r\nwhen multiple Kibana nodes are
polling for the same tasks. | High | Low\r\n| Tasks are idempotent, so
executing them multiple times will not result\r\nin logical error, but
will degrade performance. To test for this case we\r\nadd plenty of unit
tests around this logic and document manual testing\r\nprocedure. |\r\n|
Code should gracefully handle cases when feature X or plugin Y
are\r\ndisabled. | Medium | High | Unit tests will verify that any
feature flag\r\nor plugin combination still results in our service
operational. |\r\n| [See more potential
risk\r\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)
|\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for
breaking API changes and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)\r\n-
[ ] This will appear in the **Release Notes** and follow
the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by:
Cauê Marcondes
<55978943+cauemarcondes@users.noreply.github.com>\r\nCo-authored-by:
Nathan L Smith <nathan.smith@elastic.co>\r\nCo-authored-by: jennypavlova
<dzheni.pavlova@elastic.co>","sha":"c7b8ca00de0cec5cd99db6e4a218ad40dde27369"}}]}]
BACKPORT-->

Co-authored-by: Mohamed Nabeel <137497525+nabeelmohamed@users.noreply.github.com>
Co-authored-by: Gerard Soldevila <gerard.soldevila@elastic.co>
Co-authored-by: jennypavlova <dzheni.pavlova@elastic.co>
@kibanamachine kibanamachine added v8.15.4 and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:project-deploy-observability Create an Observability project 💝community release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation. v8.15.4 v8.16.0 v8.17.0 v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typo on "Dashboards" Page for APM-service

8 participants