Skip to content

[Entity Analytics] [Entity Store] Telemetry#196880

Merged
tiansivive merged 9 commits intoelastic:mainfrom
tiansivive:ea-telemetry-10566
Oct 29, 2024
Merged

[Entity Analytics] [Entity Store] Telemetry#196880
tiansivive merged 9 commits intoelastic:mainfrom
tiansivive:ea-telemetry-10566

Conversation

@tiansivive
Copy link
Copy Markdown
Contributor

@tiansivive tiansivive commented Oct 18, 2024 •
edited by kibanamachine
Loading

Summary

This PR adds telemetry for the Entity Store.
Client side tracks UI enablement actions, whilst Kibana side tracks execution time of the store initialisation process and execution time of the enrich policy task.
Finally we also track number of entities in the store

@tiansivive tiansivive added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Theme: entity_analytics Team:Entity Analytics Security Entity Analytics Team labels Oct 18, 2024
@hop-dev hop-dev added v9.0.0 v8.16.0 backport:version Backport to applied version labels v8.17.0 and removed backport:prev-minor labels Oct 18, 2024
@tiansivive tiansivive marked this pull request as ready for review October 21, 2024 13:45
@tiansivive tiansivive requested review from a team as code owners October 21, 2024 13:45
@tiansivive tiansivive requested a review from CAWilson94 October 21, 2024 13:45
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 21, 2024

Pinging @elastic/security-entity-analytics (Team:Entity Analytics)

@tiansivive tiansivive self-assigned this Oct 22, 2024
szaffarano
szaffarano approved these changes Oct 23, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@szaffarano szaffarano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

machadoum
machadoum reviewed Oct 24, 2024
View reviewed changes
x-pack/plugins/security_solution/public/common/lib/telemetry/constants.ts Outdated
Comment on lines +69 to +70
EntityStoreEnablement = 'Entity Store Enablement',
EntityStoreInit = 'Entity Store Initialized',
Copy link
Copy Markdown
Member

@machadoum machadoum Oct 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we rename these event names to be more UI specific? Like Enable button toggle or Enable button clicked

Copy link
Copy Markdown
Contributor Author

@tiansivive tiansivive Oct 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 28, 2024

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 6132 6133 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 20.5MB 20.5MB +372.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 87.6KB 88.4KB +763.0B

History

cc @tiansivive

@tiansivive tiansivive merged commit 67d96e3 into elastic:main Oct 29, 2024
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 29, 2024

Starting backport for target branches: 8.16, 8.x

https://github.com/elastic/kibana/actions/runs/11572685537

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 29, 2024
@tiansivive
[Entity Analytics] [Entity Store] Telemetry (elastic#196880)
e76ba81 
## Summary

This PR adds telemetry for the Entity Store.
Client side tracks UI enablement actions, whilst Kibana side tracks
execution time of the store initialisation process and execution time of
the enrich policy task.
Finally we also track number of entities in the store

(cherry picked from commit 67d96e3)
@kibanamachine kibanamachine mentioned this pull request Oct 29, 2024
Closed
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 29, 2024

💔 Some backports could not be created

Status Branch Result
❌ 8.16 Backport failed because of merge conflicts
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 196880

Questions ?

Please refer to the Backport tool documentation

tiansivive added a commit to tiansivive/kibana that referenced this pull request Oct 29, 2024
@tiansivive
[Entity Analytics] [Entity Store] Telemetry (elastic#196880)
d9ac4f8 
This PR adds telemetry for the Entity Store.
Client side tracks UI enablement actions, whilst Kibana side tracks
execution time of the store initialisation process and execution time of
the enrich policy task.
Finally we also track number of entities in the store
This was referenced Oct 30, 2024
Merged
Merged
tiansivive added a commit to tiansivive/kibana that referenced this pull request Oct 30, 2024
@tiansivive
[Entity Analytics] [Entity Store] Telemetry (elastic#196880)
2be3b29 
## Summary

This PR adds telemetry for the Entity Store.
Client side tracks UI enablement actions, whilst Kibana side tracks
execution time of the store initialisation process and execution time of
the enrich policy task.
Finally we also track number of entities in the store

(cherry picked from commit 67d96e3)

# Conflicts:
#	x-pack/plugins/security_solution/server/lib/entity_analytics/entity_store/entity_store_data_client.ts
tiansivive added a commit to tiansivive/kibana that referenced this pull request Oct 30, 2024
@tiansivive
[Entity Analytics] [Entity Store] Telemetry (elastic#196880)
33600b2 
## Summary

This PR adds telemetry for the Entity Store.
Client side tracks UI enablement actions, whilst Kibana side tracks
execution time of the store initialisation process and execution time of
the enrich policy task.
Finally we also track number of entities in the store

(cherry picked from commit 67d96e3)
tiansivive added a commit that referenced this pull request Oct 30, 2024
@tiansivive
[8.x] [Entity Analytics] [Entity Store] Telemetry (#196880) (#198347)
8e98784 
# Backport

This will backport the following commits from `main` to `8.x`:
 - [Entity Analytics] [Entity Store] Telemetry (#196880) (67d96e3)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Tiago Vila
Verde","email":"tiago.vilaverde@elastic.co"},"sourceCommit":{"committedDate":"2024-10-29T11:13:14Z","message":"[Entity
Analytics] [Entity Store] Telemetry (#196880)\n\n## Summary\r\n\r\nThis
PR adds telemetry for the Entity Store.\r\nClient side tracks UI
enablement actions, whilst Kibana side tracks\r\nexecution time of the
store initialisation process and execution time of\r\nthe enrich policy
task.\r\nFinally we also track number of entities in the
store","sha":"67d96e3585b690662750173898ce579c52a89522"},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[]}]
BACKPORT-->
tiansivive added a commit that referenced this pull request Oct 30, 2024
@tiansivive
[8.16] [Entity Analytics] [Entity Store] Telemetry (#196880) (#198354)
cdc6818 
# Backport

This will backport the following commits from `main` to `8.16`:
 - [Entity Analytics] [Entity Store] Telemetry (#196880) (67d96e3)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Tiago Vila
Verde","email":"tiago.vilaverde@elastic.co"},"sourceCommit":{"committedDate":"2024-10-29T11:13:14Z","message":"[Entity
Analytics] [Entity Store] Telemetry (#196880)\n\n## Summary\r\n\r\nThis
PR adds telemetry for the Entity Store.\r\nClient side tracks UI
enablement actions, whilst Kibana side tracks\r\nexecution time of the
store initialisation process and execution time of\r\nthe enrich policy
task.\r\nFinally we also track number of entities in the
store","sha":"67d96e3585b690662750173898ce579c52a89522"},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[]}]
BACKPORT-->
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 31, 2024
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 31, 2024

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@tiansivive tiansivive removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@szaffarano szaffarano szaffarano approved these changes

@machadoum machadoum machadoum approved these changes

@CAWilson94 CAWilson94 Awaiting requested review from CAWilson94 CAWilson94 was automatically assigned from elastic/security-entity-analytics

Assignees

@tiansivive tiansivive

Labels

backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:Entity Analytics Security Entity Analytics Team Theme: entity_analytics v8.16.0 v8.17.0 v9.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tiansivive @elasticmachine @kibanamachine @szaffarano @machadoum @hop-dev