Skip to content

[AI Assistant] Add assistant to Serverless Search#196832

Merged
sphilipse merged 21 commits intoelastic:mainfrom
sphilipse:search-assistant-serverless
Oct 25, 2024
Merged

[AI Assistant] Add assistant to Serverless Search#196832
sphilipse merged 21 commits intoelastic:mainfrom
sphilipse:search-assistant-serverless

Conversation

@sphilipse
Copy link
Copy Markdown
Member

@sphilipse sphilipse commented Oct 18, 2024 •
edited by kibanamachine
Loading

Summary

This adds the AI assistant to Serverless Elasticsearch. It also disables the knowledge base, and disables a few config values we don't want users to be able to set in that context.

@sphilipse sphilipse requested review from a team as code owners October 18, 2024 10:12
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:Obs AI Assistant Observability AI Assistant labels Oct 18, 2024
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 18, 2024

Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 18, 2024

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@sphilipse sphilipse added Team:Search backport:version Backport to applied version labels labels Oct 18, 2024
@sphilipse sphilipse added the release_note:skip Skip the PR/issue when compiling release notes label Oct 18, 2024
@elena-shostak elena-shostak self-requested a review October 18, 2024 11:18
elena-shostak
elena-shostak approved these changes Oct 18, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@elena-shostak elena-shostak left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

sphilipse and others added 4 commits October 21, 2024 13:09
@sphilipse @elena-shostak
Update x-pack/plugins/observability_solution/observability_ai_assista…
c4272ec 
…nt/server/service/knowledge_base_service/index.ts

Co-authored-by: Elena Shostak <165678770+elena-shostak@users.noreply.github.com>
@sphilipse
fix silly if/else error
7f2c3f7
@sphilipse
Fix storybook types
170472f
@sphilipse
Remove duplicate key
6610cd4
dgieselaar
dgieselaar approved these changes Oct 24, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@dgieselaar dgieselaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've got a couple of nits about returning early but that's it!

@sphilipse sphilipse enabled auto-merge (squash) October 25, 2024 08:54
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 25, 2024 •
edited
Loading

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
observabilityAiAssistantManagement 139 357 +218
searchAssistant 304 253 -51
total +167

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observabilityAIAssistantApp 238.7KB 238.9KB +179.0B
observabilityAiAssistantManagement 91.4KB 92.8KB +1.4KB
searchAssistant 179.7KB 161.8KB -18.0KB
total -16.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observabilityAiAssistantManagement 5.0KB 5.1KB +131.0B
searchAssistant 4.9KB 4.8KB -109.0B
total +22.0B
Unknown metric groups

miscellaneous assets size

id before after diff
searchAssistant 161.8KB 0.0B -161.8KB

History

@sphilipse sphilipse merged commit 3bc5e2d into elastic:main Oct 25, 2024
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 25, 2024

Starting backport for target branches: 8.16, 8.x

https://github.com/elastic/kibana/actions/runs/11516120933

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 25, 2024

💔 All backports failed

Status Branch Result
❌ 8.16 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.16:
- [AI Assistant] Set scope and rename to Observability and Search (#196322)
❌ 8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 196832

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 29, 2024
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 29, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 196832 locally

@sphilipse sphilipse added backport:version Backport to applied version labels and removed backport missing Added to PRs automatically when the are determined to be missing a backport. backport:version Backport to applied version labels labels Oct 29, 2024
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 29, 2024

Starting backport for target branches: 8.16, 8.x

https://github.com/elastic/kibana/actions/runs/11573093239

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 29, 2024

💔 All backports failed

Status Branch Result
❌ 8.16 An unhandled error occurred. Please see the logs for details
❌ 8.x An unhandled error occurred. Please see the logs for details

Manual backport

To create the backport manually run:

node scripts/backport --pr 196832

Questions ?

Please refer to the Backport tool documentation

@sphilipse sphilipse added backport:version Backport to applied version labels and removed backport:version Backport to applied version labels labels Oct 29, 2024
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 29, 2024

Starting backport for target branches: 8.16, 8.x

https://github.com/elastic/kibana/actions/runs/11577614842

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 29, 2024

💔 All backports failed

Status Branch Result
❌ 8.16 Backport failed because of merge conflicts
❌ 8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 196832

Questions ?

Please refer to the Backport tool documentation

@sphilipse sphilipse added backport:version Backport to applied version labels and removed backport:version Backport to applied version labels labels Oct 30, 2024
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 30, 2024

Starting backport for target branches: 8.16, 8.x

https://github.com/elastic/kibana/actions/runs/11591304619

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 30, 2024

💔 All backports failed

Status Branch Result
❌ 8.16 Backport failed because of merge conflicts
❌ 8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 196832

Questions ?

Please refer to the Backport tool documentation

This was referenced Oct 30, 2024
Merged
Merged
sphilipse added a commit to sphilipse/kibana that referenced this pull request Oct 30, 2024
@sphilipse
[AI Assistant] Add assistant to Serverless Search (elastic#196832)
327d648 
## Summary

This adds the AI assistant to Serverless Elasticsearch. It also disables
the knowledge base, and disables a few config values we don't want users
to be able to set in that context.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Elena Shostak <165678770+elena-shostak@users.noreply.github.com>
(cherry picked from commit 3bc5e2d)

# Conflicts:
#	config/serverless.es.yml
sphilipse added a commit to sphilipse/kibana that referenced this pull request Oct 30, 2024
@sphilipse
[AI Assistant] Add assistant to Serverless Search (elastic#196832)
13c1d91 
## Summary

This adds the AI assistant to Serverless Elasticsearch. It also disables
the knowledge base, and disables a few config values we don't want users
to be able to set in that context.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Elena Shostak <165678770+elena-shostak@users.noreply.github.com>
(cherry picked from commit 3bc5e2d)

# Conflicts:
#	config/serverless.es.yml
sphilipse added a commit that referenced this pull request Oct 30, 2024
@sphilipse
[8.x] [AI Assistant] Add assistant to Serverless Search (#196832) (#1…
0a5d490 
…98300)

# Backport

This will backport the following commits from `main` to `8.x`:
- [AI Assistant] Add assistant to Serverless Search (#196832) (3bc5e2d)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Sander
Philipse","email":"94373878+sphilipse@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-10-25T10:03:04Z","message":"[AI
Assistant] Add assistant to Serverless Search (#196832)\n\n##
Summary\r\n\r\nThis adds the AI assistant to Serverless Elasticsearch.
It also disables\r\nthe knowledge base, and disables a few config values
we don't want users\r\nto be able to set in that
context.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by:
Elena Shostak
<165678770+elena-shostak@users.noreply.github.com>","sha":"3bc5e2db73799dc9c7831b6f9da4a52063cf112f"},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[]}]
BACKPORT-->
sphilipse added a commit that referenced this pull request Oct 30, 2024
@sphilipse
[8.16] [AI Assistant] Add assistant to Serverless Search (#196832) (#…
bd29318 
…198301)

# Backport

This will backport the following commits from `main` to `8.16`:
- [AI Assistant] Add assistant to Serverless Search (#196832) (3bc5e2d)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Sander
Philipse","email":"94373878+sphilipse@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-10-25T10:03:04Z","message":"[AI
Assistant] Add assistant to Serverless Search (#196832)\n\n##
Summary\r\n\r\nThis adds the AI assistant to Serverless Elasticsearch.
It also disables\r\nthe knowledge base, and disables a few config values
we don't want users\r\nto be able to set in that
context.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by:
Elena Shostak
<165678770+elena-shostak@users.noreply.github.com>","sha":"3bc5e2db73799dc9c7831b6f9da4a52063cf112f"},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TattdCodeMonkey TattdCodeMonkey TattdCodeMonkey left review comments

@joemcelroy joemcelroy joemcelroy approved these changes

@jloleysens jloleysens jloleysens approved these changes

@elena-shostak elena-shostak elena-shostak approved these changes

+1 more reviewer

@dgieselaar dgieselaar dgieselaar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport:version Backport to applied version labels ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:Obs AI Assistant Observability AI Assistant Team:Search v8.16.0 v8.17.0 v9.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@sphilipse @elasticmachine @kibanamachine @joemcelroy @dgieselaar @TattdCodeMonkey @jloleysens @elena-shostak