[Security Solution] Clean up external link text in a general way#196309
Merged
maximpn merged 2 commits intoelastic:mainfrom Oct 16, 2024
Merged
[Security Solution] Clean up external link text in a general way#196309maximpn merged 2 commits intoelastic:mainfrom
maximpn merged 2 commits intoelastic:mainfrom
Conversation
Contributor
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Contributor
|
Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management) |
Contributor
💚 Build Succeeded
Metrics [docs]
History
cc @maximpn |
MadameSheema
approved these changes
Oct 16, 2024
Contributor
|
Starting backport for target branches: 8.17, 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 16, 2024
…stic#196309) ## Summary This PR generalizes external link text cleanup in `removeExternalLinkText`. ## Details Recent Rule Management [periodic pipeline failure](https://buildkite.com/elastic/security-serverless-quality-gate-kibana-periodic/builds/1209#job-01928e56-28f3-4b45-8f9f-7158b324c115) was caused by merging back elastic#195525. Despite EUI changes were [addressed](https://github.com/elastic/kibana/pull/195525/files#diff-8d47b006a91beb2c5074560dbcd42eecef96173e03ffeec7c726dd322425f760) in our test utility it wasn't properly picked up. The problem is fixed in a more general way. (cherry picked from commit daf4aae)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 16, 2024
#196309) (#196502) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] Clean up external link text in a general way (#196309)](#196309) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Maxim Palenov","email":"maxim.palenov@elastic.co"},"sourceCommit":{"committedDate":"2024-10-16T09:00:18Z","message":"[Security Solution] Clean up external link text in a general way (#196309)\n\n## Summary\r\n\r\nThis PR generalizes external link text cleanup in `removeExternalLinkText`. \r\n\r\n## Details\r\n\r\nRecent Rule Management [periodic pipeline failure](https://buildkite.com/elastic/security-serverless-quality-gate-kibana-periodic/builds/1209#job-01928e56-28f3-4b45-8f9f-7158b324c115) was caused by merging back #195525. Despite EUI changes were [addressed](https://github.com/elastic/kibana/pull/195525/files#diff-8d47b006a91beb2c5074560dbcd42eecef96173e03ffeec7c726dd322425f760) in our test utility it wasn't properly picked up. The problem is fixed in a more general way.","sha":"daf4aae6aa202fd1148beea269939090137b659a","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","release_note:skip","v9.0.0","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","backport:prev-minor","v8.17.0"],"title":"[Security Solution] Clean up external link text in a general way","number":196309,"url":"https://github.com/elastic/kibana/pull/196309","mergeCommit":{"message":"[Security Solution] Clean up external link text in a general way (#196309)\n\n## Summary\r\n\r\nThis PR generalizes external link text cleanup in `removeExternalLinkText`. \r\n\r\n## Details\r\n\r\nRecent Rule Management [periodic pipeline failure](https://buildkite.com/elastic/security-serverless-quality-gate-kibana-periodic/builds/1209#job-01928e56-28f3-4b45-8f9f-7158b324c115) was caused by merging back #195525. Despite EUI changes were [addressed](https://github.com/elastic/kibana/pull/195525/files#diff-8d47b006a91beb2c5074560dbcd42eecef96173e03ffeec7c726dd322425f760) in our test utility it wasn't properly picked up. The problem is fixed in a more general way.","sha":"daf4aae6aa202fd1148beea269939090137b659a"}},"sourceBranch":"main","suggestedTargetBranches":["8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196309","number":196309,"mergeCommit":{"message":"[Security Solution] Clean up external link text in a general way (#196309)\n\n## Summary\r\n\r\nThis PR generalizes external link text cleanup in `removeExternalLinkText`. \r\n\r\n## Details\r\n\r\nRecent Rule Management [periodic pipeline failure](https://buildkite.com/elastic/security-serverless-quality-gate-kibana-periodic/builds/1209#job-01928e56-28f3-4b45-8f9f-7158b324c115) was caused by merging back #195525. Despite EUI changes were [addressed](https://github.com/elastic/kibana/pull/195525/files#diff-8d47b006a91beb2c5074560dbcd42eecef96173e03ffeec7c726dd322425f760) in our test utility it wasn't properly picked up. The problem is fixed in a more general way.","sha":"daf4aae6aa202fd1148beea269939090137b659a"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Maxim Palenov <maxim.palenov@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR generalizes external link text cleanup in
removeExternalLinkText.Details
Recent Rule Management periodic pipeline failure was caused by merging back #195525. Despite EUI changes were addressed in our test utility it wasn't properly picked up. The problem is fixed in a more general way.