[Lens] Disable config axis side and color picker when groupid is breakdown and collaseFn enable#195845
Merged
mbondyra merged 4 commits intoelastic:mainfrom Oct 14, 2024
Conversation
…kdown and collaseFn enable
mbondyra
approved these changes
Oct 11, 2024
Contributor
mbondyra
left a comment
There was a problem hiding this comment.
Thank you for your contribution @linghaoSu! I've added a test to this usecase and I think we're good to go 🎉
Contributor
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
Contributor
|
/ci |
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
|
Contributor
Author
|
Hi @mbondyra, thanks for your review! It looks like the CI task 'buildkite/docs-build-pr' hasn't started yet, and I don't have the permission to start it. Could you help me get it started? |
Contributor
|
Starting backport for target branches: 8.x |
Contributor
|
Added the correct backport label to initiate the process as this PR was blocking me from backporting: #196025 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 15, 2024
…kdown and collaseFn enable (elastic#195845) ## Summary Fixes elastic#195481 For XY charts only, when opening the breakdown dimension editor, we disable the color picker and axis side configuration. ## Before  ## After   https://github.com/user-attachments/assets/05ee0e8e-713b-4eb3-a1ef-bf7418226409 --------- Co-authored-by: Marta Bondyra <4283304+mbondyra@users.noreply.github.com> Co-authored-by: Nick Partridge <nicholas.partridge@elastic.co> (cherry picked from commit 4c4cb1e)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 15, 2024
…s breakdown and collaseFn enable (#195845) (#196247) # Backport This will backport the following commits from `main` to `8.x`: - [[Lens] Disable config axis side and color picker when groupid is breakdown and collaseFn enable (#195845)](#195845) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Linghao Su","email":"linghao.su@daocloud.io"},"sourceCommit":{"committedDate":"2024-10-14T07:54:11Z","message":"[Lens] Disable config axis side and color picker when groupid is breakdown and collaseFn enable (#195845)\n\n## Summary\r\nFixes https://github.com/elastic/kibana/issues/195481\r\n\r\nFor XY charts only, when opening the breakdown dimension editor, we\r\ndisable the color picker and axis side configuration.\r\n\r\n## Before\r\n\r\n\r\n\r\n\r\n## After\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/05ee0e8e-713b-4eb3-a1ef-bf7418226409\r\n\r\n---------\r\n\r\nCo-authored-by: Marta Bondyra <4283304+mbondyra@users.noreply.github.com>\r\nCo-authored-by: Nick Partridge <nicholas.partridge@elastic.co>","sha":"4c4cb1e1678130c300c93e00061f0478047aff28","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Visualizations","Feature:Lens","💝community","v9.0.0","backport:prev-minor","v8.16.0"],"title":"[Lens] Disable config axis side and color picker when groupid is breakdown and collaseFn enable","number":195845,"url":"https://github.com/elastic/kibana/pull/195845","mergeCommit":{"message":"[Lens] Disable config axis side and color picker when groupid is breakdown and collaseFn enable (#195845)\n\n## Summary\r\nFixes https://github.com/elastic/kibana/issues/195481\r\n\r\nFor XY charts only, when opening the breakdown dimension editor, we\r\ndisable the color picker and axis side configuration.\r\n\r\n## Before\r\n\r\n\r\n\r\n\r\n## After\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/05ee0e8e-713b-4eb3-a1ef-bf7418226409\r\n\r\n---------\r\n\r\nCo-authored-by: Marta Bondyra <4283304+mbondyra@users.noreply.github.com>\r\nCo-authored-by: Nick Partridge <nicholas.partridge@elastic.co>","sha":"4c4cb1e1678130c300c93e00061f0478047aff28"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195845","number":195845,"mergeCommit":{"message":"[Lens] Disable config axis side and color picker when groupid is breakdown and collaseFn enable (#195845)\n\n## Summary\r\nFixes https://github.com/elastic/kibana/issues/195481\r\n\r\nFor XY charts only, when opening the breakdown dimension editor, we\r\ndisable the color picker and axis side configuration.\r\n\r\n## Before\r\n\r\n\r\n\r\n\r\n## After\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/05ee0e8e-713b-4eb3-a1ef-bf7418226409\r\n\r\n---------\r\n\r\nCo-authored-by: Marta Bondyra <4283304+mbondyra@users.noreply.github.com>\r\nCo-authored-by: Nick Partridge <nicholas.partridge@elastic.co>","sha":"4c4cb1e1678130c300c93e00061f0478047aff28"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Linghao Su <linghao.su@daocloud.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #195481
For XY charts only, when opening the breakdown dimension editor, we disable the color picker and axis side configuration.
Before
After
20241011-123913.mp4