Skip to content

[Cloud Security] Refactoring tests#195675

Merged
kfirpeled merged 3 commits intoelastic:mainfrom
kfirpeled:cspm/refactor_serverless_api_test_utils
Oct 10, 2024
Merged

[Cloud Security] Refactoring tests#195675
kfirpeled merged 3 commits intoelastic:mainfrom
kfirpeled:cspm/refactor_serverless_api_test_utils

Conversation

@kfirpeled
Copy link
Copy Markdown
Contributor

@kfirpeled kfirpeled commented Oct 9, 2024

Summary

Removed duplicated code cloud_security_posture_api serverless tests folder

Checklist

@kfirpeled kfirpeled added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor labels Oct 9, 2024
@kfirpeled kfirpeled requested a review from a team as a code owner October 9, 2024 20:29
Copy link
Copy Markdown
Contributor

@opauloh opauloh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EsIndexDataProvider 💯

@kibanamachine
Copy link
Copy Markdown
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#7117

[❌] x-pack/test/api_integration/apis/cloud_security_posture/config.ts: 0/25 tests passed.
[❌] x-pack/test_serverless/api_integration/test_suites/security/config.ts: 0/25 tests passed.

see run history

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

@kibanamachine
Copy link
Copy Markdown
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7121

[✅] x-pack/test/api_integration/apis/cloud_security_posture/config.ts: 25/25 tests passed.
[✅] x-pack/test_serverless/api_integration/test_suites/security/config.ts: 25/25 tests passed.

see run history

@kfirpeled kfirpeled merged commit e6c2750 into elastic:main Oct 10, 2024
@kibanamachine
Copy link
Copy Markdown
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11274644414

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 10, 2024
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 10, 2024
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Cloud Security] Refactoring tests
(#195675)](#195675)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Kfir
Peled","email":"61654899+kfirpeled@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-10-10T13:05:37Z","message":"[Cloud
Security] Refactoring tests
(#195675)","sha":"e6c2750151d04152f8270d56279048e6f019696d","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor"],"title":"[Cloud
Security] Refactoring
tests","number":195675,"url":"https://github.com/elastic/kibana/pull/195675","mergeCommit":{"message":"[Cloud
Security] Refactoring tests
(#195675)","sha":"e6c2750151d04152f8270d56279048e6f019696d"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195675","number":195675,"mergeCommit":{"message":"[Cloud
Security] Refactoring tests
(#195675)","sha":"e6c2750151d04152f8270d56279048e6f019696d"}}]}]
BACKPORT-->

Co-authored-by: Kfir Peled <61654899+kfirpeled@users.noreply.github.com>
@bhavyarm bhavyarm added the Team:Cloud Security Cloud Security team related label Oct 18, 2024
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related v8.16.0 v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants