Skip to content

[Search] Update search integrations#195628

Merged
navarone-feekery merged 6 commits intoelastic:mainfrom
navarone-feekery:update-search-integrations
Oct 11, 2024
Merged

[Search] Update search integrations#195628
navarone-feekery merged 6 commits intoelastic:mainfrom
navarone-feekery:update-search-integrations

Conversation

@navarone-feekery
Copy link
Copy Markdown
Contributor

@navarone-feekery navarone-feekery commented Oct 9, 2024 •
edited
Loading

Summary

Make the following changes to the integrations page:

  • Rename enterprise_search category to search
  • Remove Application Search tag
  • Remove the JSON tile entirely

@navarone-feekery navarone-feekery added Team:EnterpriseSearch v8.16.0 release_note:skip Skip the PR/issue when compiling release notes labels Oct 9, 2024
@navarone-feekery navarone-feekery marked this pull request as ready for review October 9, 2024 15:18
@navarone-feekery navarone-feekery requested review from a team as code owners October 9, 2024 15:18
@navarone-feekery navarone-feekery added the backport:skip This PR does not require backporting label Oct 9, 2024
sphilipse
sphilipse reviewed Oct 10, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@sphilipse sphilipse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of removing the 'enterprise_search' category, we should probably just rename it to 'search' for clarity. It's already called 'Search' in the UI, not 'Enterprise Search'. See:

src/plugins/custom_integrations/common/index.ts

x-pack/plugins/enterprise_search/server/integrations.ts Outdated
defaultMessage: 'Add search to your website with the web crawler.',
}),
categories: ['enterprise_search', 'app_search', 'web', 'elastic_stack', 'crawler'],
categories: ['app_search', 'web', 'elastic_stack', 'crawler'],
Copy link
Copy Markdown
Member

@sphilipse sphilipse Oct 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're keeping the app_search category?

Copy link
Copy Markdown
Contributor Author

@navarone-feekery navarone-feekery Oct 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that we can remove it, so I've included that in this PR.

@navarone-feekery
Copy link
Copy Markdown
Contributor Author

navarone-feekery commented Oct 10, 2024

Instead of removing the 'enterprise_search' category, we should probably just rename it to 'search' for clarity. It's already called 'Search' in the UI, not 'Enterprise Search'. See:

@sphilipse I've added the category back and renamed it all to search instead of enterprise-search. The sub-categories are all grouped under the new category and it reflects correctly in the URL.

Gif:
out

navarone-feekery
navarone-feekery commented Oct 10, 2024
View reviewed changes
test/api_integration/apis/custom_integration/integrations.ts
expect(resp.body).to.be.an('array');

expect(resp.body.length).to.be(56);
expect(resp.body.length).to.be(55);
Copy link
Copy Markdown
Contributor Author

@navarone-feekery navarone-feekery Oct 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This total was reduced because of the removal of the App Search JSON integration.

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 10, 2024

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
customIntegrations 252 249 -3

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
customIntegrations 10.3KB 10.1KB -169.0B
searchConnectors 24.9KB 24.5KB -374.0B
total -543.0B
Unknown metric groups

API count

id before after diff
customIntegrations 271 268 -3

History

@navarone-feekery navarone-feekery requested review from a team and sphilipse October 11, 2024 07:30
@navarone-feekery navarone-feekery enabled auto-merge (squash) October 11, 2024 11:13
nchaulet
nchaulet approved these changes Oct 11, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM 🚀

@navarone-feekery navarone-feekery merged commit 56f93fa into elastic:main Oct 11, 2024
@navarone-feekery navarone-feekery deleted the update-search-integrations branch October 11, 2024 12:34
@kibanamachine kibanamachine mentioned this pull request Oct 12, 2024
Merged
6 tasks
@navarone-feekery navarone-feekery restored the update-search-integrations branch October 14, 2024 08:17
@navarone-feekery navarone-feekery mentioned this pull request Oct 14, 2024
Merged
@navarone-feekery navarone-feekery deleted the update-search-integrations branch October 14, 2024 08:26
navarone-feekery added a commit that referenced this pull request Oct 14, 2024
@navarone-feekery
[8.x] [Search] Update search integrations (#195628) (#196058)
1a3efcc 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Search] Update search integrations
(#195628)](#195628)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nchaulet nchaulet nchaulet approved these changes

@sphilipse sphilipse sphilipse approved these changes

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.16.0 v9.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@navarone-feekery @elasticmachine @nchaulet @sphilipse @kibanamachine