[Onboarding][Auto-detect] Update design for supported integrations badges#195351
Merged
mykolaharmash merged 3 commits intoelastic:mainfrom Oct 14, 2024
Merged
Conversation
flash1293
reviewed
Oct 8, 2024
| content={ | ||
| <EuiText size="s"> | ||
| <ul> | ||
| {SUPPORTED_INTEGRATIONS_LIST.map((integration) => ( |
Contributor
There was a problem hiding this comment.
Shouldn't the tooltip only list the ones that are not already spelled out individually?
Contributor
Author
There was a problem hiding this comment.
I took this from the desings. At first I thought the same, that it should have only the remaining services, but it seems convenient to have the full list in one place, I suspect that was the logic behind the designs.
thomheymann
approved these changes
Oct 14, 2024
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Async chunks
Unknown metric groupsmiscellaneous assets size
History
|
Contributor
|
Starting backport for target branches: 8.15, 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 14, 2024
…dges (elastic#195351) Closes elastic/observability-dev#4007 Updates integration badges according to [the latest designs](https://www.figma.com/design/CPhMyRNOgo0wsEiaIMZJ14/Onboarding-Quick-Starts?node-id=3015-58062&t=5tvnrPIOkfg7xAJp-1).  (cherry picked from commit 0226634)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 14, 2024
…ons badges (#195351) (#196124) # Backport This will backport the following commits from `main` to `8.x`: - [[Onboarding][Auto-detect] Update design for supported integrations badges (#195351)](#195351) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Mykola Harmash","email":"mykola.harmash@gmail.com"},"sourceCommit":{"committedDate":"2024-10-14T12:14:23Z","message":"[Onboarding][Auto-detect] Update design for supported integrations badges (#195351)\n\nCloses https://github.com/elastic/observability-dev/issues/4007\r\n\r\nUpdates integration badges according to [the latest\r\ndesigns](https://www.figma.com/design/CPhMyRNOgo0wsEiaIMZJ14/Onboarding-Quick-Starts?node-id=3015-58062&t=5tvnrPIOkfg7xAJp-1).\r\n\r\n","sha":"02266345cb4199342867e3d9d5718090297f5700","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-major","ci:project-deploy-observability","v8.16.0"],"title":"[Onboarding][Auto-detect] Update design for supported integrations badges","number":195351,"url":"https://github.com/elastic/kibana/pull/195351","mergeCommit":{"message":"[Onboarding][Auto-detect] Update design for supported integrations badges (#195351)\n\nCloses https://github.com/elastic/observability-dev/issues/4007\r\n\r\nUpdates integration badges according to [the latest\r\ndesigns](https://www.figma.com/design/CPhMyRNOgo0wsEiaIMZJ14/Onboarding-Quick-Starts?node-id=3015-58062&t=5tvnrPIOkfg7xAJp-1).\r\n\r\n","sha":"02266345cb4199342867e3d9d5718090297f5700"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195351","number":195351,"mergeCommit":{"message":"[Onboarding][Auto-detect] Update design for supported integrations badges (#195351)\n\nCloses https://github.com/elastic/observability-dev/issues/4007\r\n\r\nUpdates integration badges according to [the latest\r\ndesigns](https://www.figma.com/design/CPhMyRNOgo0wsEiaIMZJ14/Onboarding-Quick-Starts?node-id=3015-58062&t=5tvnrPIOkfg7xAJp-1).\r\n\r\n","sha":"02266345cb4199342867e3d9d5718090297f5700"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Mykola Harmash <mykola.harmash@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/elastic/observability-dev/issues/4007
Updates integration badges according to the latest designs.