[Search profiler] Migrate ace to monaco by sabarasaba · Pull Request #195343 · elastic/kibana

sabarasaba · 2024-10-08T04:15:13Z

Summary

As part of the effort being made with #194533, this PR migrates the usage of the old Ace editor into monaco.

Screenshots

sabarasaba · 2024-10-08T04:17:50Z

@elasticmachine merge upstream

…fix'

elasticmachine · 2024-10-08T07:55:42Z

Pinging @elastic/kibana-management (Team:Kibana Management)

ElenaStoeva

Thanks for doing this long-standing task @sabarasaba! Tested locally and it looks great! Changes also lgtm.

~~I don't see any existing functional tests for Search Profiler. Shall we add some?~~ Edit: I just saw that there are actually tests and they are failing in CI so might just need updating. 😅

sabarasaba · 2024-10-09T06:08:32Z

@elasticmachine merge upstream

elasticmachine · 2024-10-09T12:25:05Z

💚 Build Succeeded

Buildkite Build
Commit: 605ef41

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`searchprofiler`	91	78	-13

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`searchprofiler`	161.2KB	48.2KB	-113.0KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`searchprofiler`	16.0KB	15.5KB	-486.0B

History

cc @sabarasaba

MichaelMarcialis

Code review only. LGTM!

kibanamachine · 2024-10-10T09:20:49Z

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11271145664

kibanamachine · 2024-10-10T09:20:49Z

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11271145817

sabarasaba · 2024-10-10T09:22:19Z

💚 All backports created successfully

Status	Branch	Result
✅	8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

(cherry picked from commit f2b9348)

kibanamachine · 2024-10-10T09:25:31Z

💚 All backports created successfully

Status	Branch	Result
✅	8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

(cherry picked from commit f2b9348)

kibanamachine · 2024-10-10T09:25:52Z

💚 All backports created successfully

Status	Branch	Result
✅	8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

# Backport This will backport the following commits from `main` to `8.x`: - [[Search profiler] Migrate ace to monaco (#195343)](#195343)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)  Co-authored-by: Ignacio Rivas <rivasign@gmail.com>

Contributes to: elastic#194817 Why I assigned them: Assigned advanced_settings due to elastic#175255 Assigned dashboard_controls due to elastic#190797 Assigned dashboard_links due to elastic#174772 Assigned dashboard_panel_options due to elastic#178596 Assigned grok_debugger due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/grokdebugger/kibana.jsonc#L4 Assigned helpers due to elastic#164341 (call site) Assigned home due to elastic#103192 Assigned index_lifecycle_management due to elastic#116207 Assigned ingest_node_pipelines due to elastic#113783 Assigned kibana_overview due to https://github.com/elastic/kibana/blob/f00ac7a8a21463e6bb4a2784c3a3884f36c62900/x-pack/plugins/grokdebugger/kibana.jsonc#L4 Assigned management due to elastic#165705 Assigned painless_lab due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/painless_lab/kibana.jsonc#L4 Assigned search_profiler due to elastic#195343 Assigned uptime due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/observability_solution/uptime/kibana.jsonc#L4 Assigned lens due to elastic#175893 Assigned ml_anomaly_detection due to elastic#162126 Assigned canvas due to elastic#164376 Assigned cc replication due to elastic#149069 Assigned enterpise search due to elastic#79359 Assigned graph to due elastic#190797 Assigned license_management due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/license_management/kibana.jsonc#L4 Assigned maps due to elastic#155161 Assigned observability due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/observability_solution/observability/kibana.jsonc#L4 Assigned remote clusters due to elastic#96989 Assigned reporting due to elastic#121435 Assigned rollup_jobs due to https://github.com/elastic/kibana/blob/d57bc9a5d7d64f86b550eff7997605a3090aee9a/x-pack/plugins/rollup/kibana.jsonc#L4 Assigned watcher due to elastic#119717

## Summary Assign files within `x-pack/test/accessibility/apps/group[1|2|3]` ### Why I assigned them: Assigned advanced_settings due to #175255 Assigned dashboard_controls due to #190797 Assigned dashboard_links due to #174772 Assigned dashboard_panel_options due to #178596 Assigned grok_debugger due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/grokdebugger/kibana.jsonc#L4 Assigned helpers due to #164341 (call site) Assigned home due to #103192 Assigned index_lifecycle_management due to #116207 Assigned ingest_node_pipelines due to #113783 Assigned kibana_overview due to https://github.com/elastic/kibana/blob/f00ac7a8a21463e6bb4a2784c3a3884f36c62900/x-pack/plugins/grokdebugger/kibana.jsonc#L4 Assigned management due to #165705 Assigned painless_lab due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/painless_lab/kibana.jsonc#L4 Assigned search_profiler due to #195343 Assigned uptime due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/observability_solution/uptime/kibana.jsonc#L4 Assigned lens due to #175893 Assigned ml_anomaly_detection due to #162126 Assigned canvas due to #164376 Assigned cc replication due to #149069 Assigned enterpise search due to #79359 Assigned graph to due #190797 Assigned license_management due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/license_management/kibana.jsonc#L4 Assigned maps due to #155161 Assigned observability due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/observability_solution/observability/kibana.jsonc#L4 Assigned remote clusters due to #96989 Assigned reporting due to #121435 Assigned rollup_jobs due to https://github.com/elastic/kibana/blob/d57bc9a5d7d64f86b550eff7997605a3090aee9a/x-pack/plugins/rollup/kibana.jsonc#L4 Assigned watcher due to #119717 Contributes to: #194817 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Rodney Norris <rodney@tattdcodemonkey.com>

sabarasaba and others added 2 commits October 8, 2024 06:13

Migrate ace to monaco

1a0c52f

commit with @elastic email

9df0c6e

sabarasaba added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// release_note:skip Skip the PR/issue when compiling release notes Feature:Search Profiler backport:skip This PR does not require backporting labels Oct 8, 2024

sabarasaba self-assigned this Oct 8, 2024

sabarasaba mentioned this pull request Oct 7, 2024

Remove Ace editor in favour of Monaco #194533

Closed

elasticmachine and others added 2 commits October 8, 2024 06:17

Merge branch 'main' into search_profiler-migrate_ace_to_monaco

bc5c890

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

01eb12e

…fix'

sabarasaba marked this pull request as ready for review October 8, 2024 07:55

sabarasaba requested review from a team as code owners October 8, 2024 07:55

ElenaStoeva approved these changes Oct 8, 2024

View reviewed changes

sabarasaba added 3 commits October 8, 2024 13:58

Fix tests

94a1975

Fix linter issue

3139c52

Refactor test index usage

a5b473d

elasticmachine and others added 3 commits October 9, 2024 08:08

Merge branch 'main' into search_profiler-migrate_ace_to_monaco

180a838

Remove unused dep

5b2ab2a

Fix test

605ef41

MichaelMarcialis approved these changes Oct 9, 2024

View reviewed changes

sabarasaba merged commit f2b9348 into elastic:main Oct 9, 2024

kibanamachine added the v9.0.0 label Oct 9, 2024

sabarasaba added backport:prev-minor and removed backport:skip This PR does not require backporting labels Oct 10, 2024

sabarasaba added v8.16.0 and removed v8.16.0 labels Oct 10, 2024

sabarasaba mentioned this pull request Oct 10, 2024

[8.x] [Search profiler] Migrate ace to monaco (#195343) #195718

Closed

sabarasaba added a commit to sabarasaba/kibana that referenced this pull request Oct 10, 2024

[Search profiler] Migrate ace to monaco (elastic#195343)

6c7f5da

(cherry picked from commit f2b9348)

kibanamachine mentioned this pull request Oct 10, 2024

[8.x] [Search profiler] Migrate ace to monaco (#195343) #195724

Merged

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 10, 2024

[Search profiler] Migrate ace to monaco (elastic#195343)

60bb7c8

(cherry picked from commit f2b9348)

wayneseymour mentioned this pull request Oct 11, 2024

[FTR][Ownership] Assign ally/grps 1,2 & 3 #195964

Merged

alisonelizabeth mentioned this pull request Oct 24, 2024

[Search profiler] Profile button does not display on smaller screens #197698

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Search profiler] Migrate ace to monaco#195343

[Search profiler] Migrate ace to monaco#195343
sabarasaba merged 10 commits intoelastic:mainfrom
sabarasaba:search_profiler-migrate_ace_to_monaco

sabarasaba commented Oct 8, 2024 •

edited by kibanamachine

Loading

Uh oh!

sabarasaba commented Oct 8, 2024

Uh oh!

elasticmachine commented Oct 8, 2024

Uh oh!

ElenaStoeva left a comment •

edited

Loading

Uh oh!

sabarasaba commented Oct 9, 2024

Uh oh!

elasticmachine commented Oct 9, 2024

Uh oh!

MichaelMarcialis left a comment

Uh oh!

kibanamachine commented Oct 10, 2024

Uh oh!

kibanamachine commented Oct 10, 2024

Uh oh!

sabarasaba commented Oct 10, 2024

Uh oh!

kibanamachine commented Oct 10, 2024

Uh oh!

kibanamachine commented Oct 10, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

sabarasaba commented Oct 8, 2024 • edited by kibanamachine Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

sabarasaba commented Oct 8, 2024

Uh oh!

elasticmachine commented Oct 8, 2024

Uh oh!

ElenaStoeva left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sabarasaba commented Oct 9, 2024

Uh oh!

elasticmachine commented Oct 9, 2024

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Page load bundle

History

Uh oh!

MichaelMarcialis left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Oct 10, 2024

Uh oh!

kibanamachine commented Oct 10, 2024

Uh oh!

sabarasaba commented Oct 10, 2024

💚 All backports created successfully

Questions ?

Uh oh!

kibanamachine commented Oct 10, 2024

💚 All backports created successfully

Questions ?

Uh oh!

kibanamachine commented Oct 10, 2024

💚 All backports created successfully

Questions ?

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

sabarasaba commented Oct 8, 2024 •

edited by kibanamachine

Loading

ElenaStoeva left a comment •

edited

Loading