[Index management] Add locator for deep linking into datastreams flyout#195299
Merged
sabarasaba merged 6 commits intoelastic:mainfrom Oct 8, 2024
Merged
[Index management] Add locator for deep linking into datastreams flyout#195299sabarasaba merged 6 commits intoelastic:mainfrom
sabarasaba merged 6 commits intoelastic:mainfrom
Conversation
Contributor
⏳ Build in-progress, with failures
Failed CI Stepscc @sabarasaba |
Contributor
|
Pinging @elastic/kibana-management (Team:Kibana Management) |
ElenaStoeva
reviewed
Oct 8, 2024
Contributor
ElenaStoeva
left a comment
There was a problem hiding this comment.
Thanks for working on this @sabarasaba! Code changes lgtm. Is there a way to manually test the added locator in the UI?
Member
Author
Thanks for reviewing @ElenaStoeva! Not really since its up to the requesting team to implement, the only way you can do so is by temporarily consuming the locator from another plugin. |
ElenaStoeva
approved these changes
Oct 8, 2024
Contributor
ElenaStoeva
left a comment
There was a problem hiding this comment.
I understand, thanks for clarifying! We have unit tests so I think we're good.
neptunian
added a commit
that referenced
this pull request
Oct 9, 2024
## Summary add locator to link to data stream management recently made available #195299
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 9, 2024
…95433) ## Summary add locator to link to data stream management recently made available elastic#195299 (cherry picked from commit ee4815a)
Contributor
|
Starting backport for target branches: 8.x |
Contributor
|
Starting backport for target branches: 8.x |
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 14, 2024
…ut (elastic#195299) (cherry picked from commit 17ae71b)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 14, 2024
…s flyout (#195299) (#196123) # Backport This will backport the following commits from `main` to `8.x`: - [[Index management] Add locator for deep linking into datastreams flyout (#195299)](#195299) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ignacio Rivas","email":"rivasign@gmail.com"},"sourceCommit":{"committedDate":"2024-10-08T12:36:55Z","message":"[Index management] Add locator for deep linking into datastreams flyout (#195299)","sha":"17ae71b3d9008bc41582c8c92e1c3dadddd2e38b","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Index Management","Team:Kibana Management","release_note:skip","v9.0.0","backport:prev-minor"],"title":"[Index management] Add locator for deep linking into datastreams flyout","number":195299,"url":"https://github.com/elastic/kibana/pull/195299","mergeCommit":{"message":"[Index management] Add locator for deep linking into datastreams flyout (#195299)","sha":"17ae71b3d9008bc41582c8c92e1c3dadddd2e38b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195299","number":195299,"mergeCommit":{"message":"[Index management] Add locator for deep linking into datastreams flyout (#195299)","sha":"17ae71b3d9008bc41582c8c92e1c3dadddd2e38b"}}]}] BACKPORT--> Co-authored-by: Ignacio Rivas <rivasign@gmail.com>
kibanamachine
added a commit
that referenced
this pull request
Oct 14, 2024
…5433) (#195555) # Backport This will backport the following commits from `main` to `8.x`: - [[Data Usage] add locator to link to data stream management (#195433)](#195433) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sandra G","email":"neptunian@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-10-09T09:47:16Z","message":"[Data Usage] add locator to link to data stream management (#195433)\n\n## Summary\r\n\r\nadd locator to link to data stream management recently made available\r\nhttps://github.com//pull/195299","sha":"ee4815a570e4ac1151deec1eb28437ec585411b6","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor"],"title":"[Data Usage] add locator to link to data stream management","number":195433,"url":"https://github.com/elastic/kibana/pull/195433","mergeCommit":{"message":"[Data Usage] add locator to link to data stream management (#195433)\n\n## Summary\r\n\r\nadd locator to link to data stream management recently made available\r\nhttps://github.com//pull/195299","sha":"ee4815a570e4ac1151deec1eb28437ec585411b6"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195433","number":195433,"mergeCommit":{"message":"[Data Usage] add locator to link to data stream management (#195433)\n\n## Summary\r\n\r\nadd locator to link to data stream management recently made available\r\nhttps://github.com//pull/195299","sha":"ee4815a570e4ac1151deec1eb28437ec585411b6"}}]}] BACKPORT--> Co-authored-by: Sandra G <neptunian@users.noreply.github.com> Co-authored-by: Ash <1849116+ashokaditya@users.noreply.github.com> Co-authored-by: Yuliia Naumenko <jo.naumenko@gmail.com>
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #195083
Summary
This PR adds a url locator that allows consumers to deep link into data streams details flyout.