github-actions: undeploy observability deployments using ephemeral GH tokens#195215
Merged
v1v merged 1 commit intoelastic:mainfrom Oct 7, 2024
Merged
Conversation
reakaleek
approved these changes
Oct 7, 2024
Member
|
Ay, the manual change on the token caused another issue. 😢 |
Member
Author
No worries, I plan to fix it now |
Member
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
jbudz
approved these changes
Oct 7, 2024
Contributor
|
Starting backport for target branches: 8.15, 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 7, 2024
… tokens (elastic#195215) (cherry picked from commit 103acda)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 7, 2024
… tokens (elastic#195215) (cherry picked from commit 103acda)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 7, 2024
…eral GH tokens (#195215) (#195236) # Backport This will backport the following commits from `main` to `8.15`: - [github-actions: undeploy observability deployments using ephemeral GH tokens (#195215)](#195215) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Victor Martinez","email":"victormartinezrubio@gmail.com"},"sourceCommit":{"committedDate":"2024-10-07T12:14:50Z","message":"github-actions: undeploy observability deployments using ephemeral GH tokens (#195215)","sha":"103acda7472cef401e0fb28850ac8ce2d62d756f","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","skip-ci","backport:prev-major"],"title":"github-actions: undeploy observability deployments using ephemeral GH tokens","number":195215,"url":"https://github.com/elastic/kibana/pull/195215","mergeCommit":{"message":"github-actions: undeploy observability deployments using ephemeral GH tokens (#195215)","sha":"103acda7472cef401e0fb28850ac8ce2d62d756f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195215","number":195215,"mergeCommit":{"message":"github-actions: undeploy observability deployments using ephemeral GH tokens (#195215)","sha":"103acda7472cef401e0fb28850ac8ce2d62d756f"}}]}] BACKPORT--> Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
kibanamachine
added a commit
that referenced
this pull request
Oct 7, 2024
…ral GH tokens (#195215) (#195237) # Backport This will backport the following commits from `main` to `8.x`: - [github-actions: undeploy observability deployments using ephemeral GH tokens (#195215)](#195215) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Victor Martinez","email":"victormartinezrubio@gmail.com"},"sourceCommit":{"committedDate":"2024-10-07T12:14:50Z","message":"github-actions: undeploy observability deployments using ephemeral GH tokens (#195215)","sha":"103acda7472cef401e0fb28850ac8ce2d62d756f","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","skip-ci","backport:prev-major"],"title":"github-actions: undeploy observability deployments using ephemeral GH tokens","number":195215,"url":"https://github.com/elastic/kibana/pull/195215","mergeCommit":{"message":"github-actions: undeploy observability deployments using ephemeral GH tokens (#195215)","sha":"103acda7472cef401e0fb28850ac8ce2d62d756f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195215","number":195215,"mergeCommit":{"message":"github-actions: undeploy observability deployments using ephemeral GH tokens (#195215)","sha":"103acda7472cef401e0fb28850ac8ce2d62d756f"}}]}] BACKPORT--> Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove access to Vault or GH PAT and use a GH App to generate ephemeral tokens (this will change in the future to use OIDC or something similar but meanwhile let's us the least-permissive access)
It uses https://github.com/elastic/oblt-actions/tree/v1/oblt-cli/undeploy-my-kibana
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers